All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>
Subject: [Qemu-devel] [PULL 05/11] egl-headless: switch over to new display registry
Date: Wed, 28 Feb 2018 13:16:57 +0100	[thread overview]
Message-ID: <20180228121703.20816-6-kraxel@redhat.com> (raw)
In-Reply-To: <20180228121703.20816-1-kraxel@redhat.com>

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Message-id: 20180221131537.31341-6-kraxel@redhat.com
---
 include/ui/console.h |  3 ---
 ui/egl-headless.c    | 20 +++++++++++++++++++-
 vl.c                 | 12 ------------
 3 files changed, 19 insertions(+), 16 deletions(-)

diff --git a/include/ui/console.h b/include/ui/console.h
index 3ea6cf0870..94726cf190 100644
--- a/include/ui/console.h
+++ b/include/ui/console.h
@@ -456,7 +456,4 @@ int vnc_init_func(void *opaque, QemuOpts *opts, Error **errp);
 /* input.c */
 int index_from_key(const char *key, size_t key_length);
 
-/* egl-headless.c */
-void egl_headless_init(DisplayOptions *opts);
-
 #endif
diff --git a/ui/egl-headless.c b/ui/egl-headless.c
index b33e0b21fd..7c877122d3 100644
--- a/ui/egl-headless.c
+++ b/ui/egl-headless.c
@@ -164,7 +164,12 @@ static const DisplayChangeListenerOps egl_ops = {
     .dpy_gl_update           = egl_scanout_flush,
 };
 
-void egl_headless_init(DisplayOptions *opts)
+static void early_egl_headless_init(DisplayOptions *opts)
+{
+    display_opengl = 1;
+}
+
+static void egl_headless_init(DisplayState *ds, DisplayOptions *opts)
 {
     QemuConsole *con;
     egl_dpy *edpy;
@@ -188,3 +193,16 @@ void egl_headless_init(DisplayOptions *opts)
         register_displaychangelistener(&edpy->dcl);
     }
 }
+
+static QemuDisplay qemu_display_egl = {
+    .type       = DISPLAY_TYPE_EGL_HEADLESS,
+    .early_init = early_egl_headless_init,
+    .init       = egl_headless_init,
+};
+
+static void register_egl(void)
+{
+    qemu_display_register(&qemu_display_egl);
+}
+
+type_init(register_egl);
diff --git a/vl.c b/vl.c
index 2b4af34fbb..47c953f8dc 100644
--- a/vl.c
+++ b/vl.c
@@ -2153,13 +2153,7 @@ static void parse_display(const char *p)
             exit(1);
         }
     } else if (strstart(p, "egl-headless", &opts)) {
-#ifdef CONFIG_OPENGL_DMABUF
-        display_opengl = 1;
         dpy.type = DISPLAY_TYPE_EGL_HEADLESS;
-#else
-        error_report("egl support is disabled");
-        exit(1);
-#endif
     } else if (strstart(p, "curses", &opts)) {
         dpy.type = DISPLAY_TYPE_CURSES;
     } else if (strstart(p, "gtk", &opts)) {
@@ -4659,12 +4653,6 @@ int main(int argc, char **argv, char **envp)
         qemu_spice_display_init();
     }
 
-#ifdef CONFIG_OPENGL_DMABUF
-    if (dpy.type == DISPLAY_TYPE_EGL_HEADLESS) {
-        egl_headless_init(&dpy);
-    }
-#endif
-
     if (foreach_device_config(DEV_GDB, gdbserver_start) < 0) {
         exit(1);
     }
-- 
2.9.3

  parent reply	other threads:[~2018-02-28 12:17 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-28 12:16 [Qemu-devel] [PULL 00/11] Ui 20180228 patches Gerd Hoffmann
2018-02-28 12:16 ` [Qemu-devel] [PULL 01/11] console: add qemu display registry, add gtk Gerd Hoffmann
2018-02-28 12:16 ` [Qemu-devel] [PULL 02/11] sdl: switch over to new display registry Gerd Hoffmann
2018-02-28 12:16 ` [Qemu-devel] [PULL 03/11] cocoa: " Gerd Hoffmann
2018-02-28 12:16 ` [Qemu-devel] [PULL 04/11] curses: " Gerd Hoffmann
2018-02-28 12:16 ` Gerd Hoffmann [this message]
2018-02-28 12:16 ` [Qemu-devel] [PULL 06/11] console: add and use qemu_display_find_default Gerd Hoffmann
2018-02-28 12:16 ` [Qemu-devel] [PULL 07/11] console: add ui module loading support Gerd Hoffmann
2018-02-28 12:17 ` [Qemu-devel] [PULL 08/11] configure: add X11 vars to config-host.mak Gerd Hoffmann
2018-02-28 12:17 ` [Qemu-devel] [PULL 09/11] configure: opengl doesn't depend on x11 Gerd Hoffmann
2018-02-28 12:17 ` [Qemu-devel] [PULL 10/11] gtk: build as ui module Gerd Hoffmann
2018-02-28 12:17 ` [Qemu-devel] [PULL 11/11] curses: " Gerd Hoffmann
2018-02-28 12:57 ` [Qemu-devel] [PULL 00/11] Ui 20180228 patches no-reply
2018-03-01 10:06   ` Gerd Hoffmann
2018-02-28 13:26 ` no-reply
2018-02-28 14:09 ` no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180228121703.20816-6-kraxel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.