From: Max Reitz <mreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>,
Kevin Wolf <kwolf@redhat.com>,
"Daniel P . Berrange" <berrange@redhat.com>,
qemu-stable@nongnu.org
Subject: [Qemu-devel] [PATCH 0/2] block/file-posix: Fix fully preallocated truncate
Date: Wed, 28 Feb 2018 14:13:13 +0100 [thread overview]
Message-ID: <20180228131315.30194-1-mreitz@redhat.com> (raw)
Fully preallocated truncation has a 50 % chance of working on images
files over file-posix. It works if $SIZE % 4G < 2G, and it fails
otherwise. To make things even more interesting, often you would not
even notice because qemu reported success even though it did nothing
(because after the successful lseek(), errno was still 0, so when the
file-posix driver tried to return a negative error code, it actually
reported success).
This issue is fixed by patch 1 in this series. Thanks to Daniel for
reporting!
Max Reitz (2):
block/file-posix: Fix fully preallocated truncate
iotests: Test preallocated truncate of 2G image
block/file-posix.c | 5 +++--
tests/qemu-iotests/106 | 24 ++++++++++++++++++++++++
tests/qemu-iotests/106.out | 10 ++++++++++
3 files changed, 37 insertions(+), 2 deletions(-)
--
2.14.3
next reply other threads:[~2018-02-28 13:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-28 13:13 Max Reitz [this message]
2018-02-28 13:13 ` [Qemu-devel] [PATCH 1/2] block/file-posix: Fix fully preallocated truncate Max Reitz
2018-02-28 13:34 ` Daniel P. Berrangé
2018-02-28 13:45 ` Max Reitz
2018-02-28 13:53 ` Daniel P. Berrangé
2018-02-28 13:55 ` Max Reitz
2018-02-28 13:59 ` Daniel P. Berrangé
2018-02-28 14:20 ` Eric Blake
2018-02-28 13:58 ` Daniel P. Berrangé
2018-02-28 13:13 ` [Qemu-devel] [PATCH 2/2] iotests: Test preallocated truncate of 2G image Max Reitz
2018-02-28 14:02 ` Daniel P. Berrangé
2018-02-28 14:22 ` [Qemu-devel] [PATCH 0/2] block/file-posix: Fix fully preallocated truncate Eric Blake
2018-03-26 20:30 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180228131315.30194-1-mreitz@redhat.com \
--to=mreitz@redhat.com \
--cc=berrange@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.