[Buildroot] [PATCH] package/qt5/qt5scxml: install missing QML module

[Buildroot] [PATCH] package/qt5/qt5scxml: install missing QML module

[Bartosz Bilas]

This patch add support for scxml module in QML projects.
When would you like to use state machines in qml files,
you get an error like this:

qrc:/MainUI.qml:2 module "QtScxml" is not installed


Signed-off-by: Bartosz Bilas <b.bilas@grinn-global.com>
---
 package/qt5/qt5scxml/qt5scxml.mk | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/package/qt5/qt5scxml/qt5scxml.mk b/package/qt5/qt5scxml/qt5scxml.mk
index 2d197a2bca..3f0f1a9054 100644
--- a/package/qt5/qt5scxml/qt5scxml.mk
+++ b/package/qt5/qt5scxml/qt5scxml.mk
@@ -35,6 +35,12 @@ define QT5SCXML_INSTALL_TARGET_LIBS
 endef
 endif
 
+ifeq ($(BR2_PACKAGE_QT5DECLARATIVE_QUICK),y)
+define QT5SCXML_INSTALL_TARGET_QMLS
+	cp -dpfr $(STAGING_DIR)/usr/qml/QtScxml/ $(TARGET_DIR)/usr/qml/
+endef
+endif
+
 ifeq ($(BR2_PACKAGE_QT5BASE_EXAMPLES),y)
 define QT5SCXML_INSTALL_TARGET_EXAMPLES
 	cp -dpfr $(STAGING_DIR)/usr/lib/qt/examples/scxml $(TARGET_DIR)/usr/lib/qt/examples/
@@ -43,6 +49,7 @@ endif
 
 define QT5SCXML_INSTALL_TARGET_CMDS
 	$(QT5SCXML_INSTALL_TARGET_LIBS)
+	$(QT5SCXML_INSTALL_TARGET_QMLS)
 	$(QT5SCXML_INSTALL_TARGET_EXAMPLES)
 endef
 
-- 
2.11.0

[Buildroot] [PATCH] package/qt5/qt5scxml: install missing QML module

[Peter Seiderer]

Hello Bartosz,

first thanks for the suggested patch.
 
On Thu,  1 Mar 2018 08:46:10 +0100, Bartosz Bilas <b.bilas@grinn-global.com> wrote:

> This patch add support for scxml module in QML projects.
> When would you like to use state machines in qml files,
> you get an error like this:
> 
> qrc:/MainUI.qml:2 module "QtScxml" is not installed
> 

Patch subject: 'qt5scxml: install missing QML module' and

  Fixes:

    qrc:/MainUI.qml:2 module "QtScxml" is not installed

would be enough (I think the patched lines are self-explanatory)...

> 
> Signed-off-by: Bartosz Bilas <b.bilas@grinn-global.com>
> ---
>  package/qt5/qt5scxml/qt5scxml.mk | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/package/qt5/qt5scxml/qt5scxml.mk b/package/qt5/qt5scxml/qt5scxml.mk
> index 2d197a2bca..3f0f1a9054 100644
> --- a/package/qt5/qt5scxml/qt5scxml.mk
> +++ b/package/qt5/qt5scxml/qt5scxml.mk
> @@ -35,6 +35,12 @@ define QT5SCXML_INSTALL_TARGET_LIBS
>  endef
>  endif
>  
> +ifeq ($(BR2_PACKAGE_QT5DECLARATIVE_QUICK),y)
> +define QT5SCXML_INSTALL_TARGET_QMLS
> +	cp -dpfr $(STAGING_DIR)/usr/qml/QtScxml/ $(TARGET_DIR)/usr/qml/
> +endef
> +endif
> +

The dependency on BR2_PACKAGE_QT5DECLARATIVE_QUICK is not needed, the QtScxml
module is build/installed even without enabled BR2_PACKAGE_QT5DECLARATIVE_QUICK...

With this changes you can add my

Reviewed-by: Peter Seiderer <ps.report@gmx.net>

Regards,
Peter


>  ifeq ($(BR2_PACKAGE_QT5BASE_EXAMPLES),y)
>  define QT5SCXML_INSTALL_TARGET_EXAMPLES
>  	cp -dpfr $(STAGING_DIR)/usr/lib/qt/examples/scxml $(TARGET_DIR)/usr/lib/qt/examples/
> @@ -43,6 +49,7 @@ endif
>  
>  define QT5SCXML_INSTALL_TARGET_CMDS
>  	$(QT5SCXML_INSTALL_TARGET_LIBS)
> +	$(QT5SCXML_INSTALL_TARGET_QMLS)
>  	$(QT5SCXML_INSTALL_TARGET_EXAMPLES)
>  endef
>  

[Buildroot] [PATCH] package/qt5/qt5scxml: install missing QML module

[Bartosz Biłas]

Hi Peter,

On 01.03.2018 11:50, Peter Seiderer wrote:
> Hello Bartosz,
>
> first thanks for the suggested patch.
>   
> On Thu,  1 Mar 2018 08:46:10 +0100, Bartosz Bilas <b.bilas@grinn-global.com> wrote:
>
>> This patch add support for scxml module in QML projects.
>> When would you like to use state machines in qml files,
>> you get an error like this:
>>
>> qrc:/MainUI.qml:2 module "QtScxml" is not installed
>>
> Patch subject: 'qt5scxml: install missing QML module' and
>
>    Fixes:
>
>      qrc:/MainUI.qml:2 module "QtScxml" is not installed
>
> would be enough (I think the patched lines are self-explanatory)...
>
>> Signed-off-by: Bartosz Bilas <b.bilas@grinn-global.com>
>> ---
>>   package/qt5/qt5scxml/qt5scxml.mk | 7 +++++++
>>   1 file changed, 7 insertions(+)
>>
>> diff --git a/package/qt5/qt5scxml/qt5scxml.mk b/package/qt5/qt5scxml/qt5scxml.mk
>> index 2d197a2bca..3f0f1a9054 100644
>> --- a/package/qt5/qt5scxml/qt5scxml.mk
>> +++ b/package/qt5/qt5scxml/qt5scxml.mk
>> @@ -35,6 +35,12 @@ define QT5SCXML_INSTALL_TARGET_LIBS
>>   endef
>>   endif
>>   
>> +ifeq ($(BR2_PACKAGE_QT5DECLARATIVE_QUICK),y)
>> +define QT5SCXML_INSTALL_TARGET_QMLS
>> +	cp -dpfr $(STAGING_DIR)/usr/qml/QtScxml/ $(TARGET_DIR)/usr/qml/
>> +endef
>> +endif
>> +
> The dependency on BR2_PACKAGE_QT5DECLARATIVE_QUICK is not needed, the QtScxml
> module is build/installed even without enabled BR2_PACKAGE_QT5DECLARATIVE_QUICK...
I was thinking about it but without qt quick this module is unnecessary 
so I'm not sure that we should copy this to the image.

Best regards,
Bartosz Bi?as
>
> With this changes you can add my
>
> Reviewed-by: Peter Seiderer <ps.report@gmx.net>
>
> Regards,
> Peter
>
>
>>   ifeq ($(BR2_PACKAGE_QT5BASE_EXAMPLES),y)
>>   define QT5SCXML_INSTALL_TARGET_EXAMPLES
>>   	cp -dpfr $(STAGING_DIR)/usr/lib/qt/examples/scxml $(TARGET_DIR)/usr/lib/qt/examples/
>> @@ -43,6 +49,7 @@ endif
>>   
>>   define QT5SCXML_INSTALL_TARGET_CMDS
>>   	$(QT5SCXML_INSTALL_TARGET_LIBS)
>> +	$(QT5SCXML_INSTALL_TARGET_QMLS)
>>   	$(QT5SCXML_INSTALL_TARGET_EXAMPLES)
>>   endef
>>   

-- 

	


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180301/34a91dad/attachment.html>

[Buildroot] [PATCH] package/qt5/qt5scxml: install missing QML module

[Peter Seiderer]

Hello Bartosz,

On Thu, 1 Mar 2018 13:26:44 +0100, Bartosz Bi?as <b.bilas@grinn-global.com> wrote:

> Hi Peter,
> 
> On 01.03.2018 11:50, Peter Seiderer wrote:
> > Hello Bartosz,
> >
> > first thanks for the suggested patch.
> >   
> > On Thu,  1 Mar 2018 08:46:10 +0100, Bartosz Bilas <b.bilas@grinn-global.com> wrote:
> >  
> >> This patch add support for scxml module in QML projects.
> >> When would you like to use state machines in qml files,
> >> you get an error like this:
> >>
> >> qrc:/MainUI.qml:2 module "QtScxml" is not installed
> >>  
> > Patch subject: 'qt5scxml: install missing QML module' and
> >
> >    Fixes:
> >
> >      qrc:/MainUI.qml:2 module "QtScxml" is not installed
> >
> > would be enough (I think the patched lines are self-explanatory)...
> >  
> >> Signed-off-by: Bartosz Bilas <b.bilas@grinn-global.com>
> >> ---
> >>   package/qt5/qt5scxml/qt5scxml.mk | 7 +++++++
> >>   1 file changed, 7 insertions(+)
> >>
> >> diff --git a/package/qt5/qt5scxml/qt5scxml.mk b/package/qt5/qt5scxml/qt5scxml.mk
> >> index 2d197a2bca..3f0f1a9054 100644
> >> --- a/package/qt5/qt5scxml/qt5scxml.mk
> >> +++ b/package/qt5/qt5scxml/qt5scxml.mk
> >> @@ -35,6 +35,12 @@ define QT5SCXML_INSTALL_TARGET_LIBS
> >>   endef
> >>   endif
> >>   
> >> +ifeq ($(BR2_PACKAGE_QT5DECLARATIVE_QUICK),y)
> >> +define QT5SCXML_INSTALL_TARGET_QMLS
> >> +	cp -dpfr $(STAGING_DIR)/usr/qml/QtScxml/ $(TARGET_DIR)/usr/qml/
> >> +endef
> >> +endif
> >> +  
> > The dependency on BR2_PACKAGE_QT5DECLARATIVE_QUICK is not needed, the QtScxml
> > module is build/installed even without enabled BR2_PACKAGE_QT5DECLARATIVE_QUICK...  
> I was thinking about it but without qt quick this module is unnecessary 
> so I'm not sure that we should copy this to the image.

Mhhh, point for you ;-), I would still prefer the version without dependency on quick
(as the qt compile/configure logic does) even if a usage without quick is more or
less theoretically? But I am o.k. with both solutions in case you add a little comment...

Regards,
Peter

> 
> Best regards,
> Bartosz Bi?as
> >
> > With this changes you can add my
> >
> > Reviewed-by: Peter Seiderer <ps.report@gmx.net>
> >
> > Regards,
> > Peter
> >
> >  
> >>   ifeq ($(BR2_PACKAGE_QT5BASE_EXAMPLES),y)
> >>   define QT5SCXML_INSTALL_TARGET_EXAMPLES
> >>   	cp -dpfr $(STAGING_DIR)/usr/lib/qt/examples/scxml $(TARGET_DIR)/usr/lib/qt/examples/
> >> @@ -43,6 +49,7 @@ endif
> >>   
> >>   define QT5SCXML_INSTALL_TARGET_CMDS
> >>   	$(QT5SCXML_INSTALL_TARGET_LIBS)
> >> +	$(QT5SCXML_INSTALL_TARGET_QMLS)
> >>   	$(QT5SCXML_INSTALL_TARGET_EXAMPLES)
> >>   endef
> >>     
> 

[Buildroot] [PATCH] package/qt5/qt5scxml: install missing QML module

[Thomas Petazzoni]

Hello,

On Thu, 1 Mar 2018 11:50:03 +0100, Peter Seiderer wrote:

> The dependency on BR2_PACKAGE_QT5DECLARATIVE_QUICK is not needed, the QtScxml
> module is build/installed even without enabled BR2_PACKAGE_QT5DECLARATIVE_QUICK...

But does it make sense to install QML files if the Qt that has been
built has no way to use them ? Or am I missing something about what
BR2_PACKAGE_QT5DECLARATIVE_QUICK is ?

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com

[Buildroot] [PATCH] package/qt5/qt5scxml: install missing QML module

[Peter Seiderer]

Hello Thomas,
On Fri, 2 Mar 2018 22:24:23 +0100, Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:

> Hello,
> 
> On Thu, 1 Mar 2018 11:50:03 +0100, Peter Seiderer wrote:
> 
> > The dependency on BR2_PACKAGE_QT5DECLARATIVE_QUICK is not needed, the QtScxml
> > module is build/installed even without enabled BR2_PACKAGE_QT5DECLARATIVE_QUICK...  
> 
> But does it make sense to install QML files if the Qt that has been
> built has no way to use them ? Or am I missing something about what
> BR2_PACKAGE_QT5DECLARATIVE_QUICK is ?

No expert for Qml/QtQuick either, but as explained in [1] 'QML is the Language (just like C++)'
and 'QtQuick is a toolkit for QML, allowing to develop graphical interface in QML language
(there are other toolkits for QML, some are graphical like Sailfish Silica or BlackBerry Cascade,
and some are non-graphical like QBS...'

Qscxml is usable from QtQuick, but QtQuick is no prerequisite to use Qscxml (from a theoretical
point of view (and practical the QML module is buildable  without QtQuick))....

Regards,
Peter

[1] https://stackoverflow.com/questions/19696153/difference-between-qt-qml-and-qt-quick

> 
> Best regards,
> 
> Thomas

[Buildroot] [PATCH] package/qt5/qt5scxml: install missing QML module

[Bartosz Biłas]

Hi Thomas,
In my opinion no, according to the other packages they also have 
dependence on qt quick
and if it is not selected then they do not install files related to QML.

Best regards,
Bartosz Bi?as


On 02.03.2018 22:24, Thomas Petazzoni wrote:
> Hello,
>
> On Thu, 1 Mar 2018 11:50:03 +0100, Peter Seiderer wrote:
>
>> The dependency on BR2_PACKAGE_QT5DECLARATIVE_QUICK is not needed, the QtScxml
>> module is build/installed even without enabled BR2_PACKAGE_QT5DECLARATIVE_QUICK...
> But does it make sense to install QML files if the Qt that has been
> built has no way to use them ? Or am I missing something about what
> BR2_PACKAGE_QT5DECLARATIVE_QUICK is ?
>
> Best regards,
>
> Thomas

-- 
Bartosz Bi?as
	Grinn sp. z o.o. <http://grinn-global.com>
Junior Software Developer

	
LinkedIn <https://www.linkedin.com/company/grinn> 	Twitter 
<https://twitter.com/GrinnInt> 	YouTube 
<https://www.youtube.com/channel/UCiiEEK1yzyeMSeku06RFXPQ>

GRINN sp. z o.o
Wagonowa 2
53-609 Wroc?aw 	tel. +48 71 716 40 99
fax +48 71 716 41 53
www.grinn-global.com <http://grinn-global.com/> 	KRS: 0000230049
NIP: 8992730302
REGON: 020047322 	S?d Rejonowy we Wroc?awiu
VI Wydzia? Gospodarczy
Kapita? zak?adowy: 125.000,00 z?


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180307/a43b828d/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Grinn.png
Type: image/png
Size: 5695 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180307/a43b828d/attachment.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: LinkedIn.png
Type: image/png
Size: 521 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180307/a43b828d/attachment-0001.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Twitter.png
Type: image/png
Size: 338 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180307/a43b828d/attachment-0002.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: YouTube.png
Type: image/png
Size: 593 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180307/a43b828d/attachment-0003.png>