From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935789AbeCAIA0 (ORCPT ); Thu, 1 Mar 2018 03:00:26 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:60360 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S934962AbeCAIAY (ORCPT ); Thu, 1 Mar 2018 03:00:24 -0500 Date: Thu, 1 Mar 2018 09:00:16 +0100 From: Martin Schwidefsky To: Matthew Wilcox Cc: linux-mm@kvack.org, Matthew Wilcox , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 0/4] Split page_type out from mapcount In-Reply-To: <20180301081750.42b135c3@mschwideX1> References: <20180228223157.9281-1-willy@infradead.org> <20180301081750.42b135c3@mschwideX1> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 18030108-0020-0000-0000-000003FD34F5 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18030108-0021-0000-0000-0000429161C3 Message-Id: <20180301090016.01a54a5f@mschwideX1> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-03-01_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=2 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1803010105 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 1 Mar 2018 08:17:50 +0100 Martin Schwidefsky wrote: > On Wed, 28 Feb 2018 14:31:53 -0800 > Matthew Wilcox wrote: > > > From: Matthew Wilcox > > > > I want to use the _mapcount field to record what a page is in use as. > > This can help with debugging and we can also expose that information to > > userspace through /proc/kpageflags to help diagnose memory usage (not > > included as part of this patch set). > > > > First, we need s390 to stop using _mapcount for its own purposes; > > Martin, I hope you have time to look at this patch. I must confess I > > don't quite understand what the different bits are used for in the upper > > nybble of the _mapcount, but I tried to replicate what you were doing > > faithfully. > > Yeah, that is a nasty bit of code. On s390 we have 2K page tables (pte) > but 4K pages. If we use full pages for the pte tables we waste 2K of > memory for each of the tables. So we allocate 4K and split it into two > 2K pieces. Now we have to keep track of the pieces to be able to free > them again. > > I try to give your patch a spin today. It should be stand-alone, no ? Ok, that seems to work just fine. System boots and survived some stress without loosing memory. Acked-by: Martin Schwidefsky -- blue skies, Martin. "Reality continues to ruin my life." - Calvin. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-f197.google.com (mail-qk0-f197.google.com [209.85.220.197]) by kanga.kvack.org (Postfix) with ESMTP id DC4556B0005 for ; Thu, 1 Mar 2018 03:00:25 -0500 (EST) Received: by mail-qk0-f197.google.com with SMTP id u200so4024244qka.21 for ; Thu, 01 Mar 2018 00:00:25 -0800 (PST) Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com. [148.163.158.5]) by mx.google.com with ESMTPS id w12si623927qtb.199.2018.03.01.00.00.24 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 01 Mar 2018 00:00:24 -0800 (PST) Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w217xCZb057747 for ; Thu, 1 Mar 2018 03:00:23 -0500 Received: from e06smtp15.uk.ibm.com (e06smtp15.uk.ibm.com [195.75.94.111]) by mx0b-001b2d01.pphosted.com with ESMTP id 2gec4subpt-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Thu, 01 Mar 2018 03:00:23 -0500 Received: from localhost by e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 1 Mar 2018 08:00:22 -0000 Date: Thu, 1 Mar 2018 09:00:16 +0100 From: Martin Schwidefsky Subject: Re: [PATCH v3 0/4] Split page_type out from mapcount In-Reply-To: <20180301081750.42b135c3@mschwideX1> References: <20180228223157.9281-1-willy@infradead.org> <20180301081750.42b135c3@mschwideX1> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-Id: <20180301090016.01a54a5f@mschwideX1> Sender: owner-linux-mm@kvack.org List-ID: To: Matthew Wilcox Cc: linux-mm@kvack.org, Matthew Wilcox , linux-kernel@vger.kernel.org On Thu, 1 Mar 2018 08:17:50 +0100 Martin Schwidefsky wrote: > On Wed, 28 Feb 2018 14:31:53 -0800 > Matthew Wilcox wrote: > > > From: Matthew Wilcox > > > > I want to use the _mapcount field to record what a page is in use as. > > This can help with debugging and we can also expose that information to > > userspace through /proc/kpageflags to help diagnose memory usage (not > > included as part of this patch set). > > > > First, we need s390 to stop using _mapcount for its own purposes; > > Martin, I hope you have time to look at this patch. I must confess I > > don't quite understand what the different bits are used for in the upper > > nybble of the _mapcount, but I tried to replicate what you were doing > > faithfully. > > Yeah, that is a nasty bit of code. On s390 we have 2K page tables (pte) > but 4K pages. If we use full pages for the pte tables we waste 2K of > memory for each of the tables. So we allocate 4K and split it into two > 2K pieces. Now we have to keep track of the pieces to be able to free > them again. > > I try to give your patch a spin today. It should be stand-alone, no ? Ok, that seems to work just fine. System boots and survived some stress without loosing memory. Acked-by: Martin Schwidefsky -- blue skies, Martin. "Reality continues to ruin my life." - Calvin. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org