All of lore.kernel.org
 help / color / mirror / Atom feed
From: "zhangyi (F)" <yi.zhang@huawei.com>
To: eguan@redhat.com, fstests@vger.kernel.org
Cc: linux-unionfs@vger.kernel.org, miklos@szeredi.hu,
	amir73il@gmail.com, yi.zhang@huawei.com, miaoxie@huawei.com,
	yangerkun@huawei.com
Subject: [xfstests PATCH v5 3/5] overlay/003: fix fs check failure
Date: Thu, 1 Mar 2018 20:13:45 +0800	[thread overview]
Message-ID: <20180301121347.5824-4-yi.zhang@huawei.com> (raw)
In-Reply-To: <20180301121347.5824-1-yi.zhang@huawei.com>

_check_overlay_scratch_fs() will check lowerdir of overlay filesystem,
this case remove this directory after test will lead to check failure,
and it is not really necessary to remove this directory, so keep this
directory.

Signed-off-by: zhangyi (F) <yi.zhang@huawei.com>
Reviewed-by: Amir Goldstein <amir73il@gmail.com>
---
 tests/overlay/003 | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tests/overlay/003 b/tests/overlay/003
index f980edb..154531e 100755
--- a/tests/overlay/003
+++ b/tests/overlay/003
@@ -92,7 +92,6 @@ ls ${SCRATCH_MNT}/
 # unmount overlayfs but not base fs
 $UMOUNT_PROG $SCRATCH_MNT
 
-rm -rf $lowerdir
 echo "Silence is golden"
 # success, all done
 status=0
-- 
2.5.0

  parent reply	other threads:[~2018-03-01 12:13 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-01 12:13 [xfstests PATCH v5 0/5] overlay: add overlay filesystem dirs check zhangyi (F)
2018-03-01 12:13 ` [xfstests PATCH v5 1/5] common/rc: improve dev mounted check helper zhangyi (F)
2018-03-01 12:13 ` [xfstests PATCH v5 2/5] overlay: hook filesystem " zhangyi (F)
2018-03-01 13:03   ` Amir Goldstein
2018-03-01 13:11     ` zhangyi (F)
2018-03-11  8:12       ` Amir Goldstein
2018-03-12  8:44         ` zhangyi (F)
2018-03-12  9:19           ` Amir Goldstein
2018-03-12 12:34             ` zhangyi (F)
2018-03-01 13:17     ` Eryu Guan
2018-03-01 12:13 ` zhangyi (F) [this message]
2018-03-01 12:13 ` [xfstests PATCH v5 4/5] overlay: skip check for tests finished with corrupt filesystem zhangyi (F)
2018-03-01 12:13 ` [xfstests PATCH v5 5/5] overlay: correct scratch dirs check zhangyi (F)
2018-03-01 13:09   ` Amir Goldstein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180301121347.5824-4-yi.zhang@huawei.com \
    --to=yi.zhang@huawei.com \
    --cc=amir73il@gmail.com \
    --cc=eguan@redhat.com \
    --cc=fstests@vger.kernel.org \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=miaoxie@huawei.com \
    --cc=miklos@szeredi.hu \
    --cc=yangerkun@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.