All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Quytelda Kahja <quytelda@tamalin.org>
Cc: devel@driverdev.osuosl.org, christian.gromm@microchip.com,
	chris@engineersdelight.de, linux-kernel@vger.kernel.org,
	Michael.Fabry@microchip.com
Subject: Re: [PATCH 1/4] staging: most: Fix coding style problems.
Date: Thu, 1 Mar 2018 17:20:34 +0100	[thread overview]
Message-ID: <20180301162034.GA15087@kroah.com> (raw)
In-Reply-To: <20180224075835.11618-1-quytelda@tamalin.org>

On Fri, Feb 23, 2018 at 11:58:32PM -0800, Quytelda Kahja wrote:
> Makes two very minor changes indicated by checkpatch:
> 1) Add a newline after components_show() definition.
> 2) Fix a line over the 80 character limit.

Do not do multiple things in the same patch, whenever possible.  Please
break this up into 2 patches.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

  parent reply	other threads:[~2018-03-01 16:20 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-24  7:58 [PATCH 1/4] staging: most: Fix coding style problems Quytelda Kahja
2018-02-24  7:58 ` [PATCH 2/4] staging: most: Replace calls to BUG_ON() with WARN_ONCE() and return Quytelda Kahja
2018-03-01 16:21   ` Greg KH
2018-03-06  9:23     ` Quytelda Kahja
2018-03-06  9:47       ` Dan Carpenter
2018-03-07  1:31         ` [PATCH] staging: most: Remove unnecessary usage of BUG_ON() Quytelda Kahja
2018-03-07  8:37           ` Christian Gromm
2018-02-24  7:58 ` [PATCH 3/4] staging: most: Remove unnecessary OOM messages Quytelda Kahja
2018-02-24  7:58 ` [PATCH 4/4] staging: most: Fix missing identifier in function definition argument Quytelda Kahja
2018-03-01 16:20 ` Greg KH [this message]
2018-03-02  2:11   ` [PATCH 1/2] staging: most: Fix a coding style problem Quytelda Kahja
2018-03-02  2:11     ` [PATCH 2/2] " Quytelda Kahja
2018-03-02 10:12       ` Dan Carpenter
2018-03-06  9:18         ` [PATCH v2 1/2] staging: most: Add a blank line Quytelda Kahja
2018-03-06  9:34         ` [PATCH v2 2/2] staging: most: Indent function parameter Quytelda Kahja

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180301162034.GA15087@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Michael.Fabry@microchip.com \
    --cc=chris@engineersdelight.de \
    --cc=christian.gromm@microchip.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quytelda@tamalin.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.