Hi Benoit, On Thu, Mar 01, 2018 at 02:09:18PM -0600, Benoit Parrot wrote: > > + /* > > + * FIXME: Once we'll have internal D-PHY support, the check > > + * will need to be removed. > > + */ > > + if (csi2rx->has_internal_dphy) { > > + dev_err(&pdev->dev, "Internal D-PHY not supported yet\n"); > > + return -EINVAL; > > + } > > As one of the more critical thing is usually how the CSI2 Receiver interact > with a DPHY when can we expect this part of the driver to be implemented? That's definitely on my radar, but it isn't implemented by any hardware or simulation at the moment. When that is done, we will obviously do it. Maxime -- Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com