All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@gmail.com>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	linux-tegra@vger.kernel.org, linux-pci@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC 5/5] PCI: tegra: use seq_open_data
Date: Fri, 2 Mar 2018 11:42:07 +0100	[thread overview]
Message-ID: <20180302104207.GB27178@ulmo> (raw)
In-Reply-To: <20180301233724.20440-5-linux@rasmusvillemoes.dk>

[-- Attachment #1: Type: text/plain, Size: 522 bytes --]

On Fri, Mar 02, 2018 at 12:37:24AM +0100, Rasmus Villemoes wrote:
> Simplify the code slightly by having seq_open_data do the ->private
> assignment.
> 
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
> ---
>  drivers/pci/host/pci-tegra.c | 11 +----------
>  1 file changed, 1 insertion(+), 10 deletions(-)

I had to go hunt for patch 1/5 to be able to tell if this is indeed
equivalent. It is, so:

Reviewed-by: Thierry Reding <treding@nvidia.com>
Acked-by: Thierry Reding <treding@nvidia.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2018-03-02 10:42 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-01 23:37 [RFC 1/5] seq_file: introduce seq_open_data helper Rasmus Villemoes
2018-03-01 23:37 ` Rasmus Villemoes
2018-03-01 23:37 ` Rasmus Villemoes
2018-03-01 23:37 ` [RFC 2/5] ia64/sn/hwperf: use seq_open_data Rasmus Villemoes
2018-03-01 23:37   ` Rasmus Villemoes
2018-03-02  8:22   ` Rasmus Villemoes
2018-03-02  8:22     ` Rasmus Villemoes
2018-03-01 23:37 ` [RFC 3/5] powerpc/pseries: use seq_open_data in hcall_inst_seq_open Rasmus Villemoes
2018-03-01 23:37 ` [RFC 4/5] fm10k: use seq_open_data() Rasmus Villemoes
2018-03-01 23:37   ` [Intel-wired-lan] " Rasmus Villemoes
2018-03-01 23:37 ` [RFC 5/5] PCI: tegra: use seq_open_data Rasmus Villemoes
2018-03-02 10:42   ` Thierry Reding [this message]
2018-03-07 12:41     ` Lorenzo Pieralisi
2018-04-25  9:38       ` Lorenzo Pieralisi
2018-03-01 23:44 ` [RFC 1/5] seq_file: introduce seq_open_data helper Andreas Dilger
2018-03-01 23:44   ` Andreas Dilger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180302104207.GB27178@ulmo \
    --to=thierry.reding@gmail.com \
    --cc=bhelgaas@google.com \
    --cc=jonathanh@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=lorenzo.pieralisi@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.