From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com ([66.111.4.29]:56401 "EHLO out5-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1424132AbeCBNWI (ORCPT ); Fri, 2 Mar 2018 08:22:08 -0500 Date: Fri, 2 Mar 2018 15:22:04 +0200 From: Ido Schimmel To: David Ahern Cc: netdev@vger.kernel.org, davem@davemloft.net, roopa@cumulusnetworks.com, nikolay@cumulusnetworks.com, tom@herbertland.com Subject: Re: [PATCH v2 net-next 02/10] net: Align ip_multipath_l3_keys and ip6_multipath_l3_keys Message-ID: <20180302132204.GB23979@splinter> References: <20180302032950.21154-1-dsahern@gmail.com> <20180302032950.21154-3-dsahern@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180302032950.21154-3-dsahern@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, Mar 01, 2018 at 07:29:42PM -0800, David Ahern wrote: > Symmetry is good and allows easy comparison that ipv4 and ipv6 are > doing the same thing. To that end, change ip_multipath_l3_keys to > set addresses at the end after the icmp compares, and move the > initialization of ipv6 flow keys to rt6_multipath_hash. > > Signed-off-by: David Ahern Reviewed-by: Ido Schimmel