From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com ([66.111.4.29]:43477 "EHLO out5-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1423276AbeCBNfQ (ORCPT ); Fri, 2 Mar 2018 08:35:16 -0500 Date: Fri, 2 Mar 2018 15:35:13 +0200 From: Ido Schimmel To: David Ahern Cc: netdev@vger.kernel.org, davem@davemloft.net, roopa@cumulusnetworks.com, nikolay@cumulusnetworks.com, tom@herbertland.com Subject: Re: [PATCH v2 net-next 04/10] net/ipv6: Make rt6_multipath_hash similar to fib_multipath_hash Message-ID: <20180302133513.GD23979@splinter> References: <20180302032950.21154-1-dsahern@gmail.com> <20180302032950.21154-5-dsahern@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180302032950.21154-5-dsahern@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, Mar 01, 2018 at 07:29:44PM -0800, David Ahern wrote: > Make rt6_multipath_hash more of a direct parallel to fib_multipath_hash > and reduce stack and overhead in the process: get_hash_from_flowi6 is > just a wrapper around __get_hash_from_flowi6 with another stack > allocation for flow_keys. Move setting the addresses, protocol and > label into rt6_multipath_hash and allow it to make the call to > flow_hash_from_keys. > > Signed-off-by: David Ahern Reviewed-by: Ido Schimmel