* [PATCH] init/ramdisk: use pr_cont() at the end of ramdisk loading
@ 2018-03-02 20:55 Aaro Koskinen
2018-03-03 16:14 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Aaro Koskinen @ 2018-03-02 20:55 UTC (permalink / raw)
To: linux-kernel, Linus Torvalds, Andrew Morton; +Cc: Aaro Koskinen
Use pr_cont() at the end of ramdisk loading. This will avoid the rotator
and an extra newline appearing in the dmesg.
Before:
[ 0.868650] RAMDISK: Loading 2436KiB [1 disk] into ram disk... |
[ 1.490464] done.
After:
[ 0.868587] RAMDISK: Loading 2436KiB [1 disk] into ram disk... done.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
---
init/do_mounts_rd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/init/do_mounts_rd.c b/init/do_mounts_rd.c
index 99e0b64..e3cba12 100644
--- a/init/do_mounts_rd.c
+++ b/init/do_mounts_rd.c
@@ -255,7 +255,7 @@ int __init rd_load_image(char *from)
nblocks, ((nblocks-1)/devblocks)+1, nblocks>devblocks ? "s" : "");
for (i = 0, disk = 1; i < nblocks; i++) {
if (i && (i % devblocks == 0)) {
- printk("done disk #%d.\n", disk++);
+ pr_cont("done disk #%d.\n", disk++);
rotate = 0;
if (sys_close(in_fd)) {
printk("Error closing the disk.\n");
@@ -278,7 +278,7 @@ int __init rd_load_image(char *from)
}
#endif
}
- printk("done.\n");
+ pr_cont("done.\n");
successful_load:
res = 1;
--
2.9.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] init/ramdisk: use pr_cont() at the end of ramdisk loading
2018-03-02 20:55 [PATCH] init/ramdisk: use pr_cont() at the end of ramdisk loading Aaro Koskinen
@ 2018-03-03 16:14 ` Andy Shevchenko
2018-03-04 20:39 ` Aaro Koskinen
0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2018-03-03 16:14 UTC (permalink / raw)
To: Aaro Koskinen; +Cc: Linux Kernel Mailing List, Linus Torvalds, Andrew Morton
On Fri, Mar 2, 2018 at 10:55 PM, Aaro Koskinen <aaro.koskinen@iki.fi> wrote:
> Use pr_cont() at the end of ramdisk loading. This will avoid the rotator
> and an extra newline appearing in the dmesg.
> printk("Error closing the disk.\n");
What about this one?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] init/ramdisk: use pr_cont() at the end of ramdisk loading
2018-03-03 16:14 ` Andy Shevchenko
@ 2018-03-04 20:39 ` Aaro Koskinen
0 siblings, 0 replies; 3+ messages in thread
From: Aaro Koskinen @ 2018-03-04 20:39 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: Linux Kernel Mailing List, Linus Torvalds, Andrew Morton
Hi,
On Sat, Mar 03, 2018 at 06:14:33PM +0200, Andy Shevchenko wrote:
> On Fri, Mar 2, 2018 at 10:55 PM, Aaro Koskinen <aaro.koskinen@iki.fi> wrote:
> > Use pr_cont() at the end of ramdisk loading. This will avoid the rotator
> > and an extra newline appearing in the dmesg.
>
> > printk("Error closing the disk.\n");
>
> What about this one?
I think it should be left as is.
A.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-03-04 20:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-02 20:55 [PATCH] init/ramdisk: use pr_cont() at the end of ramdisk loading Aaro Koskinen
2018-03-03 16:14 ` Andy Shevchenko
2018-03-04 20:39 ` Aaro Koskinen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.