From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44392) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1err9m-0005KK-In for qemu-devel@nongnu.org; Fri, 02 Mar 2018 15:19:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1err9j-0005K8-FD for qemu-devel@nongnu.org; Fri, 02 Mar 2018 15:19:54 -0500 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:42906 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1err9j-0005Jo-AO for qemu-devel@nongnu.org; Fri, 02 Mar 2018 15:19:51 -0500 Date: Fri, 2 Mar 2018 22:19:42 +0200 From: "Michael S. Tsirkin" Message-ID: <20180302221831-mutt-send-email-mst@kernel.org> References: <7fc612d0-9610-9b07-d054-bb1438898f47@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <7fc612d0-9610-9b07-d054-bb1438898f47@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 4/4] virtio-net: add linkspeed and duplex settings to virtio-net List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jason Wang Cc: Jason Baron , qemu-devel@nongnu.org, virtio-dev@lists.oasis-open.org On Fri, Mar 02, 2018 at 03:14:01PM +0800, Jason Wang wrote: >=20 >=20 > On 2018=E5=B9=B403=E6=9C=8802=E6=97=A5 11:46, Jason Baron wrote: > > Although linkspeed and duplex can be set in a linux guest via 'ethtoo= l -s', > > this requires custom ethtool commands for virtio-net by default. > >=20 > > Introduce a new feature flag, VIRTIO_NET_F_SPEED_DUPLEX, which allows > > the hypervisor to export a linkspeed and duplex setting. The user can > > subsequently overwrite it later if desired via: 'ethtool -s'. > >=20 > > Linkspeed and duplex settings can be set as: > > '-device virtio-net,speed=3D10000,duplex=3Dfull' >=20 > I was thinking whether or not it's better to decide the duplex by the t= ype > of backends. >=20 > E.g userspace and vhost-kernel implement a in fact half duplex. But dpd= k > implement a full duplex. >=20 > Thanks OTOH it's a priority for some people to be able to support migration between different backend types. Breaking that won't be nice. > >=20 > > where speed is [0...INT_MAX], and duplex is ["half"|"full"]. > >=20 > > Signed-off-by: Jason Baron > > Cc: "Michael S. Tsirkin" > > Cc: Jason Wang > > Cc:virtio-dev@lists.oasis-open.org > > --- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: virtio-dev-return-3384-cohuck=redhat.com@lists.oasis-open.org Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [66.179.20.138]) by lists.oasis-open.org (Postfix) with ESMTP id B7E805818F64 for ; Fri, 2 Mar 2018 12:19:56 -0800 (PST) Date: Fri, 2 Mar 2018 22:19:42 +0200 From: "Michael S. Tsirkin" Message-ID: <20180302221831-mutt-send-email-mst@kernel.org> References: <7fc612d0-9610-9b07-d054-bb1438898f47@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7fc612d0-9610-9b07-d054-bb1438898f47@redhat.com> Subject: [virtio-dev] Re: [PATCH 4/4] virtio-net: add linkspeed and duplex settings to virtio-net To: Jason Wang Cc: Jason Baron , qemu-devel@nongnu.org, virtio-dev@lists.oasis-open.org List-ID: On Fri, Mar 02, 2018 at 03:14:01PM +0800, Jason Wang wrote: > > > On 2018年03月02日 11:46, Jason Baron wrote: > > Although linkspeed and duplex can be set in a linux guest via 'ethtool -s', > > this requires custom ethtool commands for virtio-net by default. > > > > Introduce a new feature flag, VIRTIO_NET_F_SPEED_DUPLEX, which allows > > the hypervisor to export a linkspeed and duplex setting. The user can > > subsequently overwrite it later if desired via: 'ethtool -s'. > > > > Linkspeed and duplex settings can be set as: > > '-device virtio-net,speed=10000,duplex=full' > > I was thinking whether or not it's better to decide the duplex by the type > of backends. > > E.g userspace and vhost-kernel implement a in fact half duplex. But dpdk > implement a full duplex. > > Thanks OTOH it's a priority for some people to be able to support migration between different backend types. Breaking that won't be nice. > > > > where speed is [0...INT_MAX], and duplex is ["half"|"full"]. > > > > Signed-off-by: Jason Baron > > Cc: "Michael S. Tsirkin" > > Cc: Jason Wang > > Cc:virtio-dev@lists.oasis-open.org > > --- --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org