All of lore.kernel.org
 help / color / mirror / Atom feed
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Santha Meena Ramamoorthy <santhameena13@gmail.com>
Cc: gregkh@linuxfoundation.org, kirk@reisers.ca,
	chris@the-brannons.com, w.d.hubbs@gmail.com,
	outreachy-kernel@googlegroups.com
Subject: Re: [PATCH] staging: speakup: match alignment with open parenthesis
Date: Mon, 5 Mar 2018 19:37:25 +0100	[thread overview]
Message-ID: <20180305183725.5a3sx6sxgr3bm2wy@var.youpi.perso.aquilenet.fr> (raw)
In-Reply-To: <1520271253-53146-1-git-send-email-santhameena13@gmail.com>

Santha Meena Ramamoorthy, on lun. 05 mars 2018 09:34:13 -0800, wrote:
> Match alignment with the open parenthesis to conform to the Linux kernel
> coding style. Issue found using checkpatch.
> 
> Signed-off-by: Santha Meena Ramamoorthy <santhameena13@gmail.com>

Acked-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

> ---
>  drivers/staging/speakup/main.c           | 2 +-
>  drivers/staging/speakup/speakup_decpc.c  | 6 +++---
>  drivers/staging/speakup/speakup_dectlk.c | 4 ++--
>  drivers/staging/speakup/speakup_keypc.c  | 4 ++--
>  drivers/staging/speakup/spk_ttyio.c      | 2 +-
>  5 files changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c
> index d7cdec3..af30b70 100644
> --- a/drivers/staging/speakup/main.c
> +++ b/drivers/staging/speakup/main.c
> @@ -417,7 +417,7 @@ static void announce_edge(struct vc_data *vc, int msg_id)
>  		bleep(spk_y);
>  	if ((spk_bleeps & 2) && (msg_id < edge_quiet))
>  		synth_printf("%s\n",
> -			spk_msg_get(MSG_EDGE_MSGS_START + msg_id - 1));
> +			     spk_msg_get(MSG_EDGE_MSGS_START + msg_id - 1));
>  }
>  
>  static void speak_char(u16 ch)
> diff --git a/drivers/staging/speakup/speakup_decpc.c b/drivers/staging/speakup/speakup_decpc.c
> index 303f393..6649309 100644
> --- a/drivers/staging/speakup/speakup_decpc.c
> +++ b/drivers/staging/speakup/speakup_decpc.c
> @@ -349,7 +349,7 @@ static int testkernel(void)
>  		return 0;
>  	else if (dt_stat == 0x0dec)
>  		pr_warn("dec_pc at 0x%x, software not loaded\n",
> -				speakup_info.port_tts);
> +			speakup_info.port_tts);
>  	status = -3;
>  oops:	synth_release_region(speakup_info.port_tts, SYNTH_IO_EXTENT);
>  	speakup_info.port_tts = 0;
> @@ -412,11 +412,11 @@ static void do_catch_up(struct spk_synth *synth)
>  				if (!in_escape)
>  					dt_sendchar(PROCSPEECH);
>  				spin_lock_irqsave(&speakup_info.spinlock,
> -							flags);
> +						  flags);
>  				jiffy_delta_val = jiffy_delta->u.n.value;
>  				delay_time_val = delay_time->u.n.value;
>  				spin_unlock_irqrestore(&speakup_info.spinlock,
> -							flags);
> +						       flags);
>  				schedule_timeout(msecs_to_jiffies
>  						 (delay_time_val));
>  				jiff_max = jiffies + jiffy_delta_val;
> diff --git a/drivers/staging/speakup/speakup_dectlk.c b/drivers/staging/speakup/speakup_dectlk.c
> index 2ea22a2..a144f28 100644
> --- a/drivers/staging/speakup/speakup_dectlk.c
> +++ b/drivers/staging/speakup/speakup_dectlk.c
> @@ -262,11 +262,11 @@ static void do_catch_up(struct spk_synth *synth)
>  				if (!in_escape)
>  					synth->io_ops->synth_out(synth, PROCSPEECH);
>  				spin_lock_irqsave(&speakup_info.spinlock,
> -						flags);
> +						  flags);
>  				jiffy_delta_val = jiffy_delta->u.n.value;
>  				delay_time_val = delay_time->u.n.value;
>  				spin_unlock_irqrestore(&speakup_info.spinlock,
> -						flags);
> +						       flags);
>  				schedule_timeout(msecs_to_jiffies
>  						 (delay_time_val));
>  				jiff_max = jiffies + jiffy_delta_val;
> diff --git a/drivers/staging/speakup/speakup_keypc.c b/drivers/staging/speakup/speakup_keypc.c
> index de76183..3901734 100644
> --- a/drivers/staging/speakup/speakup_keypc.c
> +++ b/drivers/staging/speakup/speakup_keypc.c
> @@ -260,7 +260,7 @@ static int synth_probe(struct spk_synth *synth)
>  	if (port_forced) {
>  		synth_port = port_forced;
>  		pr_info("probe forced to %x by kernel command line\n",
> -				synth_port);
> +			synth_port);
>  		if (synth_request_region(synth_port-1, SYNTH_IO_EXTENT)) {
>  			pr_warn("sorry, port already reserved\n");
>  			return -EBUSY;
> @@ -269,7 +269,7 @@ static int synth_probe(struct spk_synth *synth)
>  	} else {
>  		for (i = 0; synth_portlist[i]; i++) {
>  			if (synth_request_region(synth_portlist[i],
> -						SYNTH_IO_EXTENT)) {
> +						 SYNTH_IO_EXTENT)) {
>  				pr_warn
>  				    ("request_region: failed with 0x%x, %d\n",
>  				     synth_portlist[i], SYNTH_IO_EXTENT);
> diff --git a/drivers/staging/speakup/spk_ttyio.c b/drivers/staging/speakup/spk_ttyio.c
> index 5aa3ffa..3119402 100644
> --- a/drivers/staging/speakup/spk_ttyio.c
> +++ b/drivers/staging/speakup/spk_ttyio.c
> @@ -71,7 +71,7 @@ static void spk_ttyio_ldisc_close(struct tty_struct *tty)
>  }
>  
>  static int spk_ttyio_receive_buf2(struct tty_struct *tty,
> -		const unsigned char *cp, char *fp, int count)
> +				  const unsigned char *cp, char *fp, int count)
>  {
>  	struct spk_ldisc_data *ldisc_data = tty->disc_data;
>  
> -- 
> 2.7.4
> 

-- 
Samuel
<O> Ça peut être une madeleine à sous munitions (avec des composants,
par exemple)
 -+- #runtime -+-


  reply	other threads:[~2018-03-05 18:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-05 17:34 [PATCH] staging: speakup: match alignment with open parenthesis Santha Meena Ramamoorthy
2018-03-05 18:37 ` Samuel Thibault [this message]
  -- strict thread matches above, loose matches on Subject: below --
2017-03-20  1:11 [PATCH] staging: speakup: Match " Arushi Singhal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180305183725.5a3sx6sxgr3bm2wy@var.youpi.perso.aquilenet.fr \
    --to=samuel.thibault@ens-lyon.org \
    --cc=chris@the-brannons.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kirk@reisers.ca \
    --cc=outreachy-kernel@googlegroups.com \
    --cc=santhameena13@gmail.com \
    --cc=w.d.hubbs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.