From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-path: Date: Mon, 5 Mar 2018 21:30:58 +0200 From: Aaro Koskinen To: Guenter Roeck Cc: Marcus Folkesson , Wim Van Sebroeck , Joel Stanley , Nicolas Ferre , Alexandre Belloni , Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Eric Anholt , Stefan Wahren , Support Opensource , Baruch Siach , William Breathitt Gray , Jimmy Vance , Keguang Zhang , Tomas Winkler , Johannes Thumshirn , Carlo Caione , Kevin Hilman , Matthias Brugger , Michal Simek , Vladimir Zapolskiy , Sylvain Lemieux , Kukjin Kim , Krzysztof Kozlowski , Zwane Mwaikambo , Jim Cromie , Barry Song , Patrice Chotard , Maxime Ripard , Chen-Yu Tsai , Marc Gonzalez , Mans Rullgard , Thierry Reding , Jonathan Hunter , Masahiro Yamada , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Jun Nie , Baoyou Xie , Shawn Guo , linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, Philippe Ombredanne Subject: Re: [PATCH v5] watchdog: add SPDX identifiers for watchdog subsystem Message-ID: <20180305193057.3pxsfc6i5fjdi5dm@darkstar.musicnaut.iki.fi> References: <20180301085450.13829-1-marcus.folkesson@gmail.com> <20180304235319.55gulkoxk4vcaoug@darkstar.musicnaut.iki.fi> <9db48467-7727-87b7-5c55-9c53c46a901f@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9db48467-7727-87b7-5c55-9c53c46a901f@roeck-us.net> List-ID: Hi, On Sun, Mar 04, 2018 at 05:11:00PM -0800, Guenter Roeck wrote: > On 03/04/2018 03:53 PM, Aaro Koskinen wrote: > > On Thu, Mar 01, 2018 at 09:54:50AM +0100, Marcus Folkesson wrote: > > > diff --git a/drivers/watchdog/retu_wdt.c b/drivers/watchdog/retu_wdt.c > > > index 39cd51df2ffc..258dfcf9cbda 100644 > > > --- a/drivers/watchdog/retu_wdt.c > > > +++ b/drivers/watchdog/retu_wdt.c > > > @@ -1,3 +1,4 @@ > > > +// SPDX-License-Identifier: GPL-2.0+ > > > > Why "+" and not just GPL-2.0? > > My non-attorney feedback, which doesn't really mean anything, is that > MODULE_LICENSE says GPL. There appears to be no indication in the file > suggesting that the license would be limited or restricted to GPL v2. Well, it does ask to check kernel's COPYING file for details. A.