From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 1/5] drm/prime: fix potential race in drm_gem_map_detach Date: Tue, 6 Mar 2018 10:15:41 +0100 Message-ID: <20180306091541.GK22212@phenom.ffwll.local> References: <20180227115000.4105-1-christian.koenig@amd.com> <1519811307.6253.5.camel@pengutronix.de> <3a4f9020-235d-ef05-a246-1ba920070f09@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <3a4f9020-235d-ef05-a246-1ba920070f09-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: christian.koenig-5C7GfCeVMHo@public.gmane.org Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Lucas Stach List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBGZWIgMjgsIDIwMTggYXQgMTE6MjU6NTlBTSArMDEwMCwgQ2hyaXN0aWFuIEvDtm5p ZyB3cm90ZToKPiBBbSAyOC4wMi4yMDE4IHVtIDEwOjQ4IHNjaHJpZWIgTHVjYXMgU3RhY2g6Cj4g PiBIaSBDaHJpc3RpYW4sCj4gPiAKPiA+IEFtIERpZW5zdGFnLCBkZW4gMjcuMDIuMjAxOCwgMTI6 NDkgKzAxMDAgc2NocmllYiBDaHJpc3RpYW4gS8O2bmlnOgo+ID4gPiBVbnBpbiB0aGUgR0VNIG9i amVjdCBvbmx5IGFmdGVyIGZyZWVpbmcgdGhlIHNnIHRhYmxlLgo+ID4gV2hhdCBpcyB0aGUgcmFj ZSB0aGF0IGlzIGJlaW5nIGZpeGVkIGhlcmU/IFRoZSBTRyB0YWJsZSBpcyBwcml2YXRlIHRvCj4g PiB0aGUgaW1wb3J0ZXIgYW5kIHRoZSBpbXBvcnRlciBzaG91bGQgaG9wZWZ1bGx5IG9ubHkgY2Fs bCBtYXBfZGV0YWNoIGlmCj4gPiBpdCBpcyBkb25lIHdpdGggYWxsIG9wZXJhdGlvbnMgdXNpbmcg dGhlIFNHIHRhYmxlLiBUaHVzIGl0IHNob3VsZG4ndAo+ID4gbWF0dGVyIHRoYXQgdGhlIFNHIHRh YmxlIG1pZ2h0IHBvaW50IHRvIG1vdmVkIHBhZ2VzIGR1cmluZyBleGVjdXRpb24gb2YKPiA+IHRo aXMgZnVuY3Rpb24uCj4gCj4gRXhhY3RseSwgaXQgc2hvdWxkbid0IG1hdHRlci4gVGhpcyBpcyBq dXN0IGEgcHJlY2F1dGlvbi4KPiAKPiBXaGVuIHRoZSBkZXZpY2UgZHJpdmVyIGlzIGJ1Z2d5IEkg d2FudCBwcm9wZXIgZXJyb3IgbWVzc2FnZXMgZnJvbSBJT01NVSBhbmQKPiBub3QgYWNjZXNzaW5n IHBhZ2VzIHdoaWNoIG1pZ2h0IGFscmVhZHkgYmUgcmV1c2VkIGZvciBzb21ldGhpbmcgZWxzZS4K ClBsZWFzZSBhZGQgdGhpcyB0byB0aGUgY29tbWl0IG1lc3NhZ2UsIHJhdGhlciBjcnVjaWFsIHRv IHVuZGVyc3RhbmQgdGhlCm1vdGl2YXRpb24uIFdpdGggdGhhdCBmaXhlZCB5b3UgY2FuIGhhdmUg bXkKClJldmlld2VkLWJ5OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgoK QW5kIHBscyBwdXNoIHRvIGRybS1taXNjLgotRGFuaWVsCgo+IAo+IFJlZ2FyZHMsCj4gQ2hyaXN0 aWFuLgo+IAo+ID4gCj4gPiBSZWdhcmRzLAo+ID4gTHVjYXMKPiA+IAo+ID4gPiBTaWduZWQtb2Zm LWJ5OiBDaHJpc3RpYW4gS8O2bmlnIDxjaHJpc3RpYW4ua29lbmlnQGFtZC5jb20+Cj4gPiA+IC0t LQo+ID4gPiAgIGRyaXZlcnMvZ3B1L2RybS9kcm1fcHJpbWUuYyB8IDMyICsrKysrKysrKysrKysr KystLS0tLS0tLS0tLS0tLS0tCj4gPiA+ICAgMSBmaWxlIGNoYW5nZWQsIDE2IGluc2VydGlvbnMo KyksIDE2IGRlbGV0aW9ucygtKQo+ID4gPiAKPiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1 L2RybS9kcm1fcHJpbWUuYwo+ID4gPiBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fcHJpbWUuYwo+ID4g PiBpbmRleCBlODJhOTc2ZjBmYmEuLmMzOGRhY2RhNjExOSAxMDA2NDQKPiA+ID4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2RybV9wcmltZS5jCj4gPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1f cHJpbWUuYwo+ID4gPiBAQCAtMjMwLDI2ICsyMzAsMjYgQEAgdm9pZCBkcm1fZ2VtX21hcF9kZXRh Y2goc3RydWN0IGRtYV9idWYKPiA+ID4gKmRtYV9idWYsCj4gPiA+ICAgCXN0cnVjdCBkcm1fcHJp bWVfYXR0YWNobWVudCAqcHJpbWVfYXR0YWNoID0gYXR0YWNoLT5wcml2Owo+ID4gPiAgIAlzdHJ1 Y3QgZHJtX2dlbV9vYmplY3QgKm9iaiA9IGRtYV9idWYtPnByaXY7Cj4gPiA+ICAgCXN0cnVjdCBk cm1fZGV2aWNlICpkZXYgPSBvYmotPmRldjsKPiA+ID4gLQlzdHJ1Y3Qgc2dfdGFibGUgKnNndDsK PiA+ID4gLQlpZiAoZGV2LT5kcml2ZXItPmdlbV9wcmltZV91bnBpbikKPiA+ID4gLQkJZGV2LT5k cml2ZXItPmdlbV9wcmltZV91bnBpbihvYmopOwo+ID4gPiArCWlmIChwcmltZV9hdHRhY2gpIHsK PiA+ID4gKwkJc3RydWN0IHNnX3RhYmxlICpzZ3QgPSBwcmltZV9hdHRhY2gtPnNndDsKPiA+ID4g LQlpZiAoIXByaW1lX2F0dGFjaCkKPiA+ID4gLQkJcmV0dXJuOwo+ID4gPiAtCj4gPiA+IC0Jc2d0 ID0gcHJpbWVfYXR0YWNoLT5zZ3Q7Cj4gPiA+IC0JaWYgKHNndCkgewo+ID4gPiAtCQlpZiAocHJp bWVfYXR0YWNoLT5kaXIgIT0gRE1BX05PTkUpCj4gPiA+IC0JCQlkbWFfdW5tYXBfc2dfYXR0cnMo YXR0YWNoLT5kZXYsIHNndC0+c2dsLAo+ID4gPiBzZ3QtPm5lbnRzLAo+ID4gPiAtCQkJCQkgICBw cmltZV9hdHRhY2gtPmRpciwKPiA+ID4gLQkJCQkJICAgRE1BX0FUVFJfU0tJUF9DUFVfU1lOQyk7 Cj4gPiA+IC0JCXNnX2ZyZWVfdGFibGUoc2d0KTsKPiA+ID4gKwkJaWYgKHNndCkgewo+ID4gPiAr CQkJaWYgKHByaW1lX2F0dGFjaC0+ZGlyICE9IERNQV9OT05FKQo+ID4gPiArCQkJCWRtYV91bm1h cF9zZ19hdHRycyhhdHRhY2gtPmRldiwgc2d0LQo+ID4gPiA+IHNnbCwKPiA+ID4gKwkJCQkJCSAg IHNndC0+bmVudHMsCj4gPiA+ICsJCQkJCQkgICBwcmltZV9hdHRhY2gtCj4gPiA+ID4gZGlyLAo+ ID4gPiArCQkJCQkJICAgRE1BX0FUVFJfU0tJUF9DUFUKPiA+ID4gX1NZTkMpOwo+ID4gPiArCQkJ c2dfZnJlZV90YWJsZShzZ3QpOwo+ID4gPiArCQl9Cj4gPiA+ICsKPiA+ID4gKwkJa2ZyZWUoc2d0 KTsKPiA+ID4gKwkJa2ZyZWUocHJpbWVfYXR0YWNoKTsKPiA+ID4gKwkJYXR0YWNoLT5wcml2ID0g TlVMTDsKPiA+ID4gICAJfQo+ID4gPiAtCWtmcmVlKHNndCk7Cj4gPiA+IC0Ja2ZyZWUocHJpbWVf YXR0YWNoKTsKPiA+ID4gLQlhdHRhY2gtPnByaXYgPSBOVUxMOwo+ID4gPiArCWlmIChkZXYtPmRy aXZlci0+Z2VtX3ByaW1lX3VucGluKQo+ID4gPiArCQlkZXYtPmRyaXZlci0+Z2VtX3ByaW1lX3Vu cGluKG9iaik7Cj4gPiA+ICAgfQo+ID4gPiAgIEVYUE9SVF9TWU1CT0woZHJtX2dlbV9tYXBfZGV0 YWNoKTsKPiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f Xwo+IGRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKPiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmkt ZGV2ZWwKCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3Jh dGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwphbWQtZ2Z4IG1haWxpbmcgbGlzdAphbWQtZ2Z4QGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2FtZC1nZngK