From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 2/5] drm/prime: make the pages array optional for drm_prime_sg_to_page_addr_arrays Date: Tue, 6 Mar 2018 10:37:55 +0100 Message-ID: <20180306093755.GQ22212@phenom.ffwll.local> References: <20180227115000.4105-1-christian.koenig@amd.com> <20180227115000.4105-2-christian.koenig@amd.com> <20180306092102.GM22212@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x244.google.com (mail-wm0-x244.google.com [IPv6:2a00:1450:400c:c09::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id E72AA6E5E1 for ; Tue, 6 Mar 2018 09:37:59 +0000 (UTC) Received: by mail-wm0-x244.google.com with SMTP id 188so20816204wme.1 for ; Tue, 06 Mar 2018 01:37:59 -0800 (PST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: christian.koenig@amd.com Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBNYXIgMDYsIDIwMTggYXQgMTA6MjU6MDNBTSArMDEwMCwgQ2hyaXN0aWFuIEvDtm5p ZyB3cm90ZToKPiBBbSAwNi4wMy4yMDE4IHVtIDEwOjIxIHNjaHJpZWIgRGFuaWVsIFZldHRlcjoK PiA+IE9uIFR1ZSwgRmViIDI3LCAyMDE4IGF0IDEyOjQ5OjU3UE0gKzAxMDAsIENocmlzdGlhbiBL w7ZuaWcgd3JvdGU6Cj4gPiA+IE1vc3Qgb2YgdGhlIHRpbWUgd2Ugb25seSBuZWVkIHRoZSBkbWEg YWRkcmVzc2VzLgo+ID4gPiAKPiA+ID4gU2lnbmVkLW9mZi1ieTogQ2hyaXN0aWFuIEvDtm5pZyA8 Y2hyaXN0aWFuLmtvZW5pZ0BhbWQuY29tPgo+ID4gPiAtLS0KPiA+ID4gICBkcml2ZXJzL2dwdS9k cm0vZHJtX3ByaW1lLmMgfCAyMCArKysrKysrKysrLS0tLS0tLS0tLQo+ID4gPiAgIDEgZmlsZSBj aGFuZ2VkLCAxMCBpbnNlcnRpb25zKCspLCAxMCBkZWxldGlvbnMoLSkKPiA+ID4gCj4gPiA+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX3ByaW1lLmMgYi9kcml2ZXJzL2dwdS9kcm0v ZHJtX3ByaW1lLmMKPiA+ID4gaW5kZXggYzM4ZGFjZGE2MTE5Li43ODU2YTliM2Y4YTggMTAwNjQ0 Cj4gPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fcHJpbWUuYwo+ID4gPiArKysgYi9kcml2 ZXJzL2dwdS9kcm0vZHJtX3ByaW1lLmMKPiA+ID4gQEAgLTkyMiw0MCArOTIyLDQwIEBAIEVYUE9S VF9TWU1CT0woZHJtX3ByaW1lX3BhZ2VzX3RvX3NnKTsKPiA+ID4gICAvKioKPiA+ID4gICAgKiBk cm1fcHJpbWVfc2dfdG9fcGFnZV9hZGRyX2FycmF5cyAtIGNvbnZlcnQgYW4gc2cgdGFibGUgaW50 byBhIHBhZ2UgYXJyYXkKPiA+ID4gICAgKiBAc2d0OiBzY2F0dGVyLWdhdGhlciB0YWJsZSB0byBj b252ZXJ0Cj4gPiA+IC0gKiBAcGFnZXM6IGFycmF5IG9mIHBhZ2UgcG9pbnRlcnMgdG8gc3RvcmUg dGhlIHBhZ2UgYXJyYXkgaW4KPiA+ID4gKyAqIEBwYWdlczogb3B0aW9uYWwgYXJyYXkgb2YgcGFn ZSBwb2ludGVycyB0byBzdG9yZSB0aGUgcGFnZSBhcnJheSBpbgo+ID4gPiAgICAqIEBhZGRyczog b3B0aW9uYWwgYXJyYXkgdG8gc3RvcmUgdGhlIGRtYSBidXMgYWRkcmVzcyBvZiBlYWNoIHBhZ2UK PiA+ID4gLSAqIEBtYXhfcGFnZXM6IHNpemUgb2YgYm90aCB0aGUgcGFzc2VkLWluIGFycmF5cwo+ ID4gPiArICogQG1heF9lbnRyaWVzOiBzaXplIG9mIGJvdGggdGhlIHBhc3NlZC1pbiBhcnJheXMK PiA+ID4gICAgKgo+ID4gPiAgICAqIEV4cG9ydHMgYW4gc2cgdGFibGUgaW50byBhbiBhcnJheSBv ZiBwYWdlcyBhbmQgYWRkcmVzc2VzLiBUaGlzIGlzIGN1cnJlbnRseQo+ID4gPiAgICAqIHJlcXVp cmVkIGJ5IHRoZSBUVE0gZHJpdmVyIGluIG9yZGVyIHRvIGRvIGNvcnJlY3QgZmF1bHQgaGFuZGxp bmcuCj4gPiA+ICAgICovCj4gPiBDYW4ndCB3ZSBqdXN0IHRlYWNoIHR0bSB0byB1c2Ugc2d0cyB3 aGVyZXZlciBuZWVkZWQsIGFuZCBkZXByZWNhdGUKPiA+IGV4cG9ydGluZyBkbWEtYnVmcyB0byBw YWdlIGFycmF5cyAod2hpY2ggcmVhbGx5IGJyZWFrcyB0aGUgYWJzdHJhY3Rpb24KPiA+IGVudGly ZWx5IGFuZCB3YXMganVzdCBhIHF1aWNrIGhhY2sgdG8gZ2V0IHRoaW5ncyBnb2luZyB0aGF0IHN0 dWNrIGFyb3VuZAo+ID4gZm9yIHllYXJzKS4gTGFzdCB0aW1lIEkgbG9va2VkIGludG8gdHRtIHRo ZSBvbmx5IHRoaW5nIGl0IGRpZCBpcyBjb252ZXJ0Cj4gPiBpdCBiYWNrIHRvIHNndHMgYWdhaW4g KGFmdGVyIGNhbGxpbmcgZG1hX21hcCBvbmNlIG1vcmUsIHdoaWNoIHRoZSBleHBvcnRlcgo+ID4g c2hvdWxkIGhhdmUgZG9uZSBhbHJlYWR5IGZvciB5b3UpLgo+IAo+IFRob3VnaHQgYWJvdXQgdGhh dCBhcyB3ZWxsLCBidXQgdGhlIHByb2JsZW0gaGVyZSBpc24ndCBUVE0uCj4gCj4gV2UgbmVlZCB0 byBiZSBhYmxlIHRvIGFjY2VzcyB0aGUgU0dUIGJ5IGFuIGluZGV4IGluIGFtZGdwdSB0byBiZSBh YmxlIHRvCj4gYnVpbGQgdXAgdGhlIFZNIHBhZ2UgdGFibGVzIGFuZCB0aGF0IGlzIG5vdCBwb3Nz aWJsZSBiZWNhdXNlIHRoZSBTR1QgaXMKPiBwb3RlbnRpYWxseSBjaGFpbmVkLgo+IAo+IFdlIGNv dWxkIGFkZCBhIG5ldyBzZ190YWJsZSBhY2Nlc3MgaGVscGVyIGZ1bmN0aW9uIHRvIHdvcmsgYXJv dW5kIHRoYXQKPiB0aG91Z2h0LgoKVGhlcmUncyBzb21lIG5lYXQgcGVyLXBhZ2Ugc2d0IGl0ZXIg ZnVuY3Rpb25zIHRoYXQgd2UndmUgYnVpbGQgZm9yIGk5MTUuClNlZSBpOTE1X2dlbV9ndHQuYy4g QnV0IHllYWggdGhhdCdzIHByb2JhYmx5IGEgcGlsZSBtb3JlIHdvcmssIGJ1dCBpbW8KZnJvbSB0 aGUgaTkxNSBjb2RlIHNodWZmbGluZyB0aGUgZW5kIHJlc3VsdCBsb29rcyBmYWlybHkgbmVhdC4K LURhbmllbAo+IAo+IEJUVzogVFRNIGlzbid0IG1hcHBpbmcgYW55dGhpbmcgaW4gdGhhdCBjYXNl LCB3ZSBqdXN0IGZpbGwgaW4gdGhlIGFycmF5cwo+IGZyb20gdGhlIFNHVC4KPiAKPiBDaHJpc3Rp YW4uCj4gCj4gPiAtRGFuaWVsCj4gPiAKPiA+ID4gICBpbnQgZHJtX3ByaW1lX3NnX3RvX3BhZ2Vf YWRkcl9hcnJheXMoc3RydWN0IHNnX3RhYmxlICpzZ3QsIHN0cnVjdCBwYWdlICoqcGFnZXMsCj4g PiA+IC0JCQkJICAgICBkbWFfYWRkcl90ICphZGRycywgaW50IG1heF9wYWdlcykKPiA+ID4gKwkJ CQkgICAgIGRtYV9hZGRyX3QgKmFkZHJzLCBpbnQgbWF4X2VudHJpZXMpCj4gPiA+ICAgewo+ID4g PiAgIAl1bnNpZ25lZCBjb3VudDsKPiA+ID4gICAJc3RydWN0IHNjYXR0ZXJsaXN0ICpzZzsKPiA+ ID4gICAJc3RydWN0IHBhZ2UgKnBhZ2U7Cj4gPiA+IC0JdTMyIGxlbjsKPiA+ID4gLQlpbnQgcGdf aW5kZXg7Cj4gPiA+ICsJdTMyIGxlbiwgaW5kZXg7Cj4gPiA+ICAgCWRtYV9hZGRyX3QgYWRkcjsK PiA+ID4gLQlwZ19pbmRleCA9IDA7Cj4gPiA+ICsJaW5kZXggPSAwOwo+ID4gPiAgIAlmb3JfZWFj aF9zZyhzZ3QtPnNnbCwgc2csIHNndC0+bmVudHMsIGNvdW50KSB7Cj4gPiA+ICAgCQlsZW4gPSBz Zy0+bGVuZ3RoOwo+ID4gPiAgIAkJcGFnZSA9IHNnX3BhZ2Uoc2cpOwo+ID4gPiAgIAkJYWRkciA9 IHNnX2RtYV9hZGRyZXNzKHNnKTsKPiA+ID4gICAJCXdoaWxlIChsZW4gPiAwKSB7Cj4gPiA+IC0J CQlpZiAoV0FSTl9PTihwZ19pbmRleCA+PSBtYXhfcGFnZXMpKQo+ID4gPiArCQkJaWYgKFdBUk5f T04oaW5kZXggPj0gbWF4X2VudHJpZXMpKQo+ID4gPiAgIAkJCQlyZXR1cm4gLTE7Cj4gPiA+IC0J CQlwYWdlc1twZ19pbmRleF0gPSBwYWdlOwo+ID4gPiArCQkJaWYgKHBhZ2VzKQo+ID4gPiArCQkJ CXBhZ2VzW2luZGV4XSA9IHBhZ2U7Cj4gPiA+ICAgCQkJaWYgKGFkZHJzKQo+ID4gPiAtCQkJCWFk ZHJzW3BnX2luZGV4XSA9IGFkZHI7Cj4gPiA+ICsJCQkJYWRkcnNbaW5kZXhdID0gYWRkcjsKPiA+ ID4gICAJCQlwYWdlKys7Cj4gPiA+ICAgCQkJYWRkciArPSBQQUdFX1NJWkU7Cj4gPiA+ICAgCQkJ bGVuIC09IFBBR0VfU0laRTsKPiA+ID4gLQkJCXBnX2luZGV4Kys7Cj4gPiA+ICsJCQlpbmRleCsr Owo+ID4gPiAgIAkJfQo+ID4gPiAgIAl9Cj4gPiA+ICAgCXJldHVybiAwOwo+ID4gPiAtLSAKPiA+ ID4gMi4xNC4xCj4gPiA+IAo+ID4gPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwo+ID4gPiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0Cj4gPiA+IGRyaS1kZXZl bEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiA+ID4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwKPiAKCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3 YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFp bGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK