From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933042AbeCFOG1 (ORCPT ); Tue, 6 Mar 2018 09:06:27 -0500 Received: from mail.kernel.org ([198.145.29.99]:34688 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750932AbeCFOG0 (ORCPT ); Tue, 6 Mar 2018 09:06:26 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EA93220685 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org Date: Tue, 6 Mar 2018 11:06:24 -0300 From: Arnaldo Carvalho de Melo To: Adrian Hunter Cc: Jiri Olsa , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/7] perf auxtrace: Prevent decoding when --no-itrace Message-ID: <20180306140624.GE10176@kernel.org> References: <1520327598-1317-1-git-send-email-adrian.hunter@intel.com> <1520327598-1317-3-git-send-email-adrian.hunter@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1520327598-1317-3-git-send-email-adrian.hunter@intel.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Tue, Mar 06, 2018 at 11:13:13AM +0200, Adrian Hunter escreveu: > Prevent auxtrace_queues__process_index() from queuing AUX area data for > decoding when the --no-itrace option has been used. So I'm putting this one both on perf/urgent and on perf/core, the rest just on perf/core, ok? - Arnaldo > Signed-off-by: Adrian Hunter > --- > tools/perf/util/auxtrace.c | 15 +++++++++------ > 1 file changed, 9 insertions(+), 6 deletions(-) > > diff --git a/tools/perf/util/auxtrace.c b/tools/perf/util/auxtrace.c > index 9faf3b5367db..6470ea2aa25e 100644 > --- a/tools/perf/util/auxtrace.c > +++ b/tools/perf/util/auxtrace.c > @@ -60,6 +60,12 @@ > #include "sane_ctype.h" > #include "symbol/kallsyms.h" > > +static bool auxtrace__dont_decode(struct perf_session *session) > +{ > + return !session->itrace_synth_opts || > + session->itrace_synth_opts->dont_decode; > +} > + > int auxtrace_mmap__mmap(struct auxtrace_mmap *mm, > struct auxtrace_mmap_params *mp, > void *userpg, int fd) > @@ -762,6 +768,9 @@ int auxtrace_queues__process_index(struct auxtrace_queues *queues, > size_t i; > int err; > > + if (auxtrace__dont_decode(session)) > + return 0; > + > list_for_each_entry(auxtrace_index, &session->auxtrace_index, list) { > for (i = 0; i < auxtrace_index->nr; i++) { > ent = &auxtrace_index->entries[i]; > @@ -892,12 +901,6 @@ int perf_event__synthesize_auxtrace_info(struct auxtrace_record *itr, > return err; > } > > -static bool auxtrace__dont_decode(struct perf_session *session) > -{ > - return !session->itrace_synth_opts || > - session->itrace_synth_opts->dont_decode; > -} > - > int perf_event__process_auxtrace_info(struct perf_tool *tool __maybe_unused, > union perf_event *event, > struct perf_session *session) > -- > 1.9.1