From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shards.monkeyblade.net ([184.105.139.130]:56874 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934521AbeCGUjs (ORCPT ); Wed, 7 Mar 2018 15:39:48 -0500 Date: Wed, 07 Mar 2018 15:39:46 -0500 (EST) Message-Id: <20180307.153946.1114486193485019127.davem@davemloft.net> To: johan@kernel.org Cc: oliver@neukum.org, linux-usb@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH net-next 1/2] net: kalmia: clean up bind error path From: David Miller In-Reply-To: <20180307094658.9008-1-johan@kernel.org> References: <20180307094658.9008-1-johan@kernel.org> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: From: Johan Hovold Date: Wed, 7 Mar 2018 10:46:57 +0100 > Drop bogus call to usb_driver_release_interface() from an error path in > the usbnet bind() callback, which is called during interface probe. At > this point the interface is not bound and usb_driver_release_interface() > returns early. > > Also remove the bogus call to clear the interface data, which is owned > by the usbnet driver and would not even have been set by the time bind() > is called. > > Signed-off-by: Johan Hovold Applied. From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [net-next,1/2] net: kalmia: clean up bind error path From: David Miller Message-Id: <20180307.153946.1114486193485019127.davem@davemloft.net> Date: Wed, 07 Mar 2018 15:39:46 -0500 (EST) To: johan@kernel.org Cc: oliver@neukum.org, linux-usb@vger.kernel.org, netdev@vger.kernel.org List-ID: RnJvbTogSm9oYW4gSG92b2xkIDxqb2hhbkBrZXJuZWwub3JnPgpEYXRlOiBXZWQsICA3IE1hciAy MDE4IDEwOjQ2OjU3ICswMTAwCgo+IERyb3AgYm9ndXMgY2FsbCB0byB1c2JfZHJpdmVyX3JlbGVh c2VfaW50ZXJmYWNlKCkgZnJvbSBhbiBlcnJvciBwYXRoIGluCj4gdGhlIHVzYm5ldCBiaW5kKCkg Y2FsbGJhY2ssIHdoaWNoIGlzIGNhbGxlZCBkdXJpbmcgaW50ZXJmYWNlIHByb2JlLiBBdAo+IHRo aXMgcG9pbnQgdGhlIGludGVyZmFjZSBpcyBub3QgYm91bmQgYW5kIHVzYl9kcml2ZXJfcmVsZWFz ZV9pbnRlcmZhY2UoKQo+IHJldHVybnMgZWFybHkuCj4gCj4gQWxzbyByZW1vdmUgdGhlIGJvZ3Vz IGNhbGwgdG8gY2xlYXIgdGhlIGludGVyZmFjZSBkYXRhLCB3aGljaCBpcyBvd25lZAo+IGJ5IHRo ZSB1c2JuZXQgZHJpdmVyIGFuZCB3b3VsZCBub3QgZXZlbiBoYXZlIGJlZW4gc2V0IGJ5IHRoZSB0 aW1lIGJpbmQoKQo+IGlzIGNhbGxlZC4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBKb2hhbiBIb3ZvbGQg PGpvaGFuQGtlcm5lbC5vcmc+CgpBcHBsaWVkLgotLS0KVG8gdW5zdWJzY3JpYmUgZnJvbSB0aGlz IGxpc3Q6IHNlbmQgdGhlIGxpbmUgInVuc3Vic2NyaWJlIGxpbnV4LXVzYiIgaW4KdGhlIGJvZHkg b2YgYSBtZXNzYWdlIHRvIG1ham9yZG9tb0B2Z2VyLmtlcm5lbC5vcmcKTW9yZSBtYWpvcmRvbW8g aW5mbyBhdCAgaHR0cDovL3ZnZXIua2VybmVsLm9yZy9tYWpvcmRvbW8taW5mby5odG1sCg==