From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f47.google.com ([74.125.83.47]:46184 "EHLO mail-pg0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750957AbeCGF2x (ORCPT ); Wed, 7 Mar 2018 00:28:53 -0500 Received: by mail-pg0-f47.google.com with SMTP id r26so496413pgv.13 for ; Tue, 06 Mar 2018 21:28:53 -0800 (PST) Date: Tue, 6 Mar 2018 21:28:49 -0800 From: Richard Cochran To: Jesus Sanchez-Palencia Cc: netdev@vger.kernel.org, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, vinicius.gomes@intel.com, intel-wired-lan@lists.osuosl.org, anna-maria@linutronix.de, henrik@austad.us, tglx@linutronix.de, john.stultz@linaro.org, levi.pearson@harman.com, edumazet@google.com, willemb@google.com, mlichvar@redhat.com Subject: Re: [RFC v3 net-next 00/18] Time based packet transmission Message-ID: <20180307052849.droj77rqa7epqvfe@localhost> References: <20180307011230.24001-1-jesus.sanchez-palencia@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180307011230.24001-1-jesus.sanchez-palencia@intel.com> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, Mar 06, 2018 at 05:12:12PM -0800, Jesus Sanchez-Palencia wrote: > Design changes since v2: > - Now on the dequeue() path, tbs only drops an expired packet if it has the > skb->tc_drop_if_late flag set. In practical terms, this will define if > the semantics of txtime on a system is "not earlier than" or "not later > than" a given timestamp; > - Now on the enqueue() path, the qdisc will drop a packet if its clockid > doesn't match the qdisc's one; > - Sorting the packets based on their txtime is now an option for the disc. > Effectively, this means it can be configured in 4 modes: HW offload or > SW best-effort, sorting enabled or disabled; While all of this makes the series and the configuration more complex, still I like the fact that the interface offers these different modes. Looking forward to testing this... Thanks, Richard From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Cochran Date: Tue, 6 Mar 2018 21:28:49 -0800 Subject: [Intel-wired-lan] [RFC v3 net-next 00/18] Time based packet transmission In-Reply-To: <20180307011230.24001-1-jesus.sanchez-palencia@intel.com> References: <20180307011230.24001-1-jesus.sanchez-palencia@intel.com> Message-ID: <20180307052849.droj77rqa7epqvfe@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: On Tue, Mar 06, 2018 at 05:12:12PM -0800, Jesus Sanchez-Palencia wrote: > Design changes since v2: > - Now on the dequeue() path, tbs only drops an expired packet if it has the > skb->tc_drop_if_late flag set. In practical terms, this will define if > the semantics of txtime on a system is "not earlier than" or "not later > than" a given timestamp; > - Now on the enqueue() path, the qdisc will drop a packet if its clockid > doesn't match the qdisc's one; > - Sorting the packets based on their txtime is now an option for the disc. > Effectively, this means it can be configured in 4 modes: HW offload or > SW best-effort, sorting enabled or disabled; While all of this makes the series and the configuration more complex, still I like the fact that the interface offers these different modes. Looking forward to testing this... Thanks, Richard