From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50099) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1etYBN-0008UG-7v for qemu-devel@nongnu.org; Wed, 07 Mar 2018 07:28:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1etYBK-0000Ey-4N for qemu-devel@nongnu.org; Wed, 07 Mar 2018 07:28:33 -0500 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:47728 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1etYBJ-0000Es-Vn for qemu-devel@nongnu.org; Wed, 07 Mar 2018 07:28:30 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 93255818B115 for ; Wed, 7 Mar 2018 12:28:29 +0000 (UTC) Date: Wed, 7 Mar 2018 12:28:26 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Message-ID: <20180307122826.GY20201@redhat.com> Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <20180306053320.15401-1-peterx@redhat.com> <20180306053320.15401-5-peterx@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180306053320.15401-5-peterx@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 4/9] chardev: allow telnet gsource to switch gcontext List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Xu Cc: qemu-devel@nongnu.org, Paolo Bonzini , Stefan Hajnoczi , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau On Tue, Mar 06, 2018 at 01:33:15PM +0800, Peter Xu wrote: > It was originally created by qio_channel_add_watch() so it's always > assigning the task to main context. Now we use the new API called > qio_channel_add_watch_source() so that we get the GSource handle rather > than the tag ID. >=20 > Meanwhile, caching the gsource and TCPChardevTelnetInit (which holds th= e > handshake data) in SocketChardev.telnet_source so that we can also do > dynamic context switch when update read handlers. >=20 > Signed-off-by: Peter Xu > --- > chardev/char-socket.c | 67 +++++++++++++++++++++++++++++++++++++++----= -------- > 1 file changed, 51 insertions(+), 16 deletions(-) Reviewed-by: Daniel P. Berrang=C3=A9 Regards, Daniel --=20 |: https://berrange.com -o- https://www.flickr.com/photos/dberran= ge :| |: https://libvirt.org -o- https://fstop138.berrange.c= om :| |: https://entangle-photo.org -o- https://www.instagram.com/dberran= ge :|