From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:58378 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754557AbeCGO4s (ORCPT ); Wed, 7 Mar 2018 09:56:48 -0500 Date: Wed, 7 Mar 2018 06:56:50 -0800 From: Greg KH To: Johan Hovold Cc: "David S. Miller" , Oliver Neukum , linux-usb@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH net-next 2/2] net: cdc_eem: clean up bind error path Message-ID: <20180307145650.GB4109@kroah.com> References: <20180307094658.9008-1-johan@kernel.org> <20180307094658.9008-2-johan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180307094658.9008-2-johan@kernel.org> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, Mar 07, 2018 at 10:46:58AM +0100, Johan Hovold wrote: > Drop bogus call to usb_driver_release_interface() from an error path in > the usbnet bind() callback, which is called during interface probe. At > this point the interface is not bound and usb_driver_release_interface() > returns early. > > Also remove the bogus call to clear the interface data, which is owned > by the usbnet driver and would not even have been set by the time bind() > is called. > > Signed-off-by: Johan Hovold Reviewed-by: Greg Kroah-Hartman From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [net-next,2/2] net: cdc_eem: clean up bind error path From: Greg KH Message-Id: <20180307145650.GB4109@kroah.com> Date: Wed, 7 Mar 2018 06:56:50 -0800 To: Johan Hovold Cc: "David S. Miller" , Oliver Neukum , linux-usb@vger.kernel.org, netdev@vger.kernel.org List-ID: T24gV2VkLCBNYXIgMDcsIDIwMTggYXQgMTA6NDY6NThBTSArMDEwMCwgSm9oYW4gSG92b2xkIHdy b3RlOgo+IERyb3AgYm9ndXMgY2FsbCB0byB1c2JfZHJpdmVyX3JlbGVhc2VfaW50ZXJmYWNlKCkg ZnJvbSBhbiBlcnJvciBwYXRoIGluCj4gdGhlIHVzYm5ldCBiaW5kKCkgY2FsbGJhY2ssIHdoaWNo IGlzIGNhbGxlZCBkdXJpbmcgaW50ZXJmYWNlIHByb2JlLiBBdAo+IHRoaXMgcG9pbnQgdGhlIGlu dGVyZmFjZSBpcyBub3QgYm91bmQgYW5kIHVzYl9kcml2ZXJfcmVsZWFzZV9pbnRlcmZhY2UoKQo+ IHJldHVybnMgZWFybHkuCj4gCj4gQWxzbyByZW1vdmUgdGhlIGJvZ3VzIGNhbGwgdG8gY2xlYXIg dGhlIGludGVyZmFjZSBkYXRhLCB3aGljaCBpcyBvd25lZAo+IGJ5IHRoZSB1c2JuZXQgZHJpdmVy IGFuZCB3b3VsZCBub3QgZXZlbiBoYXZlIGJlZW4gc2V0IGJ5IHRoZSB0aW1lIGJpbmQoKQo+IGlz IGNhbGxlZC4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBKb2hhbiBIb3ZvbGQgPGpvaGFuQGtlcm5lbC5v cmc+CgpSZXZpZXdlZC1ieTogR3JlZyBLcm9haC1IYXJ0bWFuIDxncmVna2hAbGludXhmb3VuZGF0 aW9uLm9yZz4KLS0tClRvIHVuc3Vic2NyaWJlIGZyb20gdGhpcyBsaXN0OiBzZW5kIHRoZSBsaW5l ICJ1bnN1YnNjcmliZSBsaW51eC11c2IiIGluCnRoZSBib2R5IG9mIGEgbWVzc2FnZSB0byBtYWpv cmRvbW9Admdlci5rZXJuZWwub3JnCk1vcmUgbWFqb3Jkb21vIGluZm8gYXQgIGh0dHA6Ly92Z2Vy Lmtlcm5lbC5vcmcvbWFqb3Jkb21vLWluZm8uaHRtbAo=