From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shards.monkeyblade.net ([184.105.139.130]:40580 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935944AbeCHRdM (ORCPT ); Thu, 8 Mar 2018 12:33:12 -0500 Date: Thu, 08 Mar 2018 12:33:10 -0500 (EST) Message-Id: <20180308.123310.406604126920910381.davem@davemloft.net> To: shannon.nelson@oracle.com Cc: netdev@vger.kernel.org, steffen.klassert@secunet.com Subject: Re: [PATCH net] macvlan: filter out xfrm feature flags From: David Miller In-Reply-To: <1520377028-14818-1-git-send-email-shannon.nelson@oracle.com> References: <1520377028-14818-1-git-send-email-shannon.nelson@oracle.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: From: Shannon Nelson Date: Tue, 6 Mar 2018 14:57:08 -0800 > This isn't broken for vlans because they use a separate features > connection (vlan_features) for inheriting features. This is > fine, but I don't think trying to add something like this to > every driver for every new upperdev is a good idea - I think > the upperdev should try to protect itself. I think this fix is correct. But for how many upperdevs are we going to duplicate code like this, and how many subtle differences and in fact bugs will result from all of that duplication? I think we really need something common for these upperdev drivers to use. Maybe just a macro defining feature bits to trim in this situation. Thanks.