From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966215AbeCHNjl (ORCPT ); Thu, 8 Mar 2018 08:39:41 -0500 Received: from mail.kernel.org ([198.145.29.99]:49826 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754987AbeCHNjg (ORCPT ); Thu, 8 Mar 2018 08:39:36 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4B56A205F4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org Date: Thu, 8 Mar 2018 10:39:31 -0300 From: Arnaldo Carvalho de Melo To: Agustin Vega-Frias Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Peter Zijlstra , Ingo Molnar , Andi Kleen , Alexander Shishkin , Jiri Olsa , Namhyung Kim , timur@codeaurora.org Subject: Re: [RFC V4] perf, tools: Support wildcards on pmu name in dynamic pmu events Message-ID: <20180308133931.GA7273@kernel.org> References: <1520454947-16977-1-git-send-email-agustinv@codeaurora.org> <20180308130358.GC3701@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Thu, Mar 08, 2018 at 08:28:13AM -0500, Agustin Vega-Frias escreveu: > On 2018-03-08 08:03, Arnaldo Carvalho de Melo wrote: > > Em Wed, Mar 07, 2018 at 03:35:47PM -0500, Agustin Vega-Frias escreveu: > > > +++ b/tools/perf/util/parse-events.y > > > @@ -8,6 +8,7 @@ > > > > > > #define YYDEBUG 1 > > > > > > +#include > > > #include > > > #include > > > #include > > > @@ -234,6 +235,10 @@ PE_NAME opt_event_config > > > if (parse_events_add_pmu(_parse_state, list, $1, $2)) { > > > struct perf_pmu *pmu = NULL; > > > int ok = 0; > > > + char *pattern; > > > + > > > + if (asprintf(&pattern, "%s*", $1) < 0) > > > + YYABORT; > > + if (asprintf(&pattern, "?(uncore_)%s*", $1) < 0) > > I completely overlook that you were using this and thus needed that > > extension, duh, thanks for the patience 8-) and for the new patch. Further trying to remove my brown paper bag: I thought the '?(...)' type of thing would be something _users_ would pass on the perf tool command line, not something used by the tool itself, like on the original patch.... :-) > NP Arnaldo, thanks for the quick turnaround on these patches :o) > Just so I know, since these are my first patches on perf tools, > where are perf tools patches queued once acked? git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git perf/core If they are super urgent, then they will go to a different branch, perf/urgent, that is targetted for the current merge window, i.e. right now: perf/core -> 4.17 perf/urgent -> 4.16 Thanks, and keep the patches flowing! - Arnaldo From mboxrd@z Thu Jan 1 00:00:00 1970 From: acme@kernel.org (Arnaldo Carvalho de Melo) Date: Thu, 8 Mar 2018 10:39:31 -0300 Subject: [RFC V4] perf, tools: Support wildcards on pmu name in dynamic pmu events In-Reply-To: References: <1520454947-16977-1-git-send-email-agustinv@codeaurora.org> <20180308130358.GC3701@kernel.org> Message-ID: <20180308133931.GA7273@kernel.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Em Thu, Mar 08, 2018 at 08:28:13AM -0500, Agustin Vega-Frias escreveu: > On 2018-03-08 08:03, Arnaldo Carvalho de Melo wrote: > > Em Wed, Mar 07, 2018 at 03:35:47PM -0500, Agustin Vega-Frias escreveu: > > > +++ b/tools/perf/util/parse-events.y > > > @@ -8,6 +8,7 @@ > > > > > > #define YYDEBUG 1 > > > > > > +#include > > > #include > > > #include > > > #include > > > @@ -234,6 +235,10 @@ PE_NAME opt_event_config > > > if (parse_events_add_pmu(_parse_state, list, $1, $2)) { > > > struct perf_pmu *pmu = NULL; > > > int ok = 0; > > > + char *pattern; > > > + > > > + if (asprintf(&pattern, "%s*", $1) < 0) > > > + YYABORT; > > + if (asprintf(&pattern, "?(uncore_)%s*", $1) < 0) > > I completely overlook that you were using this and thus needed that > > extension, duh, thanks for the patience 8-) and for the new patch. Further trying to remove my brown paper bag: I thought the '?(...)' type of thing would be something _users_ would pass on the perf tool command line, not something used by the tool itself, like on the original patch.... :-) > NP Arnaldo, thanks for the quick turnaround on these patches :o) > Just so I know, since these are my first patches on perf tools, > where are perf tools patches queued once acked? git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git perf/core If they are super urgent, then they will go to a different branch, perf/urgent, that is targetted for the current merge window, i.e. right now: perf/core -> 4.17 perf/urgent -> 4.16 Thanks, and keep the patches flowing! - Arnaldo