From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from orcrist.hmeau.com ([104.223.48.154]:35576 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752093AbeCHP6z (ORCPT ); Thu, 8 Mar 2018 10:58:55 -0500 Date: Thu, 8 Mar 2018 23:58:38 +0800 From: Herbert Xu To: Paul Blakey Cc: Thomas Graf , David Miller , netdev@vger.kernel.org Subject: Re: [PATCH net] test_rhashtable: Add missing rcu_read_lock() Message-ID: <20180308155838.GA9696@gondor.apana.org.au> References: <1520510097-6396-1-git-send-email-paulb@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1520510097-6396-1-git-send-email-paulb@mellanox.com> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, Mar 08, 2018 at 01:54:57PM +0200, Paul Blakey wrote: > Suppress "suspicious rcu_dereference_protected() usage!" on duplicate > insertion test. > > Fixes: 499ac3b60f65 ('test_rhashtable: add test case for rhl_table with duplicate objects') > Signed-off-by: Paul Blakey This shouldn't be doing a table walk in the first place. You should convert it to using the table walk interface. Direct table walks are forbidden because they will break when you hit a resize. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt