From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8942321E0828A for ; Thu, 8 Mar 2018 13:01:54 -0800 (PST) Date: Thu, 8 Mar 2018 14:08:09 -0700 From: Vishal Verma Subject: Re: [PATCH v2 3/3] ndctl: add filtering based on numa_node Message-ID: <20180308210809.GA11622@vverma7-desk1.amr.corp.intel.com> References: <20180307185355.4425-1-ross.zwisler@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20180307185355.4425-1-ross.zwisler@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Ross Zwisler Cc: linux-nvdimm List-ID: On 03/07, Ross Zwisler wrote: > Add support to 'ndctl list' so that we can filter DIMMs, regions and > namespaces based on numa node. > > Signed-off-by: Ross Zwisler > --- > v2: Use NUMA_NO_NODE intead of hard coding -1 (Dan). > --- > Documentation/ndctl/ndctl-list.txt | 4 ++++ > ndctl/list.c | 2 ++ > util/filter.c | 40 ++++++++++++++++++++++++++++++++++++-- > util/filter.h | 1 + > 4 files changed, 45 insertions(+), 2 deletions(-) > Here is the bash completion update for this option. I've tested it on my single-node VM, but Ross, can you test it on your setup and let me know if it completes for the available nodes fine? Thanks, -Vishal 8<----- >>From c744e77f26a27e10cc9dd8ca9b1092a45d9d9dcd Mon Sep 17 00:00:00 2001 From: Vishal Verma Date: Thu, 8 Mar 2018 13:56:59 -0700 Subject: [ndctl PATCH] ndctl, bash-completion: add completion for --numa-node ndctl list can now accept a --numa-node option for filtering by numa node. Use the nodes in /sys/devices/system/node to provide completion options for available nodes. Cc: Ross Zwisler Signed-off-by: Vishal Verma --- contrib/ndctl | 20 +++++++++++++++++++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/contrib/ndctl b/contrib/ndctl index 89e0252..b1f5e59 100755 --- a/contrib/ndctl +++ b/contrib/ndctl @@ -91,7 +91,7 @@ __ndctlcomp() COMPREPLY=( $( compgen -W "$1" -- "$2" ) ) for cword in "${COMPREPLY[@]}"; do - if [[ "$cword" == @(--bus|--region|--type|--mode|--size|--dimm|--reconfig|--uuid|--name|--sector-size|--map|--namespace|--input|--output|--label-version|--align|--block|--count|--firmware|--media-temperature|--ctrl-temperature|--spares|--media-temperature-threshold|--ctrl-temperature-threshold|--spares-threshold|--media-temperature-alarm|--ctrl-temperature-alarm|--spares-alarm) ]]; then + if [[ "$cword" == @(--bus|--region|--type|--mode|--size|--dimm|--reconfig|--uuid|--name|--sector-size|--map|--namespace|--input|--output|--label-version|--align|--block|--count|--firmware|--media-temperature|--ctrl-temperature|--spares|--media-temperature-threshold|--ctrl-temperature-threshold|--spares-threshold|--media-temperature-alarm|--ctrl-temperature-alarm|--spares-alarm|--numa_node) ]]; then COMPREPLY[$i]="${cword}=" else COMPREPLY[$i]="${cword} " @@ -152,6 +152,21 @@ __ndctl_get_sector_sizes() fi } +__ndctl_get_nodes() +{ + local nlist="" + + for node in /sys/devices/system/node/node*; do + node="$(basename $node)" + if [[ $node =~ node([0-9]+) ]]; then + nlist="$nlist ${BASH_REMATCH[1]}" + else + continue + fi + done + echo "$nlist" +} + __ndctl_file_comp() { local cur="$1" @@ -217,6 +232,9 @@ __ndctl_comp_options() --spares-alarm) opts="on off" ;; + --numa_node) + opts=$(__ndctl_get_nodes) + ;; *) return ;; -- 2.14.3 _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm