All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [S87 v5 1/7] i40e: Fix attach VF to VM issue
Date: Thu,  8 Mar 2018 14:52:05 -0800	[thread overview]
Message-ID: <20180308225211.12254-1-jeffrey.t.kirsher@intel.com> (raw)

From: Pawe? Jab?o?ski <pawel.jablonski@intel.com>

Fix for "Resource temporarily unavailable" problem when virsh is
trying to attach a device to VM. When the VF driver is loaded on
host and virsh is trying to attach it to the VM and set a MAC
address, it ends with a race condition between i40e_reset_vf and
i40e_ndo_set_vf_mac functions. The bug is fixed by adding polling
in i40e_ndo_set_vf_mac function For when the VF is in Reset mode.

Signed-off-by: Pawe? Jab?o?ski <pawel.jablonski@intel.com>
---
 drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
index 6049a5640f26..8559c099525d 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
@@ -3742,6 +3742,7 @@ int i40e_ndo_set_vf_mac(struct net_device *netdev, int vf_id, u8 *mac)
 	int ret = 0;
 	struct hlist_node *h;
 	int bkt;
+	u8 i;
 
 	/* validate the request */
 	if (vf_id >= pf->num_alloc_vfs) {
@@ -3753,6 +3754,16 @@ int i40e_ndo_set_vf_mac(struct net_device *netdev, int vf_id, u8 *mac)
 
 	vf = &(pf->vf[vf_id]);
 	vsi = pf->vsi[vf->lan_vsi_idx];
+
+	/* When the VF is resetting wait until it is done.
+	 * It can take up to 200 milliseconds,
+	 * but wait for up to 300 milliseconds to be safe.
+	 */
+	for (i = 0; i < 15; i++) {
+		if (test_bit(I40E_VF_STATE_INIT, &vf->vf_states))
+			break;
+		msleep(20);
+	}
 	if (!test_bit(I40E_VF_STATE_INIT, &vf->vf_states)) {
 		dev_err(&pf->pdev->dev, "VF %d still in reset. Try again.\n",
 			vf_id);
-- 
2.14.3


             reply	other threads:[~2018-03-08 22:52 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-08 22:52 Jeff Kirsher [this message]
2018-03-08 22:52 ` [Intel-wired-lan] [S87 v5 2/7] i40e: Cleanup i40e_vlan_rx_register Jeff Kirsher
2018-03-09  0:28   ` Shannon Nelson
2018-03-12 19:29   ` Bowers, AndrewX
2018-03-08 22:52 ` [Intel-wired-lan] [S87 v5 3/7] i40e: Fix permission check for VF MAC filters Jeff Kirsher
2018-03-12 21:09   ` Bowers, AndrewX
2018-03-08 22:52 ` [Intel-wired-lan] [S87 v5 4/7] i40e: track filter type statistics when deleting invalid filters Jeff Kirsher
2018-03-12 21:20   ` Bowers, AndrewX
2018-03-08 22:52 ` [Intel-wired-lan] [S87 v5 5/7] i40e: factor out re-enable functions for ATR and SB Jeff Kirsher
2018-03-12 21:21   ` Bowers, AndrewX
2018-03-08 22:52 ` [Intel-wired-lan] [S87 v5 6/7] i40e: fix for wrong partition id calculation on OCP mezz cards Jeff Kirsher
2018-03-12 21:21   ` Bowers, AndrewX
2018-03-08 22:52 ` [Intel-wired-lan] [S87 v5 7/7] i40e: restore TCPv4 input set when re-enabling ATR Jeff Kirsher
2018-03-12 21:22   ` Bowers, AndrewX
2018-03-12 19:29 ` [Intel-wired-lan] [S87 v5 1/7] i40e: Fix attach VF to VM issue Bowers, AndrewX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180308225211.12254-1-jeffrey.t.kirsher@intel.com \
    --to=jeffrey.t.kirsher@intel.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.