From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Daniel P. Berrange" Subject: Re: [PATCH v12 28/28] tests/qmp-test: blacklist sev specific qmp commands Date: Thu, 8 Mar 2018 23:22:24 +0000 Message-ID: <20180308232224.GA10248@redhat.com> References: <20180308124901.83533-1-brijesh.singh@amd.com> <20180308124901.83533-29-brijesh.singh@amd.com> <20180308170824.GL4718@redhat.com> <20180308214504.GE3417@localhost.localdomain> Reply-To: "Daniel P. Berrange" Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: "Edgar E. Iglesias" , Peter Maydell , Borislav Petkov , Brijesh Singh , kvm@vger.kernel.org, "Michael S. Tsirkin" , Marcel Apfelbaum , Markus Armbruster , Peter Crosthwaite , Richard Henderson , qemu-devel@nongnu.org, "Dr. David Alan Gilbert" , Christian Borntraeger , Alexander Graf , Stefan Hajnoczi , Cornelia Huck , Paolo Bonzini , Thomas Lendacky , Alistair Francis , Bruce Rogers To: Eduardo Habkost Return-path: Content-Disposition: inline In-Reply-To: <20180308214504.GE3417@localhost.localdomain> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel2=m.gmane.org@nongnu.org Sender: "Qemu-devel" List-Id: kvm.vger.kernel.org On Thu, Mar 08, 2018 at 06:45:04PM -0300, Eduardo Habkost wrote: > On Thu, Mar 08, 2018 at 02:18:55PM -0600, Brijesh Singh wrote: > >=20 > >=20 > > On 3/8/18 11:08 AM, Daniel P. Berrang=C3=A9 wrote: > > > On Thu, Mar 08, 2018 at 06:49:01AM -0600, Brijesh Singh wrote: > > >> Blacklist the following commands to fix the 'make check' failure. > > >> > > >> query-sev-launch-measure: it returns meaninful data only when we l= aunch > > >> SEV guest otherwise the command returns an error. > > >> > > >> query-sev: it return an error when SEV is not available on host (e= .g non > > >> X86 platform or KVM is disabled at the build time) > > >> > > >> query-sev-capabilities: it returns an error when SEV feature is no= t > > >> available on host machine. > > > We generally expect 'make check' to succeed on every single patch > > > in a series, so that 'git bisect' doesn't break. > > > > > > So you should add each command to the blacklist in the same commit > > > that introduced the failure in the first place. > >=20 > >=20 > > Sure, I can quickly send the updated patch series to address your thi= s > > concern, but before spamming everyone's inbox I was wondering if I ca= n > > get some indication whether this series will make into 2.12 merge. > >=20 > > Paolo, Eduardo and Richard, > >=20 > > Most of the changes are in x86 directory hence any thought if you are > > considering this series for 2.12 ? I have been testing the series wit= h > > and without SEV support and so far have not ran into any issue. if yo= u > > are not planning to pull this series in 2.12 then I will wait a bit > > longer to get more feedback before sending the updates to address > > Daniel's comment. thanks >=20 > Trying to merge it before 2.12 soft freeze (next Tuesday) still > looks like a reasonable goal to me. What do others think? I've only really looked at the QAPI / QMP bits and they seem fine from pov of libvirt's needs - just very minor comments. So not objection from me on that area of the code. Regards, Daniel --=20 |: http://berrange.com -o- http://www.flickr.com/photos/dberrange= / :| |: http://libvirt.org -o- http://virt-manager.or= g :| |: http://entangle-photo.org -o- http://search.cpan.org/~danberr= / :| From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38486) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eu4rz-0007Gt-HH for qemu-devel@nongnu.org; Thu, 08 Mar 2018 18:22:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eu4rw-0004XZ-9i for qemu-devel@nongnu.org; Thu, 08 Mar 2018 18:22:43 -0500 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:56554 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eu4rw-0004XL-3H for qemu-devel@nongnu.org; Thu, 08 Mar 2018 18:22:40 -0500 Date: Thu, 8 Mar 2018 23:22:24 +0000 From: "Daniel P. Berrange" Message-ID: <20180308232224.GA10248@redhat.com> Reply-To: "Daniel P. Berrange" References: <20180308124901.83533-1-brijesh.singh@amd.com> <20180308124901.83533-29-brijesh.singh@amd.com> <20180308170824.GL4718@redhat.com> <20180308214504.GE3417@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180308214504.GE3417@localhost.localdomain> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v12 28/28] tests/qmp-test: blacklist sev specific qmp commands List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: Brijesh Singh , qemu-devel@nongnu.org, Alistair Francis , Christian Borntraeger , Cornelia Huck , "Dr. David Alan Gilbert" , "Michael S. Tsirkin" , "Edgar E. Iglesias" , Eric Blake , kvm@vger.kernel.org, Marcel Apfelbaum , Markus Armbruster , Paolo Bonzini , Peter Crosthwaite , Peter Maydell , Richard Henderson , Stefan Hajnoczi , Thomas Lendacky , Borislav Petkov , Alexander Graf , Bruce Rogers On Thu, Mar 08, 2018 at 06:45:04PM -0300, Eduardo Habkost wrote: > On Thu, Mar 08, 2018 at 02:18:55PM -0600, Brijesh Singh wrote: > >=20 > >=20 > > On 3/8/18 11:08 AM, Daniel P. Berrang=C3=A9 wrote: > > > On Thu, Mar 08, 2018 at 06:49:01AM -0600, Brijesh Singh wrote: > > >> Blacklist the following commands to fix the 'make check' failure. > > >> > > >> query-sev-launch-measure: it returns meaninful data only when we l= aunch > > >> SEV guest otherwise the command returns an error. > > >> > > >> query-sev: it return an error when SEV is not available on host (e= .g non > > >> X86 platform or KVM is disabled at the build time) > > >> > > >> query-sev-capabilities: it returns an error when SEV feature is no= t > > >> available on host machine. > > > We generally expect 'make check' to succeed on every single patch > > > in a series, so that 'git bisect' doesn't break. > > > > > > So you should add each command to the blacklist in the same commit > > > that introduced the failure in the first place. > >=20 > >=20 > > Sure, I can quickly send the updated patch series to address your thi= s > > concern, but before spamming everyone's inbox I was wondering if I ca= n > > get some indication whether this series will make into 2.12 merge. > >=20 > > Paolo, Eduardo and Richard, > >=20 > > Most of the changes are in x86 directory hence any thought if you are > > considering this series for 2.12 ? I have been testing the series wit= h > > and without SEV support and so far have not ran into any issue. if yo= u > > are not planning to pull this series in 2.12 then I will wait a bit > > longer to get more feedback before sending the updates to address > > Daniel's comment. thanks >=20 > Trying to merge it before 2.12 soft freeze (next Tuesday) still > looks like a reasonable goal to me. What do others think? I've only really looked at the QAPI / QMP bits and they seem fine from pov of libvirt's needs - just very minor comments. So not objection from me on that area of the code. Regards, Daniel --=20 |: http://berrange.com -o- http://www.flickr.com/photos/dberrange= / :| |: http://libvirt.org -o- http://virt-manager.or= g :| |: http://entangle-photo.org -o- http://search.cpan.org/~danberr= / :|