From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751266AbeCIANT (ORCPT ); Thu, 8 Mar 2018 19:13:19 -0500 Received: from vps.xff.cz ([195.181.215.36]:56306 "EHLO vps.xff.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751083AbeCIANR (ORCPT ); Thu, 8 Mar 2018 19:13:17 -0500 Date: Fri, 9 Mar 2018 01:13:14 +0100 From: =?utf-8?Q?Ond=C5=99ej?= Jirman To: Jernej =?utf-8?Q?=C5=A0krabec?= Cc: maxime.ripard@free-electrons.com, wens@csie.org, airlied@linux.ie, robh+dt@kernel.org, mark.rutland@arm.com, mturquette@baylibre.com, sboyd@kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [linux-sunxi] [PATCH v3 06/16] drm/sun4i: Release exclusive clock lock when disabling TCON Message-ID: <20180309001314.bu3zcv5gyqsc52fx@core.my.home> Mail-Followup-To: Jernej =?utf-8?Q?=C5=A0krabec?= , maxime.ripard@free-electrons.com, wens@csie.org, airlied@linux.ie, robh+dt@kernel.org, mark.rutland@arm.com, mturquette@baylibre.com, sboyd@kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-sunxi@googlegroups.com References: <20180301213442.16677-1-jernej.skrabec@siol.net> <20180301213442.16677-7-jernej.skrabec@siol.net> <20180308224717.a6ieadihwh7u5rbu@core.my.home> <3764594.86uYqsI6mN@jernej-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3764594.86uYqsI6mN@jernej-laptop> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jernej, On Thu, Mar 08, 2018 at 11:57:40PM +0100, Jernej Škrabec wrote: > Hi, > > Dne četrtek, 08. marec 2018 ob 23:47:17 CET je Ondřej Jirman napisal(a): > > Hi, > > > > On Thu, Mar 01, 2018 at 10:34:32PM +0100, Jernej Skrabec wrote: > > > Currently exclusive TCON clock lock is never released, which, for > > > example, prevents changing resolution on HDMI. > > > > > > In order to fix that, release clock when disabling TCON. TCON is always > > > disabled first before new mode is set. > > > > > > Signed-off-by: Jernej Skrabec > > > --- > > > > > > drivers/gpu/drm/sun4i/sun4i_tcon.c | 6 ++++-- > > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/gpu/drm/sun4i/sun4i_tcon.c > > > b/drivers/gpu/drm/sun4i/sun4i_tcon.c index 1d714c06ec9d..7f6c4125c89f > > > 100644 > > > --- a/drivers/gpu/drm/sun4i/sun4i_tcon.c > > > +++ b/drivers/gpu/drm/sun4i/sun4i_tcon.c > > > @@ -102,10 +102,12 @@ static void sun4i_tcon_channel_set_status(struct > > > sun4i_tcon *tcon, int channel,> > > > return; > > > > > > } > > > > > > - if (enabled) > > > + if (enabled) { > > > > > > clk_prepare_enable(clk); > > > > > > - else > > > + } else { > > > + clk_rate_exclusive_put(clk); > > > > > > clk_disable_unprepare(clk); > > > > > > + } > > > > > > } > > > > At least in the linux-next/master I can't see clk_rate_exclusive_get call: > > > > It is in drm-misc/drm-misc-fixes: > https://cgit.freedesktop.org/drm/drm-misc/commit/?h=drm-misc-fixes&id=79d103a565d16b1893d990b2ee5e0fe71767759f > > My patch is also applied in same branch, so there should be no issues while > merging all those branches. > > linux-next doesn't have either patches currently: https://git.kernel.org/pub/ > scm/linux/kernel/git/next/linux-next.git/log/drivers/gpu/drm/sun4i > > This is issue only if you manually apply one patch without the other. I have (and had) both patches applied. There's perhaps some code path, where sun4i_tcon_channel_set_status(..., false) is called in unbalanced way with regards to clk_set_rate_exclusive(). The issue occurs when starting Xorg. But Xorg works fine. regards, o. > Best regards, > Jernej > > > $ git grep 'exclusive' linux-next/master -- drivers/gpu/drm/sun4i > > > > linux-next/master:sun4i_hdmi.h: * On sun5i the threshold is exclusive, > > i.e. does not include, linux-next/master:sun4i_tcon.c: > > clk_rate_exclusive_put(clk); linux-next/master:sun4i_tcon.c: > > clk_set_rate_exclusive(tcon->dclk, mode->crtc_clock * 1000); > > linux-next/master:sun4i_tcon.c: clk_set_rate_exclusive(tcon->sclk1, > > mode->crtc_clock * 1000); > > > > and the kernel complains too: > > > > [ 841.915161] ------------[ cut here ]------------ > > [ 841.915187] WARNING: CPU: 0 PID: 273 at > > /workspace/megous.com/orangepi-pc/linux-4.16/drivers/clk/clk.c:608 > > clk_rate_exclusive_put+0x48/0x4c [ 841.915194] CPU: 0 PID: 273 Comm: Xorg > > Not tainted 4.16.0-rc4-00268-gbac2ecf73ed0 #13 [ 841.915196] Hardware > > name: Allwinner sun8i Family > > [ 841.915217] [] (unwind_backtrace) from [] > > (show_stack+0x10/0x14) [ 841.915228] [] (show_stack) from > > [] (dump_stack+0x88/0x9c) [ 841.915237] [] > > (dump_stack) from [] (__warn+0xd4/0xf0) [ 841.915244] > > [] (__warn) from [] (warn_slowpath_null+0x40/0x48) [ > > 841.915250] [] (warn_slowpath_null) from [] > > (clk_rate_exclusive_put+0x48/0x4c) [ 841.915261] [] > > (clk_rate_exclusive_put) from [] > > (sun4i_tcon_set_status+0x178/0x2f0) [ 841.915269] [] > > (sun4i_tcon_set_status) from [] > > (sun4i_crtc_atomic_disable+0x7c/0xe4) [ 841.915279] [] > > (sun4i_crtc_atomic_disable) from [] > > (drm_atomic_helper_commit_modeset_disables+0x390/0x46c) [ 841.915288] > > [] (drm_atomic_helper_commit_modeset_disables) from [] > > (drm_atomic_helper_commit_tail_rpm+0x18/0x64) [ 841.915295] [] > > (drm_atomic_helper_commit_tail_rpm) from [] > > (commit_tail+0x40/0x6c) [ 841.915302] [] (commit_tail) from > > [] (drm_atomic_helper_commit+0xbc/0x128) [ 841.915311] > > [] (drm_atomic_helper_commit) from [] > > (restore_fbdev_mode_atomic+0x100/0x1fc) [ 841.915319] [] > > (restore_fbdev_mode_atomic) from [] > > (drm_fb_helper_dpms+0x50/0x130) [ 841.915328] [] > > (drm_fb_helper_dpms) from [] (drm_fb_helper_blank+0x54/0x90) [ > > 841.915337] [] (drm_fb_helper_blank) from [] > > (fb_blank+0x54/0xa8) [ 841.915343] [] (fb_blank) from > > [] (do_fb_ioctl+0x360/0x62c) [ 841.915351] [] > > (do_fb_ioctl) from [] (do_vfs_ioctl+0x9c/0x774) [ 841.915358] > > [] (do_vfs_ioctl) from [] (SyS_ioctl+0x34/0x58) [ > > 841.915364] [] (SyS_ioctl) from [] > > (ret_fast_syscall+0x0/0x4c) [ 841.915368] Exception stack(0xe5fc5fa8 to > > 0xe5fc5ff0) > > [ 841.915373] 5fa0: 00674f10 00675460 0000000b 00004611 > > 00000001 00000000 [ 841.915379] 5fc0: 00674f10 00675460 00000001 00000036 > > 00650474 00000000 006504a4 00675df8 [ 841.915382] 5fe0: b61a502c be8acb2c > > b6192c38 b6b152ec > > [ 841.915386] ---[ end trace fa81b956197707f8 ]--- > > > > It looks like clk_rate_exclusive_put inside sun4i_tcon_channel_set_status is > > called without first calling some function that would call > > clk_set_rate_exclusive, leading to unbalanced get/put calls. > > > > regards, > > o. > > > > > static void sun4i_tcon_lvds_set_status(struct sun4i_tcon *tcon, > > > > > > -- > > > 2.16.2 > > > > > > -- > > > You received this message because you are subscribed to the Google Groups > > > "linux-sunxi" group. To unsubscribe from this group and stop receiving > > > emails from it, send an email to > > > linux-sunxi+unsubscribe@googlegroups.com. For more options, visit > > > https://groups.google.com/d/optout. > > > > > -- > You received this message because you are subscribed to the Google Groups "linux-sunxi" group. > To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?=27Ond=C5=99ej_Jirman=27_via_linux=2Dsunxi?= Subject: Re: [PATCH v3 06/16] drm/sun4i: Release exclusive clock lock when disabling TCON Date: Fri, 9 Mar 2018 01:13:14 +0100 Message-ID: <20180309001314.bu3zcv5gyqsc52fx@core.my.home> References: <20180301213442.16677-1-jernej.skrabec@siol.net> <20180301213442.16677-7-jernej.skrabec@siol.net> <20180308224717.a6ieadihwh7u5rbu@core.my.home> <3764594.86uYqsI6mN@jernej-laptop> Reply-To: megi-DlDF6nMZSto@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline In-Reply-To: <3764594.86uYqsI6mN@jernej-laptop> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Jernej =?utf-8?Q?=C5=A0krabec?= Cc: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org, wens-jdAy2FN1RRM@public.gmane.org, airlied-cv59FeDIM0c@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, mturquette-rdvid1DuHRBWk0Htik3J/w@public.gmane.org, sboyd-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Id: devicetree@vger.kernel.org Hi Jernej, On Thu, Mar 08, 2018 at 11:57:40PM +0100, Jernej =C5=A0krabec wrote: > Hi, >=20 > Dne =C4=8Detrtek, 08. marec 2018 ob 23:47:17 CET je Ond=C5=99ej Jirman na= pisal(a): > > Hi, > >=20 > > On Thu, Mar 01, 2018 at 10:34:32PM +0100, Jernej Skrabec wrote: > > > Currently exclusive TCON clock lock is never released, which, for > > > example, prevents changing resolution on HDMI. > > >=20 > > > In order to fix that, release clock when disabling TCON. TCON is alwa= ys > > > disabled first before new mode is set. > > >=20 > > > Signed-off-by: Jernej Skrabec > > > --- > > >=20 > > > drivers/gpu/drm/sun4i/sun4i_tcon.c | 6 ++++-- > > > 1 file changed, 4 insertions(+), 2 deletions(-) > > >=20 > > > diff --git a/drivers/gpu/drm/sun4i/sun4i_tcon.c > > > b/drivers/gpu/drm/sun4i/sun4i_tcon.c index 1d714c06ec9d..7f6c4125c89f > > > 100644 > > > --- a/drivers/gpu/drm/sun4i/sun4i_tcon.c > > > +++ b/drivers/gpu/drm/sun4i/sun4i_tcon.c > > > @@ -102,10 +102,12 @@ static void sun4i_tcon_channel_set_status(struc= t > > > sun4i_tcon *tcon, int channel,>=20 > > > return; > > > =09 > > > } > > >=20 > > > - if (enabled) > > > + if (enabled) { > > >=20 > > > clk_prepare_enable(clk); > > >=20 > > > - else > > > + } else { > > > + clk_rate_exclusive_put(clk); > > >=20 > > > clk_disable_unprepare(clk); > > >=20 > > > + } > > >=20 > > > } > >=20 > > At least in the linux-next/master I can't see clk_rate_exclusive_get ca= ll: > >=20 >=20 > It is in drm-misc/drm-misc-fixes: > https://cgit.freedesktop.org/drm/drm-misc/commit/?h=3Ddrm-misc-fixes&id= =3D79d103a565d16b1893d990b2ee5e0fe71767759f >=20 > My patch is also applied in same branch, so there should be no issues whi= le=20 > merging all those branches. >=20 > linux-next doesn't have either patches currently: https://git.kernel.org/= pub/ > scm/linux/kernel/git/next/linux-next.git/log/drivers/gpu/drm/sun4i >=20 > This is issue only if you manually apply one patch without the other. I have (and had) both patches applied. There's perhaps some code path, where sun4i_tcon_channel_set_status(..., false) is called in unbalanced way with regards to clk_set_rate_exclusive(). The issue occurs when starting Xorg. But Xorg works fine. regards, o. > Best regards, > Jernej >=20 > > $ git grep 'exclusive' linux-next/master -- drivers/gpu/drm/sun4i > >=20 > > linux-next/master:sun4i_hdmi.h: * On sun5i the threshold is exclusiv= e, > > i.e. does not include, linux-next/master:sun4i_tcon.c: =20 > > clk_rate_exclusive_put(clk); linux-next/master:sun4i_tcon.c: =20 > > clk_set_rate_exclusive(tcon->dclk, mode->crtc_clock * 1000); > > linux-next/master:sun4i_tcon.c: clk_set_rate_exclusive(tcon->sclk1, > > mode->crtc_clock * 1000); > >=20 > > and the kernel complains too: > >=20 > > [ 841.915161] ------------[ cut here ]------------ > > [ 841.915187] WARNING: CPU: 0 PID: 273 at > > /workspace/megous.com/orangepi-pc/linux-4.16/drivers/clk/clk.c:608 > > clk_rate_exclusive_put+0x48/0x4c [ 841.915194] CPU: 0 PID: 273 Comm: X= org > > Not tainted 4.16.0-rc4-00268-gbac2ecf73ed0 #13 [ 841.915196] Hardware > > name: Allwinner sun8i Family > > [ 841.915217] [] (unwind_backtrace) from [] > > (show_stack+0x10/0x14) [ 841.915228] [] (show_stack) from > > [] (dump_stack+0x88/0x9c) [ 841.915237] [] > > (dump_stack) from [] (__warn+0xd4/0xf0) [ 841.915244] > > [] (__warn) from [] (warn_slowpath_null+0x40/0x48) = [=20 > > 841.915250] [] (warn_slowpath_null) from [] > > (clk_rate_exclusive_put+0x48/0x4c) [ 841.915261] [] > > (clk_rate_exclusive_put) from [] > > (sun4i_tcon_set_status+0x178/0x2f0) [ 841.915269] [] > > (sun4i_tcon_set_status) from [] > > (sun4i_crtc_atomic_disable+0x7c/0xe4) [ 841.915279] [] > > (sun4i_crtc_atomic_disable) from [] > > (drm_atomic_helper_commit_modeset_disables+0x390/0x46c) [ 841.915288] > > [] (drm_atomic_helper_commit_modeset_disables) from [] > > (drm_atomic_helper_commit_tail_rpm+0x18/0x64) [ 841.915295] [] > > (drm_atomic_helper_commit_tail_rpm) from [] > > (commit_tail+0x40/0x6c) [ 841.915302] [] (commit_tail) from > > [] (drm_atomic_helper_commit+0xbc/0x128) [ 841.915311] > > [] (drm_atomic_helper_commit) from [] > > (restore_fbdev_mode_atomic+0x100/0x1fc) [ 841.915319] [] > > (restore_fbdev_mode_atomic) from [] > > (drm_fb_helper_dpms+0x50/0x130) [ 841.915328] [] > > (drm_fb_helper_dpms) from [] (drm_fb_helper_blank+0x54/0x90) = [=20 > > 841.915337] [] (drm_fb_helper_blank) from [] > > (fb_blank+0x54/0xa8) [ 841.915343] [] (fb_blank) from > > [] (do_fb_ioctl+0x360/0x62c) [ 841.915351] [] > > (do_fb_ioctl) from [] (do_vfs_ioctl+0x9c/0x774) [ 841.915358= ] > > [] (do_vfs_ioctl) from [] (SyS_ioctl+0x34/0x58) [= =20 > > 841.915364] [] (SyS_ioctl) from [] > > (ret_fast_syscall+0x0/0x4c) [ 841.915368] Exception stack(0xe5fc5fa8 t= o > > 0xe5fc5ff0) > > [ 841.915373] 5fa0: 00674f10 00675460 0000000b 00004= 611 > > 00000001 00000000 [ 841.915379] 5fc0: 00674f10 00675460 00000001 00000= 036 > > 00650474 00000000 006504a4 00675df8 [ 841.915382] 5fe0: b61a502c be8ac= b2c > > b6192c38 b6b152ec > > [ 841.915386] ---[ end trace fa81b956197707f8 ]--- > >=20 > > It looks like clk_rate_exclusive_put inside sun4i_tcon_channel_set_stat= us is > > called without first calling some function that would call > > clk_set_rate_exclusive, leading to unbalanced get/put calls. > >=20 > > regards, > > o. > >=20 > > > static void sun4i_tcon_lvds_set_status(struct sun4i_tcon *tcon, > > >=20 > > > -- > > > 2.16.2 > > >=20 > > > -- > > > You received this message because you are subscribed to the Google Gr= oups > > > "linux-sunxi" group. To unsubscribe from this group and stop receivin= g > > > emails from it, send an email to > > > linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit > > > https://groups.google.com/d/optout. >=20 >=20 >=20 >=20 > --=20 > You received this message because you are subscribed to the Google Groups= "linux-sunxi" group. > To unsubscribe from this group and stop receiving emails from it, send an= email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org > For more options, visit https://groups.google.com/d/optout. --=20 You received this message because you are subscribed to the Google Groups "= linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 From: megi@xff.cz (=?utf-8?Q?Ond=C5=99ej?= Jirman) Date: Fri, 9 Mar 2018 01:13:14 +0100 Subject: [linux-sunxi] [PATCH v3 06/16] drm/sun4i: Release exclusive clock lock when disabling TCON In-Reply-To: <3764594.86uYqsI6mN@jernej-laptop> References: <20180301213442.16677-1-jernej.skrabec@siol.net> <20180301213442.16677-7-jernej.skrabec@siol.net> <20180308224717.a6ieadihwh7u5rbu@core.my.home> <3764594.86uYqsI6mN@jernej-laptop> Message-ID: <20180309001314.bu3zcv5gyqsc52fx@core.my.home> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Jernej, On Thu, Mar 08, 2018 at 11:57:40PM +0100, Jernej ?krabec wrote: > Hi, > > Dne ?etrtek, 08. marec 2018 ob 23:47:17 CET je Ond?ej Jirman napisal(a): > > Hi, > > > > On Thu, Mar 01, 2018 at 10:34:32PM +0100, Jernej Skrabec wrote: > > > Currently exclusive TCON clock lock is never released, which, for > > > example, prevents changing resolution on HDMI. > > > > > > In order to fix that, release clock when disabling TCON. TCON is always > > > disabled first before new mode is set. > > > > > > Signed-off-by: Jernej Skrabec > > > --- > > > > > > drivers/gpu/drm/sun4i/sun4i_tcon.c | 6 ++++-- > > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/gpu/drm/sun4i/sun4i_tcon.c > > > b/drivers/gpu/drm/sun4i/sun4i_tcon.c index 1d714c06ec9d..7f6c4125c89f > > > 100644 > > > --- a/drivers/gpu/drm/sun4i/sun4i_tcon.c > > > +++ b/drivers/gpu/drm/sun4i/sun4i_tcon.c > > > @@ -102,10 +102,12 @@ static void sun4i_tcon_channel_set_status(struct > > > sun4i_tcon *tcon, int channel,> > > > return; > > > > > > } > > > > > > - if (enabled) > > > + if (enabled) { > > > > > > clk_prepare_enable(clk); > > > > > > - else > > > + } else { > > > + clk_rate_exclusive_put(clk); > > > > > > clk_disable_unprepare(clk); > > > > > > + } > > > > > > } > > > > At least in the linux-next/master I can't see clk_rate_exclusive_get call: > > > > It is in drm-misc/drm-misc-fixes: > https://cgit.freedesktop.org/drm/drm-misc/commit/?h=drm-misc-fixes&id=79d103a565d16b1893d990b2ee5e0fe71767759f > > My patch is also applied in same branch, so there should be no issues while > merging all those branches. > > linux-next doesn't have either patches currently: https://git.kernel.org/pub/ > scm/linux/kernel/git/next/linux-next.git/log/drivers/gpu/drm/sun4i > > This is issue only if you manually apply one patch without the other. I have (and had) both patches applied. There's perhaps some code path, where sun4i_tcon_channel_set_status(..., false) is called in unbalanced way with regards to clk_set_rate_exclusive(). The issue occurs when starting Xorg. But Xorg works fine. regards, o. > Best regards, > Jernej > > > $ git grep 'exclusive' linux-next/master -- drivers/gpu/drm/sun4i > > > > linux-next/master:sun4i_hdmi.h: * On sun5i the threshold is exclusive, > > i.e. does not include, linux-next/master:sun4i_tcon.c: > > clk_rate_exclusive_put(clk); linux-next/master:sun4i_tcon.c: > > clk_set_rate_exclusive(tcon->dclk, mode->crtc_clock * 1000); > > linux-next/master:sun4i_tcon.c: clk_set_rate_exclusive(tcon->sclk1, > > mode->crtc_clock * 1000); > > > > and the kernel complains too: > > > > [ 841.915161] ------------[ cut here ]------------ > > [ 841.915187] WARNING: CPU: 0 PID: 273 at > > /workspace/megous.com/orangepi-pc/linux-4.16/drivers/clk/clk.c:608 > > clk_rate_exclusive_put+0x48/0x4c [ 841.915194] CPU: 0 PID: 273 Comm: Xorg > > Not tainted 4.16.0-rc4-00268-gbac2ecf73ed0 #13 [ 841.915196] Hardware > > name: Allwinner sun8i Family > > [ 841.915217] [] (unwind_backtrace) from [] > > (show_stack+0x10/0x14) [ 841.915228] [] (show_stack) from > > [] (dump_stack+0x88/0x9c) [ 841.915237] [] > > (dump_stack) from [] (__warn+0xd4/0xf0) [ 841.915244] > > [] (__warn) from [] (warn_slowpath_null+0x40/0x48) [ > > 841.915250] [] (warn_slowpath_null) from [] > > (clk_rate_exclusive_put+0x48/0x4c) [ 841.915261] [] > > (clk_rate_exclusive_put) from [] > > (sun4i_tcon_set_status+0x178/0x2f0) [ 841.915269] [] > > (sun4i_tcon_set_status) from [] > > (sun4i_crtc_atomic_disable+0x7c/0xe4) [ 841.915279] [] > > (sun4i_crtc_atomic_disable) from [] > > (drm_atomic_helper_commit_modeset_disables+0x390/0x46c) [ 841.915288] > > [] (drm_atomic_helper_commit_modeset_disables) from [] > > (drm_atomic_helper_commit_tail_rpm+0x18/0x64) [ 841.915295] [] > > (drm_atomic_helper_commit_tail_rpm) from [] > > (commit_tail+0x40/0x6c) [ 841.915302] [] (commit_tail) from > > [] (drm_atomic_helper_commit+0xbc/0x128) [ 841.915311] > > [] (drm_atomic_helper_commit) from [] > > (restore_fbdev_mode_atomic+0x100/0x1fc) [ 841.915319] [] > > (restore_fbdev_mode_atomic) from [] > > (drm_fb_helper_dpms+0x50/0x130) [ 841.915328] [] > > (drm_fb_helper_dpms) from [] (drm_fb_helper_blank+0x54/0x90) [ > > 841.915337] [] (drm_fb_helper_blank) from [] > > (fb_blank+0x54/0xa8) [ 841.915343] [] (fb_blank) from > > [] (do_fb_ioctl+0x360/0x62c) [ 841.915351] [] > > (do_fb_ioctl) from [] (do_vfs_ioctl+0x9c/0x774) [ 841.915358] > > [] (do_vfs_ioctl) from [] (SyS_ioctl+0x34/0x58) [ > > 841.915364] [] (SyS_ioctl) from [] > > (ret_fast_syscall+0x0/0x4c) [ 841.915368] Exception stack(0xe5fc5fa8 to > > 0xe5fc5ff0) > > [ 841.915373] 5fa0: 00674f10 00675460 0000000b 00004611 > > 00000001 00000000 [ 841.915379] 5fc0: 00674f10 00675460 00000001 00000036 > > 00650474 00000000 006504a4 00675df8 [ 841.915382] 5fe0: b61a502c be8acb2c > > b6192c38 b6b152ec > > [ 841.915386] ---[ end trace fa81b956197707f8 ]--- > > > > It looks like clk_rate_exclusive_put inside sun4i_tcon_channel_set_status is > > called without first calling some function that would call > > clk_set_rate_exclusive, leading to unbalanced get/put calls. > > > > regards, > > o. > > > > > static void sun4i_tcon_lvds_set_status(struct sun4i_tcon *tcon, > > > > > > -- > > > 2.16.2 > > > > > > -- > > > You received this message because you are subscribed to the Google Groups > > > "linux-sunxi" group. To unsubscribe from this group and stop receiving > > > emails from it, send an email to > > > linux-sunxi+unsubscribe at googlegroups.com. For more options, visit > > > https://groups.google.com/d/optout. > > > > > -- > You received this message because you are subscribed to the Google Groups "linux-sunxi" group. > To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe at googlegroups.com. > For more options, visit https://groups.google.com/d/optout.