All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Mladek <pmladek@suse.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Arnd Bergmann <arnd@arndb.de>, Tejun Heo <tj@kernel.org>,
	Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
	Dave Young <dyoung@redhat.com>, Andi Kleen <ak@linux.intel.com>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	adi-buildroot-devel@lists.sourceforge.net,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Subject: Re: [PATCH] dump_stack: convert generic dump_stack into a weak symbol
Date: Fri, 9 Mar 2018 10:50:55 +0100	[thread overview]
Message-ID: <20180309095054.vrngc6fz7wo3hd4x@pathway.suse.cz> (raw)
In-Reply-To: <20180307114845.GA894@jagdpanzerIV>

On Wed 2018-03-07 20:48:56, Sergey Senozhatsky wrote:
> On (03/07/18 11:57), Arnd Bergmann wrote:
> > Since lib/dump_stack.c is mandatory then, I would suggest making it
> > obj-y and moving it out of lib/ into kernel/printk/.
> 
> Totally agree on obj-y. And tend to agree on moving lib/dump_stack to
> kernel/printk. lib/dump_stack depends on CONFIG_PRINTK and is partially
> in printk.h. So it _mostly_ seems like the right place after all.

I agree that we should define dump_stack.o as obj-y. Also it makes
sense to move it to kernel/printk/. As Sergey said: it depends on
CONFIG_PRINTK and is in printk.h.

Steven, do you agree or would you suggest another location?
It was you who suggested to move the several functions from printk.c
to dump_stack.c. IMHO, the motivation was to fix responsibilities
(maintainer-ship) of this stuff. This will not really happen if
we move the file to printk directory.

Best Regards,
Petr

  parent reply	other threads:[~2018-03-09  9:50 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-05  5:37 [PATCH] dump_stack: convert generic dump_stack into a weak symbol Sergey Senozhatsky
2018-03-05 14:48 ` Petr Mladek
2018-03-06  2:50   ` Greentime Hu
2018-03-06  4:31     ` Sergey Senozhatsky
2018-03-06  5:34       ` Greentime Hu
2018-03-06  4:29   ` Sergey Senozhatsky
2018-03-06 12:43     ` Petr Mladek
2018-03-06 22:52       ` Stephen Rothwell
2018-03-06 13:27 ` Arnd Bergmann
2018-03-07  2:21   ` Sergey Senozhatsky
2018-03-07  8:46     ` Arnd Bergmann
2018-03-07  9:09       ` Petr Mladek
2018-03-07  9:44         ` Greentime Hu
2018-03-07  9:50           ` Arnd Bergmann
2018-03-07 10:40       ` Sergey Senozhatsky
2018-03-07 10:57         ` Arnd Bergmann
2018-03-07 11:48           ` Sergey Senozhatsky
2018-03-07 12:41             ` Stephen Rothwell
2018-03-07 12:48               ` Arnd Bergmann
2018-03-07 12:53                 ` Stephen Rothwell
2018-03-07 12:58                   ` Arnd Bergmann
2018-03-07 13:10                     ` Stephen Rothwell
2018-03-07 13:40                 ` Sergey Senozhatsky
2018-03-07 14:01               ` Sergey Senozhatsky
2018-03-09  9:50             ` Petr Mladek [this message]
2018-03-14 23:42               ` Steven Rostedt
2018-03-14 23:58                 ` Stephen Rothwell
2018-03-07  8:49     ` Petr Mladek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180309095054.vrngc6fz7wo3hd4x@pathway.suse.cz \
    --to=pmladek@suse.com \
    --cc=adi-buildroot-devel@lists.sourceforge.net \
    --cc=ak@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=deanbo422@gmail.com \
    --cc=dyoung@redhat.com \
    --cc=green.hu@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=sergey.senozhatsky.work@gmail.com \
    --cc=sergey.senozhatsky@gmail.com \
    --cc=sfr@canb.auug.org.au \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.