From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AG47ELssut0kgykrksgyu4P06U9z4vEgw7O3JZhlBczhYEC5JJo5eeh/jd4Na5j49krDK3xaBOcB ARC-Seal: i=1; a=rsa-sha256; t=1520594880; cv=none; d=google.com; s=arc-20160816; b=oFDIm8fikEw4ElnisbE3jhNGgouo7E/EPS8jYKX80XsWBK0D/2ZoLrg1Bh4COjWo5i nLBQtGYhE0FVyKAVQkM65RZuJwCWmfCVpTZIPYb1PSdFMhguGr4JgIOWfr3bC6wwF7Ta eosSRhpZuRkVMUrwTRb4kvNgtXkJ/PUfPy4Bumv1bcnuv/Aaq7JIwIK0fYOJ2A0niaki wKeMIoGrCQSSINKqRUCnrYsBw/fVtbx+CsRXg7qQ8UMIkjiQXVEiXi0PkEVS2MAUpIpI /tQ94R1+8nc9qmydbJ/meGd2kvyEojx4TFV51Aq01WgvXKmpZJL1KGYae1JZzqqwpKue L7kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:delivered-to:delivered-to :list-id:list-subscribe:list-unsubscribe:list-help:list-post :precedence:mailing-list:arc-authentication-results; bh=p/bo8UgyjPjFhzmqdS0LHeu8xJdQ2nNsbDbUVOkQ2Qs=; b=mq8DZEMCiDjQ3FwMe1oQi9loeVuERydjfw3MLPjgibdGblNE9q8gXQe9G/bI5r0QNc +9mbwPRfz9KI2DuJyw9Njq8H1S4/M/DzvbsJ0cTOuwoWlmXXx/Ds6dTNp3UlSVtyNrxi L4wwG/JR2ytPZ5XyPEsmX5s/7VkCy/44Y2iEDFkYflu8iW52S1WZHGaRown2uelY9jT5 iXi3aFx8ZgzOfp65/8V0RVPRBR0/A56PaOJfE9WhiS+DgjbOYgtHfIOogxJlK8fVmR8H CGHkot1cHxn9yOe9tTP7Yp3Hte8XwZC0M5+G9WQB/NhMARuIJ9lKGSHIXQHSXmSU5N/f 1f1Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of kernel-hardening-return-12311-gregkh=linuxfoundation.org@lists.openwall.com designates 195.42.179.200 as permitted sender) smtp.mailfrom=kernel-hardening-return-12311-gregkh=linuxfoundation.org@lists.openwall.com Authentication-Results: mx.google.com; spf=pass (google.com: domain of kernel-hardening-return-12311-gregkh=linuxfoundation.org@lists.openwall.com designates 195.42.179.200 as permitted sender) smtp.mailfrom=kernel-hardening-return-12311-gregkh=linuxfoundation.org@lists.openwall.com Mailing-List: contact kernel-hardening-help@lists.openwall.com; run by ezmlm List-Post: List-Help: List-Unsubscribe: List-Subscribe: Date: Fri, 9 Mar 2018 10:59:40 +0000 From: Eric Engestrom To: "Gustavo A. R. Silva" CC: Emil Velikov , Florian Tobias Schandinat , Bartlomiej Zolnierkiewicz , , Kees Cook , , , , "Gustavo A. R. Silva" Subject: Re: [PATCH] video: fbdev: via: remove VLA usage Message-ID: <20180309105940.22hd2uy2mv7wahzb@imgtec.com> References: <20180308173949.GA19305@embeddedgus> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline In-Reply-To: <20180308173949.GA19305@embeddedgus> User-Agent: NeoMutt/20171215 X-Originating-IP: [10.60.4.28] X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1594392120539391557?= X-GMAIL-MSGID: =?utf-8?q?1594459297429897186?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Thursday, 2018-03-08 11:39:49 -0600, Gustavo A. R. Silva wrote: > In preparation to enabling -Wvla, remove VLA usage. > > Also, fixed as part of the directive to remove all VLAs from > the kernel: https://lkml.org/lkml/2018/3/7/621 > > Signed-off-by: Gustavo A. R. Silva Sorry for my reply on v1, I missed that Emil already replied to another post of the same patch (side note on that, making use of `-vX` and `--in-reply-to` helps track the evolution of patches) This looks good to me: Reviewed-by: Eric Engestrom > --- > drivers/video/fbdev/via/via_aux_sii164.c | 2 +- > drivers/video/fbdev/via/via_aux_vt1631.c | 2 +- > drivers/video/fbdev/via/via_aux_vt1632.c | 2 +- > drivers/video/fbdev/via/via_aux_vt1636.c | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/video/fbdev/via/via_aux_sii164.c b/drivers/video/fbdev/via/via_aux_sii164.c > index ca1b35f..c27f62c 100644 > --- a/drivers/video/fbdev/via/via_aux_sii164.c > +++ b/drivers/video/fbdev/via/via_aux_sii164.c > @@ -36,7 +36,7 @@ static void probe(struct via_aux_bus *bus, u8 addr) > .name = name}; > /* check vendor id and device id */ > const u8 id[] = {0x01, 0x00, 0x06, 0x00}, len = ARRAY_SIZE(id); > - u8 tmp[len]; > + u8 tmp[ARRAY_SIZE(id)]; > > if (!via_aux_read(&drv, 0x00, tmp, len) || memcmp(id, tmp, len)) > return; > diff --git a/drivers/video/fbdev/via/via_aux_vt1631.c b/drivers/video/fbdev/via/via_aux_vt1631.c > index 06e742f..32978a0 100644 > --- a/drivers/video/fbdev/via/via_aux_vt1631.c > +++ b/drivers/video/fbdev/via/via_aux_vt1631.c > @@ -36,7 +36,7 @@ void via_aux_vt1631_probe(struct via_aux_bus *bus) > .name = name}; > /* check vendor id and device id */ > const u8 id[] = {0x06, 0x11, 0x91, 0x31}, len = ARRAY_SIZE(id); > - u8 tmp[len]; > + u8 tmp[ARRAY_SIZE(id)]; > > if (!via_aux_read(&drv, 0x00, tmp, len) || memcmp(id, tmp, len)) > return; > diff --git a/drivers/video/fbdev/via/via_aux_vt1632.c b/drivers/video/fbdev/via/via_aux_vt1632.c > index d24f4cd..cec8cc4 100644 > --- a/drivers/video/fbdev/via/via_aux_vt1632.c > +++ b/drivers/video/fbdev/via/via_aux_vt1632.c > @@ -36,7 +36,7 @@ static void probe(struct via_aux_bus *bus, u8 addr) > .name = name}; > /* check vendor id and device id */ > const u8 id[] = {0x06, 0x11, 0x92, 0x31}, len = ARRAY_SIZE(id); > - u8 tmp[len]; > + u8 tmp[ARRAY_SIZE(id)]; > > if (!via_aux_read(&drv, 0x00, tmp, len) || memcmp(id, tmp, len)) > return; > diff --git a/drivers/video/fbdev/via/via_aux_vt1636.c b/drivers/video/fbdev/via/via_aux_vt1636.c > index 9e015c1..2b10bc2 100644 > --- a/drivers/video/fbdev/via/via_aux_vt1636.c > +++ b/drivers/video/fbdev/via/via_aux_vt1636.c > @@ -36,7 +36,7 @@ void via_aux_vt1636_probe(struct via_aux_bus *bus) > .name = name}; > /* check vendor id and device id */ > const u8 id[] = {0x06, 0x11, 0x45, 0x33}, len = ARRAY_SIZE(id); > - u8 tmp[len]; > + u8 tmp[ARRAY_SIZE(id)]; > > if (!via_aux_read(&drv, 0x00, tmp, len) || memcmp(id, tmp, len)) > return; > -- > 2.7.4 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Engestrom Date: Fri, 09 Mar 2018 10:59:40 +0000 Subject: Re: [PATCH] video: fbdev: via: remove VLA usage Message-Id: <20180309105940.22hd2uy2mv7wahzb@imgtec.com> List-Id: References: <20180308173949.GA19305@embeddedgus> In-Reply-To: <20180308173949.GA19305@embeddedgus> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "Gustavo A. R. Silva" Cc: linux-fbdev@vger.kernel.org, Kees Cook , kernel-hardening@lists.openwall.com, Bartlomiej Zolnierkiewicz , Emil Velikov , Florian Tobias Schandinat , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" On Thursday, 2018-03-08 11:39:49 -0600, Gustavo A. R. Silva wrote: > In preparation to enabling -Wvla, remove VLA usage. > > Also, fixed as part of the directive to remove all VLAs from > the kernel: https://lkml.org/lkml/2018/3/7/621 > > Signed-off-by: Gustavo A. R. Silva Sorry for my reply on v1, I missed that Emil already replied to another post of the same patch (side note on that, making use of `-vX` and `--in-reply-to` helps track the evolution of patches) This looks good to me: Reviewed-by: Eric Engestrom > --- > drivers/video/fbdev/via/via_aux_sii164.c | 2 +- > drivers/video/fbdev/via/via_aux_vt1631.c | 2 +- > drivers/video/fbdev/via/via_aux_vt1632.c | 2 +- > drivers/video/fbdev/via/via_aux_vt1636.c | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/video/fbdev/via/via_aux_sii164.c b/drivers/video/fbdev/via/via_aux_sii164.c > index ca1b35f..c27f62c 100644 > --- a/drivers/video/fbdev/via/via_aux_sii164.c > +++ b/drivers/video/fbdev/via/via_aux_sii164.c > @@ -36,7 +36,7 @@ static void probe(struct via_aux_bus *bus, u8 addr) > .name = name}; > /* check vendor id and device id */ > const u8 id[] = {0x01, 0x00, 0x06, 0x00}, len = ARRAY_SIZE(id); > - u8 tmp[len]; > + u8 tmp[ARRAY_SIZE(id)]; > > if (!via_aux_read(&drv, 0x00, tmp, len) || memcmp(id, tmp, len)) > return; > diff --git a/drivers/video/fbdev/via/via_aux_vt1631.c b/drivers/video/fbdev/via/via_aux_vt1631.c > index 06e742f..32978a0 100644 > --- a/drivers/video/fbdev/via/via_aux_vt1631.c > +++ b/drivers/video/fbdev/via/via_aux_vt1631.c > @@ -36,7 +36,7 @@ void via_aux_vt1631_probe(struct via_aux_bus *bus) > .name = name}; > /* check vendor id and device id */ > const u8 id[] = {0x06, 0x11, 0x91, 0x31}, len = ARRAY_SIZE(id); > - u8 tmp[len]; > + u8 tmp[ARRAY_SIZE(id)]; > > if (!via_aux_read(&drv, 0x00, tmp, len) || memcmp(id, tmp, len)) > return; > diff --git a/drivers/video/fbdev/via/via_aux_vt1632.c b/drivers/video/fbdev/via/via_aux_vt1632.c > index d24f4cd..cec8cc4 100644 > --- a/drivers/video/fbdev/via/via_aux_vt1632.c > +++ b/drivers/video/fbdev/via/via_aux_vt1632.c > @@ -36,7 +36,7 @@ static void probe(struct via_aux_bus *bus, u8 addr) > .name = name}; > /* check vendor id and device id */ > const u8 id[] = {0x06, 0x11, 0x92, 0x31}, len = ARRAY_SIZE(id); > - u8 tmp[len]; > + u8 tmp[ARRAY_SIZE(id)]; > > if (!via_aux_read(&drv, 0x00, tmp, len) || memcmp(id, tmp, len)) > return; > diff --git a/drivers/video/fbdev/via/via_aux_vt1636.c b/drivers/video/fbdev/via/via_aux_vt1636.c > index 9e015c1..2b10bc2 100644 > --- a/drivers/video/fbdev/via/via_aux_vt1636.c > +++ b/drivers/video/fbdev/via/via_aux_vt1636.c > @@ -36,7 +36,7 @@ void via_aux_vt1636_probe(struct via_aux_bus *bus) > .name = name}; > /* check vendor id and device id */ > const u8 id[] = {0x06, 0x11, 0x45, 0x33}, len = ARRAY_SIZE(id); > - u8 tmp[len]; > + u8 tmp[ARRAY_SIZE(id)]; > > if (!via_aux_read(&drv, 0x00, tmp, len) || memcmp(id, tmp, len)) > return; > -- > 2.7.4 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Engestrom Subject: Re: [PATCH] video: fbdev: via: remove VLA usage Date: Fri, 9 Mar 2018 10:59:40 +0000 Message-ID: <20180309105940.22hd2uy2mv7wahzb@imgtec.com> References: <20180308173949.GA19305@embeddedgus> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mailapp01.imgtec.com (mailapp01.imgtec.com [195.59.15.196]) by gabe.freedesktop.org (Postfix) with ESMTP id 60C146EB94 for ; Fri, 9 Mar 2018 10:59:42 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20180308173949.GA19305@embeddedgus> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: "Gustavo A. R. Silva" Cc: linux-fbdev@vger.kernel.org, Kees Cook , kernel-hardening@lists.openwall.com, Bartlomiej Zolnierkiewicz , Emil Velikov , Florian Tobias Schandinat , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" List-Id: dri-devel@lists.freedesktop.org T24gVGh1cnNkYXksIDIwMTgtMDMtMDggMTE6Mzk6NDkgLTA2MDAsIEd1c3Rhdm8gQS4gUi4gU2ls dmEgd3JvdGU6Cj4gSW4gcHJlcGFyYXRpb24gdG8gZW5hYmxpbmcgLVd2bGEsIHJlbW92ZSBWTEEg dXNhZ2UuCj4gCj4gQWxzbywgZml4ZWQgYXMgcGFydCBvZiB0aGUgZGlyZWN0aXZlIHRvIHJlbW92 ZSBhbGwgVkxBcyBmcm9tCj4gdGhlIGtlcm5lbDogaHR0cHM6Ly9sa21sLm9yZy9sa21sLzIwMTgv My83LzYyMQo+IAo+IFNpZ25lZC1vZmYtYnk6IEd1c3Rhdm8gQS4gUi4gU2lsdmEgPGd1c3Rhdm9A ZW1iZWRkZWRvci5jb20+CgpTb3JyeSBmb3IgbXkgcmVwbHkgb24gdjEsIEkgbWlzc2VkIHRoYXQg RW1pbCBhbHJlYWR5IHJlcGxpZWQgdG8gYW5vdGhlcgpwb3N0IG9mIHRoZSBzYW1lIHBhdGNoIChz aWRlIG5vdGUgb24gdGhhdCwgbWFraW5nIHVzZSBvZiBgLXZYYCBhbmQKYC0taW4tcmVwbHktdG9g IGhlbHBzIHRyYWNrIHRoZSBldm9sdXRpb24gb2YgcGF0Y2hlcykKClRoaXMgbG9va3MgZ29vZCB0 byBtZToKUmV2aWV3ZWQtYnk6IEVyaWMgRW5nZXN0cm9tIDxlcmljLmVuZ2VzdHJvbUBpbWd0ZWMu Y29tPgoKPiAtLS0KPiAgZHJpdmVycy92aWRlby9mYmRldi92aWEvdmlhX2F1eF9zaWkxNjQuYyB8 IDIgKy0KPiAgZHJpdmVycy92aWRlby9mYmRldi92aWEvdmlhX2F1eF92dDE2MzEuYyB8IDIgKy0K PiAgZHJpdmVycy92aWRlby9mYmRldi92aWEvdmlhX2F1eF92dDE2MzIuYyB8IDIgKy0KPiAgZHJp dmVycy92aWRlby9mYmRldi92aWEvdmlhX2F1eF92dDE2MzYuYyB8IDIgKy0KPiAgNCBmaWxlcyBj aGFuZ2VkLCA0IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvdmlkZW8vZmJkZXYvdmlhL3ZpYV9hdXhfc2lpMTY0LmMgYi9kcml2ZXJzL3ZpZGVv L2ZiZGV2L3ZpYS92aWFfYXV4X3NpaTE2NC5jCj4gaW5kZXggY2ExYjM1Zi4uYzI3ZjYyYyAxMDA2 NDQKPiAtLS0gYS9kcml2ZXJzL3ZpZGVvL2ZiZGV2L3ZpYS92aWFfYXV4X3NpaTE2NC5jCj4gKysr IGIvZHJpdmVycy92aWRlby9mYmRldi92aWEvdmlhX2F1eF9zaWkxNjQuYwo+IEBAIC0zNiw3ICsz Niw3IEBAIHN0YXRpYyB2b2lkIHByb2JlKHN0cnVjdCB2aWFfYXV4X2J1cyAqYnVzLCB1OCBhZGRy KQo+ICAJCS5uYW1lCT0JbmFtZX07Cj4gIAkvKiBjaGVjayB2ZW5kb3IgaWQgYW5kIGRldmljZSBp ZCAqLwo+ICAJY29uc3QgdTggaWRbXSA9IHsweDAxLCAweDAwLCAweDA2LCAweDAwfSwgbGVuID0g QVJSQVlfU0laRShpZCk7Cj4gLQl1OCB0bXBbbGVuXTsKPiArCXU4IHRtcFtBUlJBWV9TSVpFKGlk KV07Cj4gIAo+ICAJaWYgKCF2aWFfYXV4X3JlYWQoJmRydiwgMHgwMCwgdG1wLCBsZW4pIHx8IG1l bWNtcChpZCwgdG1wLCBsZW4pKQo+ICAJCXJldHVybjsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy92 aWRlby9mYmRldi92aWEvdmlhX2F1eF92dDE2MzEuYyBiL2RyaXZlcnMvdmlkZW8vZmJkZXYvdmlh L3ZpYV9hdXhfdnQxNjMxLmMKPiBpbmRleCAwNmU3NDJmLi4zMjk3OGEwIDEwMDY0NAo+IC0tLSBh L2RyaXZlcnMvdmlkZW8vZmJkZXYvdmlhL3ZpYV9hdXhfdnQxNjMxLmMKPiArKysgYi9kcml2ZXJz L3ZpZGVvL2ZiZGV2L3ZpYS92aWFfYXV4X3Z0MTYzMS5jCj4gQEAgLTM2LDcgKzM2LDcgQEAgdm9p ZCB2aWFfYXV4X3Z0MTYzMV9wcm9iZShzdHJ1Y3QgdmlhX2F1eF9idXMgKmJ1cykKPiAgCQkubmFt ZQk9CW5hbWV9Owo+ICAJLyogY2hlY2sgdmVuZG9yIGlkIGFuZCBkZXZpY2UgaWQgKi8KPiAgCWNv bnN0IHU4IGlkW10gPSB7MHgwNiwgMHgxMSwgMHg5MSwgMHgzMX0sIGxlbiA9IEFSUkFZX1NJWkUo aWQpOwo+IC0JdTggdG1wW2xlbl07Cj4gKwl1OCB0bXBbQVJSQVlfU0laRShpZCldOwo+ICAKPiAg CWlmICghdmlhX2F1eF9yZWFkKCZkcnYsIDB4MDAsIHRtcCwgbGVuKSB8fCBtZW1jbXAoaWQsIHRt cCwgbGVuKSkKPiAgCQlyZXR1cm47Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvdmlkZW8vZmJkZXYv dmlhL3ZpYV9hdXhfdnQxNjMyLmMgYi9kcml2ZXJzL3ZpZGVvL2ZiZGV2L3ZpYS92aWFfYXV4X3Z0 MTYzMi5jCj4gaW5kZXggZDI0ZjRjZC4uY2VjOGNjNCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3Zp ZGVvL2ZiZGV2L3ZpYS92aWFfYXV4X3Z0MTYzMi5jCj4gKysrIGIvZHJpdmVycy92aWRlby9mYmRl di92aWEvdmlhX2F1eF92dDE2MzIuYwo+IEBAIC0zNiw3ICszNiw3IEBAIHN0YXRpYyB2b2lkIHBy b2JlKHN0cnVjdCB2aWFfYXV4X2J1cyAqYnVzLCB1OCBhZGRyKQo+ICAJCS5uYW1lCT0JbmFtZX07 Cj4gIAkvKiBjaGVjayB2ZW5kb3IgaWQgYW5kIGRldmljZSBpZCAqLwo+ICAJY29uc3QgdTggaWRb XSA9IHsweDA2LCAweDExLCAweDkyLCAweDMxfSwgbGVuID0gQVJSQVlfU0laRShpZCk7Cj4gLQl1 OCB0bXBbbGVuXTsKPiArCXU4IHRtcFtBUlJBWV9TSVpFKGlkKV07Cj4gIAo+ICAJaWYgKCF2aWFf YXV4X3JlYWQoJmRydiwgMHgwMCwgdG1wLCBsZW4pIHx8IG1lbWNtcChpZCwgdG1wLCBsZW4pKQo+ ICAJCXJldHVybjsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy92aWRlby9mYmRldi92aWEvdmlhX2F1 eF92dDE2MzYuYyBiL2RyaXZlcnMvdmlkZW8vZmJkZXYvdmlhL3ZpYV9hdXhfdnQxNjM2LmMKPiBp bmRleCA5ZTAxNWMxLi4yYjEwYmMyIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvdmlkZW8vZmJkZXYv dmlhL3ZpYV9hdXhfdnQxNjM2LmMKPiArKysgYi9kcml2ZXJzL3ZpZGVvL2ZiZGV2L3ZpYS92aWFf YXV4X3Z0MTYzNi5jCj4gQEAgLTM2LDcgKzM2LDcgQEAgdm9pZCB2aWFfYXV4X3Z0MTYzNl9wcm9i ZShzdHJ1Y3QgdmlhX2F1eF9idXMgKmJ1cykKPiAgCQkubmFtZQk9CW5hbWV9Owo+ICAJLyogY2hl Y2sgdmVuZG9yIGlkIGFuZCBkZXZpY2UgaWQgKi8KPiAgCWNvbnN0IHU4IGlkW10gPSB7MHgwNiwg MHgxMSwgMHg0NSwgMHgzM30sIGxlbiA9IEFSUkFZX1NJWkUoaWQpOwo+IC0JdTggdG1wW2xlbl07 Cj4gKwl1OCB0bXBbQVJSQVlfU0laRShpZCldOwo+ICAKPiAgCWlmICghdmlhX2F1eF9yZWFkKCZk cnYsIDB4MDAsIHRtcCwgbGVuKSB8fCBtZW1jbXAoaWQsIHRtcCwgbGVuKSkKPiAgCQlyZXR1cm47 Cj4gLS0gCj4gMi43LjQKPiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwo+IGRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKPiBkcmktZGV2ZWxAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9kcmktZGV2ZWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRl dmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Fri, 9 Mar 2018 10:59:40 +0000 From: Eric Engestrom Subject: Re: [PATCH] video: fbdev: via: remove VLA usage Message-ID: <20180309105940.22hd2uy2mv7wahzb@imgtec.com> References: <20180308173949.GA19305@embeddedgus> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline In-Reply-To: <20180308173949.GA19305@embeddedgus> To: "Gustavo A. R. Silva" Cc: Emil Velikov , Florian Tobias Schandinat , Bartlomiej Zolnierkiewicz , linux-fbdev@vger.kernel.org, Kees Cook , kernel-hardening@lists.openwall.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, "Gustavo A. R. Silva" List-ID: On Thursday, 2018-03-08 11:39:49 -0600, Gustavo A. R. Silva wrote: > In preparation to enabling -Wvla, remove VLA usage. > > Also, fixed as part of the directive to remove all VLAs from > the kernel: https://lkml.org/lkml/2018/3/7/621 > > Signed-off-by: Gustavo A. R. Silva Sorry for my reply on v1, I missed that Emil already replied to another post of the same patch (side note on that, making use of `-vX` and `--in-reply-to` helps track the evolution of patches) This looks good to me: Reviewed-by: Eric Engestrom > --- > drivers/video/fbdev/via/via_aux_sii164.c | 2 +- > drivers/video/fbdev/via/via_aux_vt1631.c | 2 +- > drivers/video/fbdev/via/via_aux_vt1632.c | 2 +- > drivers/video/fbdev/via/via_aux_vt1636.c | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/video/fbdev/via/via_aux_sii164.c b/drivers/video/fbdev/via/via_aux_sii164.c > index ca1b35f..c27f62c 100644 > --- a/drivers/video/fbdev/via/via_aux_sii164.c > +++ b/drivers/video/fbdev/via/via_aux_sii164.c > @@ -36,7 +36,7 @@ static void probe(struct via_aux_bus *bus, u8 addr) > .name = name}; > /* check vendor id and device id */ > const u8 id[] = {0x01, 0x00, 0x06, 0x00}, len = ARRAY_SIZE(id); > - u8 tmp[len]; > + u8 tmp[ARRAY_SIZE(id)]; > > if (!via_aux_read(&drv, 0x00, tmp, len) || memcmp(id, tmp, len)) > return; > diff --git a/drivers/video/fbdev/via/via_aux_vt1631.c b/drivers/video/fbdev/via/via_aux_vt1631.c > index 06e742f..32978a0 100644 > --- a/drivers/video/fbdev/via/via_aux_vt1631.c > +++ b/drivers/video/fbdev/via/via_aux_vt1631.c > @@ -36,7 +36,7 @@ void via_aux_vt1631_probe(struct via_aux_bus *bus) > .name = name}; > /* check vendor id and device id */ > const u8 id[] = {0x06, 0x11, 0x91, 0x31}, len = ARRAY_SIZE(id); > - u8 tmp[len]; > + u8 tmp[ARRAY_SIZE(id)]; > > if (!via_aux_read(&drv, 0x00, tmp, len) || memcmp(id, tmp, len)) > return; > diff --git a/drivers/video/fbdev/via/via_aux_vt1632.c b/drivers/video/fbdev/via/via_aux_vt1632.c > index d24f4cd..cec8cc4 100644 > --- a/drivers/video/fbdev/via/via_aux_vt1632.c > +++ b/drivers/video/fbdev/via/via_aux_vt1632.c > @@ -36,7 +36,7 @@ static void probe(struct via_aux_bus *bus, u8 addr) > .name = name}; > /* check vendor id and device id */ > const u8 id[] = {0x06, 0x11, 0x92, 0x31}, len = ARRAY_SIZE(id); > - u8 tmp[len]; > + u8 tmp[ARRAY_SIZE(id)]; > > if (!via_aux_read(&drv, 0x00, tmp, len) || memcmp(id, tmp, len)) > return; > diff --git a/drivers/video/fbdev/via/via_aux_vt1636.c b/drivers/video/fbdev/via/via_aux_vt1636.c > index 9e015c1..2b10bc2 100644 > --- a/drivers/video/fbdev/via/via_aux_vt1636.c > +++ b/drivers/video/fbdev/via/via_aux_vt1636.c > @@ -36,7 +36,7 @@ void via_aux_vt1636_probe(struct via_aux_bus *bus) > .name = name}; > /* check vendor id and device id */ > const u8 id[] = {0x06, 0x11, 0x45, 0x33}, len = ARRAY_SIZE(id); > - u8 tmp[len]; > + u8 tmp[ARRAY_SIZE(id)]; > > if (!via_aux_read(&drv, 0x00, tmp, len) || memcmp(id, tmp, len)) > return; > -- > 2.7.4 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel