All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] usb: musb: Fix external abort in musb_remove on omap2430
@ 2018-03-08 22:19 ` Merlijn Wajer
  0 siblings, 0 replies; 10+ messages in thread
From: Merlijn Wajer @ 2018-03-08 22:19 UTC (permalink / raw)
  To: b-liu
  Cc: merlijn, ivo.g.dimitrov.75, linux-omap, Greg Kroah-Hartman,
	linux-usb, linux-kernel

This fixes an oops on unbind / module unload (on the musb omap2430
platform).

musb_remove function now calls musb_platform_exit before disabling
runtime pm.

Signed-off-by: Merlijn Wajer <merlijn@wizzup.org>
---
 drivers/usb/musb/musb_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
index e2e95071328a..fb1d88183ea1 100644
--- a/drivers/usb/musb/musb_core.c
+++ b/drivers/usb/musb/musb_core.c
@@ -2474,11 +2474,11 @@ static int musb_remove(struct platform_device *pdev)
 	musb_disable_interrupts(musb);
 	musb_writeb(musb->mregs, MUSB_DEVCTL, 0);
 	spin_unlock_irqrestore(&musb->lock, flags);
+	musb_platform_exit(musb);
 
 	pm_runtime_dont_use_autosuspend(musb->controller);
 	pm_runtime_put_sync(musb->controller);
 	pm_runtime_disable(musb->controller);
-	musb_platform_exit(musb);
 	musb_phy_callback = NULL;
 	if (musb->dma_controller)
 		musb_dma_controller_destroy(musb->dma_controller);
-- 
2.16.2


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [v2] usb: musb: Fix external abort in musb_remove on omap2430
@ 2018-03-08 22:19 ` Merlijn Wajer
  0 siblings, 0 replies; 10+ messages in thread
From: Merlijn Wajer @ 2018-03-08 22:19 UTC (permalink / raw)
  To: b-liu
  Cc: merlijn, ivo.g.dimitrov.75, linux-omap, Greg Kroah-Hartman,
	linux-usb, linux-kernel

This fixes an oops on unbind / module unload (on the musb omap2430
platform).

musb_remove function now calls musb_platform_exit before disabling
runtime pm.

Signed-off-by: Merlijn Wajer <merlijn@wizzup.org>
---
 drivers/usb/musb/musb_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
index e2e95071328a..fb1d88183ea1 100644
--- a/drivers/usb/musb/musb_core.c
+++ b/drivers/usb/musb/musb_core.c
@@ -2474,11 +2474,11 @@ static int musb_remove(struct platform_device *pdev)
 	musb_disable_interrupts(musb);
 	musb_writeb(musb->mregs, MUSB_DEVCTL, 0);
 	spin_unlock_irqrestore(&musb->lock, flags);
+	musb_platform_exit(musb);
 
 	pm_runtime_dont_use_autosuspend(musb->controller);
 	pm_runtime_put_sync(musb->controller);
 	pm_runtime_disable(musb->controller);
-	musb_platform_exit(musb);
 	musb_phy_callback = NULL;
 	if (musb->dma_controller)
 		musb_dma_controller_destroy(musb->dma_controller);

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2] usb: musb: Fix external abort in musb_remove on omap2430
@ 2018-03-09 14:11   ` Bin Liu
  0 siblings, 0 replies; 10+ messages in thread
From: Bin Liu @ 2018-03-09 14:11 UTC (permalink / raw)
  To: Merlijn Wajer
  Cc: ivo.g.dimitrov.75, linux-omap, Greg Kroah-Hartman, linux-usb,
	linux-kernel

Hi,

On Thu, Mar 08, 2018 at 11:19:48PM +0100, Merlijn Wajer wrote:
> This fixes an oops on unbind / module unload (on the musb omap2430
> platform).
> 
> musb_remove function now calls musb_platform_exit before disabling
> runtime pm.
> 
> Signed-off-by: Merlijn Wajer <merlijn@wizzup.org>

Applied. Thanks.

Regards,
-Bin.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [v2] usb: musb: Fix external abort in musb_remove on omap2430
@ 2018-03-09 14:11   ` Bin Liu
  0 siblings, 0 replies; 10+ messages in thread
From: Bin Liu @ 2018-03-09 14:11 UTC (permalink / raw)
  To: Merlijn Wajer
  Cc: ivo.g.dimitrov.75, linux-omap, Greg Kroah-Hartman, linux-usb,
	linux-kernel

Hi,

On Thu, Mar 08, 2018 at 11:19:48PM +0100, Merlijn Wajer wrote:
> This fixes an oops on unbind / module unload (on the musb omap2430
> platform).
> 
> musb_remove function now calls musb_platform_exit before disabling
> runtime pm.
> 
> Signed-off-by: Merlijn Wajer <merlijn@wizzup.org>

Applied. Thanks.

Regards,
-Bin.
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2] usb: musb: Fix external abort in musb_remove on omap2430
@ 2018-03-09 14:11   ` Bin Liu
  0 siblings, 0 replies; 10+ messages in thread
From: Bin Liu @ 2018-03-09 14:11 UTC (permalink / raw)
  To: Merlijn Wajer
  Cc: ivo.g.dimitrov.75, linux-omap, Greg Kroah-Hartman, linux-usb,
	linux-kernel

Hi,

On Thu, Mar 08, 2018 at 11:19:48PM +0100, Merlijn Wajer wrote:
> This fixes an oops on unbind / module unload (on the musb omap2430
> platform).
> 
> musb_remove function now calls musb_platform_exit before disabling
> runtime pm.
> 
> Signed-off-by: Merlijn Wajer <merlijn@wizzup.org>

Applied. Thanks.

Regards,
-Bin.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2] usb: musb: Fix external abort in musb_remove on omap2430
@ 2018-03-12 22:30     ` Merlijn Wajer
  0 siblings, 0 replies; 10+ messages in thread
From: Merlijn Wajer @ 2018-03-12 22:30 UTC (permalink / raw)
  To: Bin Liu, ivo.g.dimitrov.75, linux-omap, Greg Kroah-Hartman,
	linux-usb, linux-kernel


[-- Attachment #1.1: Type: text/plain, Size: 611 bytes --]

Hi Bin,

On 09/03/18 15:11, Bin Liu wrote:
> Hi,
> 
> On Thu, Mar 08, 2018 at 11:19:48PM +0100, Merlijn Wajer wrote:
>> This fixes an oops on unbind / module unload (on the musb omap2430
>> platform).
>>
>> musb_remove function now calls musb_platform_exit before disabling
>> runtime pm.
>>
>> Signed-off-by: Merlijn Wajer <merlijn@wizzup.org>
> 
> Applied. Thanks.

Thank you. Is there any chance that this patch and the vbus patch could
end up in the 4.16-rc series? I was waiting for another rc to see if the
vbus patch would land, but it didn't land with 4.16-rc5.

Cheers,
Merlijn


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [v2] usb: musb: Fix external abort in musb_remove on omap2430
@ 2018-03-12 22:30     ` Merlijn Wajer
  0 siblings, 0 replies; 10+ messages in thread
From: Merlijn Wajer @ 2018-03-12 22:30 UTC (permalink / raw)
  To: Bin Liu, ivo.g.dimitrov.75, linux-omap, Greg Kroah-Hartman,
	linux-usb, linux-kernel

Hi Bin,

On 09/03/18 15:11, Bin Liu wrote:
> Hi,
> 
> On Thu, Mar 08, 2018 at 11:19:48PM +0100, Merlijn Wajer wrote:
>> This fixes an oops on unbind / module unload (on the musb omap2430
>> platform).
>>
>> musb_remove function now calls musb_platform_exit before disabling
>> runtime pm.
>>
>> Signed-off-by: Merlijn Wajer <merlijn@wizzup.org>
> 
> Applied. Thanks.

Thank you. Is there any chance that this patch and the vbus patch could
end up in the 4.16-rc series? I was waiting for another rc to see if the
vbus patch would land, but it didn't land with 4.16-rc5.

Cheers,
Merlijn

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2] usb: musb: Fix external abort in musb_remove on omap2430
@ 2018-03-13 20:11       ` Bin Liu
  0 siblings, 0 replies; 10+ messages in thread
From: Bin Liu @ 2018-03-13 20:11 UTC (permalink / raw)
  To: Merlijn Wajer
  Cc: ivo.g.dimitrov.75, linux-omap, Greg Kroah-Hartman, linux-usb,
	linux-kernel

Hi,

On Mon, Mar 12, 2018 at 11:30:39PM +0100, Merlijn Wajer wrote:
> Hi Bin,
> 
> On 09/03/18 15:11, Bin Liu wrote:
> > Hi,
> > 
> > On Thu, Mar 08, 2018 at 11:19:48PM +0100, Merlijn Wajer wrote:
> >> This fixes an oops on unbind / module unload (on the musb omap2430
> >> platform).
> >>
> >> musb_remove function now calls musb_platform_exit before disabling
> >> runtime pm.
> >>
> >> Signed-off-by: Merlijn Wajer <merlijn@wizzup.org>
> > 
> > Applied. Thanks.
> 
> Thank you. Is there any chance that this patch and the vbus patch could
> end up in the 4.16-rc series? I was waiting for another rc to see if the
> vbus patch would land, but it didn't land with 4.16-rc5.

Those two patches are already in the upstream tree, hopefully they will
be in the v4.16-rc.

Regards,
-Bin.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [v2] usb: musb: Fix external abort in musb_remove on omap2430
@ 2018-03-13 20:11       ` Bin Liu
  0 siblings, 0 replies; 10+ messages in thread
From: Bin Liu @ 2018-03-13 20:11 UTC (permalink / raw)
  To: Merlijn Wajer
  Cc: ivo.g.dimitrov.75, linux-omap, Greg Kroah-Hartman, linux-usb,
	linux-kernel

Hi,

On Mon, Mar 12, 2018 at 11:30:39PM +0100, Merlijn Wajer wrote:
> Hi Bin,
> 
> On 09/03/18 15:11, Bin Liu wrote:
> > Hi,
> > 
> > On Thu, Mar 08, 2018 at 11:19:48PM +0100, Merlijn Wajer wrote:
> >> This fixes an oops on unbind / module unload (on the musb omap2430
> >> platform).
> >>
> >> musb_remove function now calls musb_platform_exit before disabling
> >> runtime pm.
> >>
> >> Signed-off-by: Merlijn Wajer <merlijn@wizzup.org>
> > 
> > Applied. Thanks.
> 
> Thank you. Is there any chance that this patch and the vbus patch could
> end up in the 4.16-rc series? I was waiting for another rc to see if the
> vbus patch would land, but it didn't land with 4.16-rc5.

Those two patches are already in the upstream tree, hopefully they will
be in the v4.16-rc.

Regards,
-Bin.
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2] usb: musb: Fix external abort in musb_remove on omap2430
@ 2018-03-13 20:11       ` Bin Liu
  0 siblings, 0 replies; 10+ messages in thread
From: Bin Liu @ 2018-03-13 20:11 UTC (permalink / raw)
  To: Merlijn Wajer
  Cc: ivo.g.dimitrov.75, linux-omap, Greg Kroah-Hartman, linux-usb,
	linux-kernel

Hi,

On Mon, Mar 12, 2018 at 11:30:39PM +0100, Merlijn Wajer wrote:
> Hi Bin,
> 
> On 09/03/18 15:11, Bin Liu wrote:
> > Hi,
> > 
> > On Thu, Mar 08, 2018 at 11:19:48PM +0100, Merlijn Wajer wrote:
> >> This fixes an oops on unbind / module unload (on the musb omap2430
> >> platform).
> >>
> >> musb_remove function now calls musb_platform_exit before disabling
> >> runtime pm.
> >>
> >> Signed-off-by: Merlijn Wajer <merlijn@wizzup.org>
> > 
> > Applied. Thanks.
> 
> Thank you. Is there any chance that this patch and the vbus patch could
> end up in the 4.16-rc series? I was waiting for another rc to see if the
> vbus patch would land, but it didn't land with 4.16-rc5.

Those two patches are already in the upstream tree, hopefully they will
be in the v4.16-rc.

Regards,
-Bin.

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2018-03-13 20:11 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-08 22:19 [PATCH v2] usb: musb: Fix external abort in musb_remove on omap2430 Merlijn Wajer
2018-03-08 22:19 ` [v2] " Merlijn Wajer
2018-03-09 14:11 ` [PATCH v2] " Bin Liu
2018-03-09 14:11   ` Bin Liu
2018-03-09 14:11   ` [v2] " Bin Liu
2018-03-12 22:30   ` [PATCH v2] " Merlijn Wajer
2018-03-12 22:30     ` [v2] " Merlijn Wajer
2018-03-13 20:11     ` [PATCH v2] " Bin Liu
2018-03-13 20:11       ` Bin Liu
2018-03-13 20:11       ` [v2] " Bin Liu

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.