All of lore.kernel.org
 help / color / mirror / Atom feed
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Joe Perches <joe@perches.com>
Cc: "Hernán Gonzalez" <hernan@vanguardiasur.com.ar>,
	davem@davemloft.net, steven.lin1@broadcom.com,
	arvind.yadav.cs@gmail.com, colin.king@canonical.com,
	raveendra.padasalagi@broadcom.com, ray.jui@broadcom.com,
	scott.branden@broadcom.com, linux-crypto@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] crypto: bcm: Constify *hash_alg_name[]
Date: Fri, 9 Mar 2018 23:04:11 +0800	[thread overview]
Message-ID: <20180309150411.GA13375@gondor.apana.org.au> (raw)
In-Reply-To: <1520606135.26370.9.camel@perches.com>

On Fri, Mar 09, 2018 at 06:35:35AM -0800, Joe Perches wrote:
>
> and likely, as this is a global name, it should
> be something like crypto_hash_alg_name

crypto_ is not a good prefix here.  Perhaps crypto_bcm_.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

  reply	other threads:[~2018-03-09 15:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-27 22:01 [PATCH 1/4] crypto: bcm: Remove unused variable (char *tag_to_hash_idx[]) Hernán Gonzalez
2018-02-27 22:01 ` [PATCH 2/4] crypto: bcm: Move *aead_alg_name[] from spu.c to util.c. Constify too Hernán Gonzalez
2018-02-27 22:01 ` [PATCH 3/4] crypto: bcm: Constify *hash_alg_name[] Hernán Gonzalez
2018-03-09 14:29   ` Herbert Xu
2018-03-09 14:35     ` Joe Perches
2018-03-09 15:04       ` Herbert Xu [this message]
2018-03-09 15:04   ` Kamil Konieczny
2018-02-27 22:01 ` [PATCH 4/4] crypto: bcm: Constify variables in spu2.c Hernán Gonzalez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180309150411.GA13375@gondor.apana.org.au \
    --to=herbert@gondor.apana.org.au \
    --cc=arvind.yadav.cs@gmail.com \
    --cc=colin.king@canonical.com \
    --cc=davem@davemloft.net \
    --cc=hernan@vanguardiasur.com.ar \
    --cc=joe@perches.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=raveendra.padasalagi@broadcom.com \
    --cc=ray.jui@broadcom.com \
    --cc=scott.branden@broadcom.com \
    --cc=steven.lin1@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.