From mboxrd@z Thu Jan 1 00:00:00 1970 From: Herbert Xu Subject: Re: [PATCH 1/2] crypto: talitos - don't persistently map req_ctx->hw_context and req_ctx->buf Date: Fri, 9 Mar 2018 23:17:52 +0800 Message-ID: <20180309151751.GC13567@gondor.apana.org.au> References: <7c934f0788d60bd82fb1cb51d712c9ab1ea7fcb4.1519660621.git.christophe.leroy@c-s.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "David S. Miller" , Horia Geanta , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org To: Christophe Leroy Return-path: Content-Disposition: inline In-Reply-To: <7c934f0788d60bd82fb1cb51d712c9ab1ea7fcb4.1519660621.git.christophe.leroy@c-s.fr> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-crypto.vger.kernel.org On Mon, Feb 26, 2018 at 05:40:04PM +0100, Christophe Leroy wrote: > Commit 49f9783b0cea ("crypto: talitos - do hw_context DMA mapping > outside the requests") introduced a persistent dma mapping of > req_ctx->hw_context > Commit 37b5e8897eb5 ("crypto: talitos - chain in buffered data for ahash > on SEC1") introduced a persistent dma mapping of req_ctx->buf > > As there is no destructor for req_ctx (the request context), the > associated dma handlers where set in ctx (the tfm context). This is > wrong as several hash operations can run with the same ctx. > > This patch removes this persistent mapping. > > Reported-by: Horia Geanta > Fixes: 49f9783b0cea ("crypto: talitos - do hw_context DMA mapping outside the requests") > Fixes: 37b5e8897eb5 ("crypto: talitos - chain in buffered data for ahash on SEC1") > Signed-off-by: Christophe Leroy Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt