From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Fri, 9 Mar 2018 16:26:04 +0100 Subject: [Buildroot] [PATCH v4 1/4] imx-mkimage: new package In-Reply-To: References: <1520065060-20046-1-git-send-email-karl.erik.larsson@gmail.com> <1520065060-20046-2-git-send-email-karl.erik.larsson@gmail.com> <20180303164706.0084b2ec@windsurf.home> Message-ID: <20180309162604.73d98870@windsurf> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hello, On Sat, 3 Mar 2018 19:46:34 +0100, Erik Larsson wrote: > > I'm not a big fan of the fact that this host package not does not > > install any host tool, but instead post-processes images created by > > other packages. > > > > Would it be possible for this package to just install host tools, and > > then have a post-image script that uses these host tools to provide the > > final flash.bin image ? > > This first version if this patch-serie did sort of that. It build and > installed host tools. And then they were used in post-image.sh. But > after a comments/suggestion from Baruch I got encouraged do it this > way. This solution is much clearer when reading the code then the > first version, but maybe with the drawback of this host-package not > really being a host-package as you stated. If you compare this > solution with the first you will see that there is a pretty convoluted > solution for doing parts that are in the Makefile och imx-mkimage. The > main problem here may be the fact that NXP put stuff in there Makefile > that rally doesn't have anything with the creation of the tool. I think I really prefer the approach where the imx-mkimage package only installs a host tool, and then a post-image script that uses the host tool installed by imx-mkimage to post-process the images, and generate the final bootloader. Best regards, Thomas -- Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering http://bootlin.com