From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932177AbeCIQ2d (ORCPT ); Fri, 9 Mar 2018 11:28:33 -0500 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:38088 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751151AbeCIQ2c (ORCPT ); Fri, 9 Mar 2018 11:28:32 -0500 Date: Fri, 9 Mar 2018 17:28:28 +0100 From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: Jiri Olsa , lkml , Ingo Molnar , Namhyung Kim , David Ahern , Alexander Shishkin , Peter Zijlstra Subject: Re: [PATCH 9/9] perf c2c report: Add cacheline address count column Message-ID: <20180309162828.GA16890@krava> References: <20180309101442.9224-1-jolsa@kernel.org> <20180309101442.9224-10-jolsa@kernel.org> <20180309145643.GA8347@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180309145643.GA8347@kernel.org> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 09, 2018 at 11:56:43AM -0300, Arnaldo Carvalho de Melo wrote: > Em Fri, Mar 09, 2018 at 11:14:42AM +0100, Jiri Olsa escreveu: > > Adding the 'PA cnt' column grouped under data cacheline address. > > > > It shows how many times the physical addresses changed for the > > hist entry. It does not show the number of different physical > > addresses for entry, because we don't store those. We only track > > the number of times we got different address than we currently > > hold, which is not expensive and gives similar info. > > > > $ perf c2c report --stdio > > > > # ----------- Cacheline ---------- Total Tot ----- LLC Load Hitm ----- > > # Index Address Node PA cnt records Hitm Total Lcl Rmt > > # ..... .................. .... ...... ....... ....... ....... ....... ....... > > # > > > I'm adding this to the docs, ack? nope.. those fields are c2c report only.. hardcoded I'm preparing a change to share c2c fields with the general report.. should come with other perf mem changes later jirka > > diff --git a/tools/perf/Documentation/perf-report.txt b/tools/perf/Documentation/perf-report.txt > index cba16d8a970e..f4a280428e28 100644 > --- a/tools/perf/Documentation/perf-report.txt > +++ b/tools/perf/Documentation/perf-report.txt > @@ -127,7 +127,7 @@ OPTIONS > > If the --mem-mode option is used, the following sort keys are also available > (incompatible with --branch-stack): > - symbol_daddr, dso_daddr, locked, tlb, mem, snoop, dcacheline. > + symbol_daddr, dso_daddr, locked, tlb, mem, snoop, dcacheline, dcacheline_count. > > - symbol_daddr: name of data symbol being executed on at the time of sample > - dso_daddr: name of library or module containing the data being executed > @@ -137,6 +137,7 @@ OPTIONS > - mem: type of memory access for the data at the time of the sample > - snoop: type of snoop (if any) for the data at the time of the sample > - dcacheline: the cacheline the data address is on at the time of the sample > + - dcacheline_count: the number of physical addresses sampled for this dcacheline > - phys_daddr: physical address of data being executed on at the time of sample > > And the default sort keys are changed to local_weight, mem, sym, dso,