From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: Re: [PATCH v4 08/16] xen/mm: Drop the parameter mfn from populate_pt_range Date: Fri, 9 Mar 2018 17:29:57 +0000 Message-ID: <20180309172957.lbzthnrhc4wz4t4s@citrix.com> References: <20180221140259.29360-9-julien.grall@arm.com> <20180222163505.enzgrp4alo7pibeh@citrix.com> <445bc932-044d-eacf-a487-0410e8fdb22d@arm.com> <20180222165124.zaufci7dew2dp23n@citrix.com> <5A9973D402000078001ADDA8@prv-mh.provo.novell.com> <5A9D5B8F02000078001AE8DF@prv-mh.provo.novell.com> <403b56c9-f337-9330-3f6a-5e5f4a69a238@arm.com> <5A9D647C02000078001AE959@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <5A9D647C02000078001AE959@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Jan Beulich Cc: Tim Deegan , Stefano Stabellini , Wei Liu , George Dunlap , Andrew Cooper , Ian Jackson , xen-devel@lists.xen.org, Julien Grall List-Id: xen-devel@lists.xenproject.org T24gTW9uLCBNYXIgMDUsIDIwMTggYXQgMDc6Mzg6MzZBTSAtMDcwMCwgSmFuIEJldWxpY2ggd3Jv dGU6Cj4gPj4+IE9uIDA1LjAzLjE4IGF0IDE1OjExLCA8anVsaWVuLmdyYWxsQGFybS5jb20+IHdy b3RlOgo+ID4gT24gMDUvMDMvMTggMTQ6MDAsIEphbiBCZXVsaWNoIHdyb3RlOgo+ID4+Pj4+IE9u IDA1LjAzLjE4IGF0IDE0OjQzLCA8anVsaWVuLmdyYWxsQGFybS5jb20+IHdyb3RlOgo+ID4+PiBB bnl3YXksIEkgZG9uJ3QgaGF2ZSBtdWNoIGtub3dsZWRnZSBvbiB0aGUgeDg2IHRvIG1ha2UgdGhl IG1vZGlmaWNhdGlvbgo+ID4+PiB0aGF0IHlvdSBzdWdnZXN0ZWQuIFNvIEkgYW0gZ29pbmcgdG8g cmV2ZXJ0IHRvIF9tZm4oMCkgZm9yIHg4Ni4KPiA+PiAKPiA+PiBJJ2QgcHJlZmVyIGlmIHlvdSBk aWRuJ3QsIGJ1dCB3ZWxsLCBpdCdsbCBiZSBvbmUgb2YgdXMgdG8gY2xlYW4gaXQgdXAKPiA+PiB0 aGVuLgo+ID4gSSBjYW4ga2VlcCBhcyBJTlZBTElEX01GTi4gQnV0IHRoZW4gZWl0aGVyIHlvdSBv ciBBbmRyZXcgKG9yIGFueW9uZSB4ODYgCj4gPiBmb2xrcykgd291bGQgaGF2ZSB0byBwcm92aWRl IHRoZSBwYXRjaCB0byBza2lwIGluY3JlbWVudGluZyBpbnZhbGlkIE1GTiAKPiA+IChpZiBJIHVu ZGVyc3Rvb2QgY29ycmVjdGx5IHlvdXIgcmVxdWVzdCkuCj4gCj4gU2lnaCAtIHRoaXMgc2hvdWxk IGdvIHRvZ2V0aGVyIGltby4gV2hpbGUgd3JvbmdseSBpbmNyZW1lbnRpbmcgZnJvbQo+IHplcm8g d2FzIGJhZCwgd3JvbmdseSB3cmFwcGluZyBmcm9tIElOVkFMSURfTUZOIG1ha2VzIHRoaW5ncwo+ IHdvcnNlLgo+IAoKVHJ5IHRoaXMgcGF0Y2g/CgotLS04PC0tLQpGcm9tIDhmMDAyNGM2OTBjNzM2 ZDE3YWRkZTBmYTc2NWNiYmY2ZmEyODQ2ZGMgTW9uIFNlcCAxNyAwMDowMDowMCAyMDAxCkZyb206 IFdlaSBMaXUgPHdlaS5saXUyQGNpdHJpeC5jb20+CkRhdGU6IEZyaSwgOSBNYXIgMjAxOCAxNzoy MDoxNCArMDAwMApTdWJqZWN0OiBbUEFUQ0hdIHg4Ni9tbTogc2tpcCBpbmNyZW1lbnRpbmcgbWZu IGlmIGl0IGlzIG5vdCBhIHZhbGlkIG1mbgoKVGhlIGZ1bmN0aW9uIGlzIGNhbGxlZCB0byBmaWxs IGluIHBhZ2UgdGFibGUgZW50cmllcyBpbgpwb3B1bGF0ZV9wdF9yYW5nZS4gU2tpcCBpbmNyZW1l bnRpbmcgbWZuIGlmIGl0IGlzIGludmFsaWQuCgpTaWduZWQtb2ZmLWJ5OiBXZWkgTGl1IDx3ZWku bGl1MkBjaXRyaXguY29tPgotLS0KIHhlbi9hcmNoL3g4Ni9tbS5jIHwgMTUgKysrKysrKysrKy0t LS0tCiAxIGZpbGUgY2hhbmdlZCwgMTAgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkKCmRp ZmYgLS1naXQgYS94ZW4vYXJjaC94ODYvbW0uYyBiL3hlbi9hcmNoL3g4Ni9tbS5jCmluZGV4IDli NTU5NDQ4YTcuLjVmNTU3N2M3YzIgMTAwNjQ0Ci0tLSBhL3hlbi9hcmNoL3g4Ni9tbS5jCisrKyBi L3hlbi9hcmNoL3g4Ni9tbS5jCkBAIC00NzMxLDcgKzQ3MzEsOCBAQCBpbnQgbWFwX3BhZ2VzX3Rv X3hlbigKICAgICAgICAgICAgIH0KIAogICAgICAgICAgICAgdmlydCAgICArPSAxVUwgPDwgTDNf UEFHRVRBQkxFX1NISUZUOwotICAgICAgICAgICAgbWZuICAgICArPSAxVUwgPDwgKEwzX1BBR0VU QUJMRV9TSElGVCAtIFBBR0VfU0hJRlQpOworICAgICAgICAgICAgaWYgKCAhbWZuX2VxKF9tZm4o bWZuKSwgSU5WQUxJRF9NRk4pICkKKyAgICAgICAgICAgICAgICBtZm4gKz0gMVVMIDw8IChMM19Q QUdFVEFCTEVfU0hJRlQgLSBQQUdFX1NISUZUKTsKICAgICAgICAgICAgIG5yX21mbnMgLT0gMVVM IDw8IChMM19QQUdFVEFCTEVfU0hJRlQgLSBQQUdFX1NISUZUKTsKICAgICAgICAgICAgIGNvbnRp bnVlOwogICAgICAgICB9CkBAIC00NzU2LDcgKzQ3NTcsOCBAQCBpbnQgbWFwX3BhZ2VzX3RvX3hl bigKICAgICAgICAgICAgICAgICBpZiAoIGkgPiBucl9tZm5zICkKICAgICAgICAgICAgICAgICAg ICAgaSA9IG5yX21mbnM7CiAgICAgICAgICAgICAgICAgdmlydCAgICArPSBpIDw8IFBBR0VfU0hJ RlQ7Ci0gICAgICAgICAgICAgICAgbWZuICAgICArPSBpOworICAgICAgICAgICAgICAgIGlmICgg IW1mbl9lcShfbWZuKG1mbiksIElOVkFMSURfTUZOKSApCisgICAgICAgICAgICAgICAgICAgIG1m biArPSBpOwogICAgICAgICAgICAgICAgIG5yX21mbnMgLT0gaTsKICAgICAgICAgICAgICAgICBj b250aW51ZTsKICAgICAgICAgICAgIH0KQEAgLTQ4MjQsNyArNDgyNiw4IEBAIGludCBtYXBfcGFn ZXNfdG9feGVuKAogICAgICAgICAgICAgfQogCiAgICAgICAgICAgICB2aXJ0ICAgICs9IDFVTCA8 PCBMMl9QQUdFVEFCTEVfU0hJRlQ7Ci0gICAgICAgICAgICBtZm4gICAgICs9IDFVTCA8PCBQQUdF VEFCTEVfT1JERVI7CisgICAgICAgICAgICBpZiAoICFtZm5fZXEoX21mbihtZm4pLCBJTlZBTElE X01GTikgKQorICAgICAgICAgICAgICAgIG1mbiArPSAxVUwgPDwgUEFHRVRBQkxFX09SREVSOwog ICAgICAgICAgICAgbnJfbWZucyAtPSAxVUwgPDwgUEFHRVRBQkxFX09SREVSOwogICAgICAgICB9 CiAgICAgICAgIGVsc2UKQEAgLTQ4NTMsNyArNDg1Niw4IEBAIGludCBtYXBfcGFnZXNfdG9feGVu KAogICAgICAgICAgICAgICAgICAgICBpZiAoIGkgPiBucl9tZm5zICkKICAgICAgICAgICAgICAg ICAgICAgICAgIGkgPSBucl9tZm5zOwogICAgICAgICAgICAgICAgICAgICB2aXJ0ICAgICs9IGkg PDwgTDFfUEFHRVRBQkxFX1NISUZUOwotICAgICAgICAgICAgICAgICAgICBtZm4gICAgICs9IGk7 CisgICAgICAgICAgICAgICAgICAgIGlmICggIW1mbl9lcShfbWZuKG1mbiksIElOVkFMSURfTUZO KSApCisgICAgICAgICAgICAgICAgICAgICAgICBtZm4gKz0gaTsKICAgICAgICAgICAgICAgICAg ICAgbnJfbWZucyAtPSBpOwogICAgICAgICAgICAgICAgICAgICBnb3RvIGNoZWNrX2wzOwogICAg ICAgICAgICAgICAgIH0KQEAgLTQ4OTgsNyArNDkwMiw4IEBAIGludCBtYXBfcGFnZXNfdG9feGVu KAogICAgICAgICAgICAgfQogCiAgICAgICAgICAgICB2aXJ0ICAgICs9IDFVTCA8PCBMMV9QQUdF VEFCTEVfU0hJRlQ7Ci0gICAgICAgICAgICBtZm4gICAgICs9IDFVTDsKKyAgICAgICAgICAgIGlm ICggIW1mbl9lcShfbWZuKG1mbiksIElOVkFMSURfTUZOKSApCisgICAgICAgICAgICAgICAgbWZu ICs9IDFVTDsKICAgICAgICAgICAgIG5yX21mbnMgLT0gMVVMOwogCiAgICAgICAgICAgICBpZiAo IChmbGFncyA9PSBQQUdFX0hZUEVSVklTT1IpICYmCi0tIAoyLjExLjAKCgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0 Clhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRwczovL2xpc3RzLnhlbnByb2plY3Qu b3JnL21haWxtYW4vbGlzdGluZm8veGVuLWRldmVs