All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@jic23.retrosnub.co.uk>
To: David Veenstra <davidjulianveenstra@gmail.com>
Cc: lars@metafoo.de, linux-iio@vger.kernel.org
Subject: Re: [PATCH] Staging: iio: ad7746: Adjust arguments to match open parenthesis
Date: Sat, 10 Mar 2018 15:23:01 +0000	[thread overview]
Message-ID: <20180310152301.3f582a04@archlinux> (raw)
In-Reply-To: <20180308094813.GA11596@zenbook-arch>

On Thu, 8 Mar 2018 10:48:13 +0100
David Veenstra <davidjulianveenstra@gmail.com> wrote:

> This patch clears all checkpatch.pl CHECKS, about alignment not matching
> open parenthesis, whenever it is possible without going beyond 80 columns.
> 
> Signed-off-by: David Veenstra <davidjulianveenstra@gmail.com>
There is a lot of deep indenting in this driver which will have made
this harder than it often is.

Anyhow the ones you have done make sense.

Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.

Thanks,

Jonathan

> ---
>  drivers/staging/iio/cdc/ad7746.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/iio/cdc/ad7746.c b/drivers/staging/iio/cdc/ad7746.c
> index c4a864725376..4882dbc81c53 100644
> --- a/drivers/staging/iio/cdc/ad7746.c
> +++ b/drivers/staging/iio/cdc/ad7746.c
> @@ -217,7 +217,7 @@ static const unsigned char ad7746_cap_filter_rate_table[][2] = {
>  };
>  
>  static int ad7746_select_channel(struct iio_dev *indio_dev,
> -			    struct iio_chan_spec const *chan)
> +				 struct iio_chan_spec const *chan)
>  {
>  	struct ad7746_chip_info *chip = iio_priv(indio_dev);
>  	int ret, delay, idx;
> @@ -487,13 +487,13 @@ static int ad7746_write_raw(struct iio_dev *indio_dev,
>  			AD7746_CAPDAC_DACP(val) | AD7746_CAPDAC_DACEN : 0;
>  
>  		ret = i2c_smbus_write_byte_data(chip->client,
> -			AD7746_REG_CAPDACA,
> -			chip->capdac[chan->channel][0]);
> +						AD7746_REG_CAPDACA,
> +						chip->capdac[chan->channel][0]);
>  		if (ret < 0)
>  			goto out;
>  		ret = i2c_smbus_write_byte_data(chip->client,
> -			AD7746_REG_CAPDACB,
> -			chip->capdac[chan->channel][1]);
> +						AD7746_REG_CAPDACB,
> +						chip->capdac[chan->channel][1]);
>  		if (ret < 0)
>  			goto out;
>  
> @@ -675,7 +675,7 @@ static const struct iio_info ad7746_info = {
>   */
>  
>  static int ad7746_probe(struct i2c_client *client,
> -		const struct i2c_device_id *id)
> +			const struct i2c_device_id *id)
>  {
>  	struct ad7746_platform_data *pdata = client->dev.platform_data;
>  	struct ad7746_chip_info *chip;


      reply	other threads:[~2018-03-10 15:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-08  9:48 [PATCH] Staging: iio: ad7746: Adjust arguments to match open parenthesis David Veenstra
2018-03-10 15:23 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180310152301.3f582a04@archlinux \
    --to=jic23@jic23.retrosnub.co.uk \
    --cc=davidjulianveenstra@gmail.com \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.