All of lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4 1/4] imx-mkimage: new package
Date: Sat, 10 Mar 2018 21:58:17 +0200	[thread overview]
Message-ID: <20180310195817.x4ipzhx47hgeoaja@tarshish> (raw)
In-Reply-To: <20180309162604.73d98870@windsurf>

Hi Thomas,

On Fri, Mar 09, 2018 at 04:26:04PM +0100, Thomas Petazzoni wrote:
> On Sat, 3 Mar 2018 19:46:34 +0100, Erik Larsson wrote:
> 
> > > I'm not a big fan of the fact that this host package not does not
> > > install any host tool, but instead post-processes images created by
> > > other packages.
> > >
> > > Would it be possible for this package to just install host tools, and
> > > then have a post-image script that uses these host tools to provide the
> > > final flash.bin image ?  
> > 
> > This first version if this patch-serie did sort of that. It build and
> > installed host tools. And then they were used in post-image.sh. But
> > after a comments/suggestion from Baruch I got encouraged do it this
> > way. This solution is much clearer when reading the code then the
> > first version, but maybe with the drawback of this host-package not
> > really being a host-package as you stated. If you compare this
> > solution with the first you will see that there is a pretty convoluted
> > solution for doing parts that are in the Makefile och imx-mkimage. The
> > main problem here may be the fact that NXP put stuff in there Makefile
> > that rally doesn't have anything with the creation of the tool.
> 
> I think I really prefer the approach where the imx-mkimage package only
> installs a host tool, and then a post-image script that uses the host
> tool installed by imx-mkimage to post-process the images, and generate
> the final bootloader.

Erik has been quick to respin the series. The result is at

  http://lists.busybox.net/pipermail/buildroot/2018-March/215611.html

(not on patchwork). Now the gen_imx8_boot() shell function in the post image 
script duplicates the logic from the imx-mkimage Makefile to generate the boot 
image. Do you find this better?

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

  reply	other threads:[~2018-03-10 19:58 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-03  8:17 [Buildroot] [PATCH v4 0/4] Initial support for NXP iMX8 (imx8mq-evk) Erik Larsson
2018-03-03  8:17 ` [Buildroot] [PATCH v4 1/4] imx-mkimage: new package Erik Larsson
2018-03-03 15:47   ` Thomas Petazzoni
2018-03-03 18:46     ` Erik Larsson
2018-03-09 15:26       ` Thomas Petazzoni
2018-03-10 19:58         ` Baruch Siach [this message]
2018-03-03  8:17 ` [Buildroot] [PATCH v4 2/4] freescale-imx: add config option for i.MX8M Erik Larsson
2018-03-03  8:17 ` [Buildroot] [PATCH v4 3/4] firmware-imx: add support for iMX8M firmware Erik Larsson
2018-03-03  8:17 ` [Buildroot] [PATCH v4 4/4] configs/freescale_imx8mqevk: new defconfig Erik Larsson
2018-03-04 17:25   ` Baruch Siach
2018-03-04 18:05 ` [Buildroot] [PATCH v4 0/4] Initial support for NXP iMX8 (imx8mq-evk) Fabio Estevam
2018-03-06 13:09   ` Erik Larsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180310195817.x4ipzhx47hgeoaja@tarshish \
    --to=baruch@tkos.co.il \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.