All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Hogan <jhogan@kernel.org>
To: Hauke Mehrtens <hauke@hauke-m.de>
Cc: ralf@linux-mips.org, john@phrozen.org, dev@kresin.me,
	linux-mips@linux-mips.org, martin.blumenstingl@googlemail.com
Subject: Re: [PATCH 2/3] MIPS: lantiq: enable AHB Bus for USB
Date: Mon, 12 Mar 2018 21:17:03 +0000	[thread overview]
Message-ID: <20180312211702.GB21642@saruman> (raw)
In-Reply-To: <20180311174123.2578-2-hauke@hauke-m.de>

[-- Attachment #1: Type: text/plain, Size: 1276 bytes --]

Hi,

On Sun, Mar 11, 2018 at 06:41:22PM +0100, Hauke Mehrtens wrote:
> From: Mathias Kresin <dev@kresin.me>
> 
> On Danube and AR9 the USB core is connected to the AHB bus, hence we need
> to enable the AHB Bus as well.
> 
> Fixes: dea54fbad332 ("phy: Add an USB PHY driver for the Lantiq SoCs using the RCU module")
> Signed-off-by: Mathias Kresin <dev@kresin.me>

Hauke: I think this needs your SoB line too (same for other 2 patches
too).

> ---
>  arch/mips/lantiq/xway/sysctrl.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/mips/lantiq/xway/sysctrl.c b/arch/mips/lantiq/xway/sysctrl.c
> index f11f1dd10493..e0af39b33e28 100644
> --- a/arch/mips/lantiq/xway/sysctrl.c
> +++ b/arch/mips/lantiq/xway/sysctrl.c
> @@ -549,9 +549,9 @@ void __init ltq_soc_init(void)
>  		clkdev_add_static(ltq_ar9_cpu_hz(), ltq_ar9_fpi_hz(),
>  				ltq_ar9_fpi_hz(), CLOCK_250M);
>  		clkdev_add_pmu("1f203018.usb2-phy", "phy", 1, 0, PMU_USB0_P);
> -		clkdev_add_pmu("1e101000.usb", "otg", 1, 0, PMU_USB0);
> +		clkdev_add_pmu("1e101000.usb", "otg", 1, 0, PMU_USB0 | PMU_AHBM);

Checkpatch complains about these changed lines all being >80 columns,
though there are admittedly other violations nearby too.

Cheers
James

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  parent reply	other threads:[~2018-03-12 21:17 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-11 17:41 [PATCH 1/3] MIPS: lantiq: fix danube usb clock Hauke Mehrtens
2018-03-11 17:41 ` [PATCH 2/3] MIPS: lantiq: enable AHB Bus for USB Hauke Mehrtens
2018-03-12 20:41   ` Martin Blumenstingl
2018-03-12 21:17   ` James Hogan [this message]
2018-03-12 21:29     ` Martin Blumenstingl
2018-03-12 21:38       ` Hauke Mehrtens
2018-03-12 21:44         ` James Hogan
2018-03-12 21:27   ` Hauke Mehrtens
2018-03-11 17:41 ` [PATCH 3/3] MIPS: lantiq: ase: Enable MFD_SYSCON Hauke Mehrtens
2018-03-12 20:39   ` Martin Blumenstingl
2018-03-12 21:27   ` Hauke Mehrtens
2018-03-12 21:39   ` James Hogan
2018-03-13 22:40     ` Hauke Mehrtens
2018-03-14 11:45       ` James Hogan
2018-03-14 11:45         ` James Hogan
2018-03-12 20:39 ` [PATCH 1/3] MIPS: lantiq: fix danube usb clock Martin Blumenstingl
2018-03-12 21:27 ` Hauke Mehrtens

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180312211702.GB21642@saruman \
    --to=jhogan@kernel.org \
    --cc=dev@kresin.me \
    --cc=hauke@hauke-m.de \
    --cc=john@phrozen.org \
    --cc=linux-mips@linux-mips.org \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.