From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00010702.pphosted.com ([148.163.156.75]:50384 "EHLO mx0b-00010702.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932274AbeCLVfJ (ORCPT ); Mon, 12 Mar 2018 17:35:09 -0400 From: Brad Mouring To: Nicolas Ferre , Rob Herring , "David S . Miller" , Michael Grzeschik , Andrew Lunn CC: Mark Rutland , , Julia Cartwright , , Brad Mouring Subject: [PATCH v4 net-next 2/4] net: macb: Remove redundant poll irq assignment Date: Mon, 12 Mar 2018 16:34:33 -0500 Message-ID: <20180312213435.115174-3-brad.mouring@ni.com> In-Reply-To: <20180312213435.115174-1-brad.mouring@ni.com> References: <20180312175956.GS27783@lunn.ch> <20180312213435.115174-1-brad.mouring@ni.com> MIME-Version: 1.0 Content-Type: text/plain Sender: netdev-owner@vger.kernel.org List-ID: In phy_device's general probe, this device will already be set for phy register polling, rendering this code redundant. Signed-off-by: Brad Mouring Suggested-by: Andrew Lunn Reviewed-by: Florian Fainelli --- drivers/net/ethernet/cadence/macb_main.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c index 9b6195fbbf8e..db1dc301bed3 100644 --- a/drivers/net/ethernet/cadence/macb_main.c +++ b/drivers/net/ethernet/cadence/macb_main.c @@ -593,9 +593,6 @@ static int macb_mii_init(struct macb *bp) if (np) { err = of_mdiobus_register(bp->mii_bus, np); } else { - for (i = 0; i < PHY_MAX_ADDR; i++) - bp->mii_bus->irq[i] = PHY_POLL; - if (pdata) bp->mii_bus->phy_mask = pdata->phy_mask; -- 2.16.2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Brad Mouring Subject: [PATCH v4 net-next 2/4] net: macb: Remove redundant poll irq assignment Date: Mon, 12 Mar 2018 16:34:33 -0500 Message-ID: <20180312213435.115174-3-brad.mouring@ni.com> In-Reply-To: <20180312213435.115174-1-brad.mouring@ni.com> References: <20180312175956.GS27783@lunn.ch> <20180312213435.115174-1-brad.mouring@ni.com> MIME-Version: 1.0 Content-Type: text/plain To: Nicolas Ferre , Rob Herring , "David S . Miller" , Michael Grzeschik , Andrew Lunn Cc: Mark Rutland , netdev@vger.kernel.org, Julia Cartwright , devicetree@vger.kernel.org, Brad Mouring List-ID: In phy_device's general probe, this device will already be set for phy register polling, rendering this code redundant. Signed-off-by: Brad Mouring Suggested-by: Andrew Lunn Reviewed-by: Florian Fainelli --- drivers/net/ethernet/cadence/macb_main.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c index 9b6195fbbf8e..db1dc301bed3 100644 --- a/drivers/net/ethernet/cadence/macb_main.c +++ b/drivers/net/ethernet/cadence/macb_main.c @@ -593,9 +593,6 @@ static int macb_mii_init(struct macb *bp) if (np) { err = of_mdiobus_register(bp->mii_bus, np); } else { - for (i = 0; i < PHY_MAX_ADDR; i++) - bp->mii_bus->irq[i] = PHY_POLL; - if (pdata) bp->mii_bus->phy_mask = pdata->phy_mask; -- 2.16.2