From: David Miller <davem@davemloft.net>
To: arnd@arndb.de
Cc: gustavo@embeddedor.com, dima@arista.com, johannes.berg@intel.com,
edumazet@google.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pktgen: use dynamic allocation for debug print buffer
Date: Tue, 13 Mar 2018 20:25:52 -0400 (EDT) [thread overview]
Message-ID: <20180313.202552.1990425972566331246.davem@davemloft.net> (raw)
In-Reply-To: <20180313205856.3309750-1-arnd@arndb.de>
From: Arnd Bergmann <arnd@arndb.de>
Date: Tue, 13 Mar 2018 21:58:39 +0100
> After the removal of the VLA, we get a harmless warning about a large
> stack frame:
>
> net/core/pktgen.c: In function 'pktgen_if_write':
> net/core/pktgen.c:1710:1: error: the frame size of 1076 bytes is larger than 1024 bytes [-Werror=frame-larger-than=]
>
> The function was previously shown to be safe despite hitting
> the 1024 bye warning level. To get rid of the annoyging warning,
> while keeping it readable, this changes it to use strndup_user().
>
> Obviously this is not a fast path, so the kmalloc() overhead
> can be disregarded.
>
> Fixes: 35951393bbff ("pktgen: Remove VLA usage")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied, thanks.
next prev parent reply other threads:[~2018-03-14 0:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-13 20:58 [PATCH] pktgen: use dynamic allocation for debug print buffer Arnd Bergmann
2018-03-14 0:25 ` David Miller [this message]
2018-03-14 3:02 ` Wang Jian
2018-03-14 8:16 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180313.202552.1990425972566331246.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=arnd@arndb.de \
--cc=dima@arista.com \
--cc=edumazet@google.com \
--cc=gustavo@embeddedor.com \
--cc=johannes.berg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.