From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52905) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1evUV0-0006oy-K9 for qemu-devel@nongnu.org; Mon, 12 Mar 2018 16:56:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1evUUw-0005Sv-IE for qemu-devel@nongnu.org; Mon, 12 Mar 2018 16:56:50 -0400 Received: from mail-lf0-x241.google.com ([2a00:1450:4010:c07::241]:37682) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1evUUw-0005SO-8I for qemu-devel@nongnu.org; Mon, 12 Mar 2018 16:56:46 -0400 Received: by mail-lf0-x241.google.com with SMTP id y19-v6so25409244lfd.4 for ; Mon, 12 Mar 2018 13:56:46 -0700 (PDT) Date: Tue, 13 Mar 2018 06:56:37 +1000 From: Alexey G Message-ID: <20180313065637.00005cee@gmail.com> In-Reply-To: <20180312194406.GX3417@localhost.localdomain> References: <4a65e8b30fe9d2a6c1c53b85ef2697f02e01d13f.1520867956.git.x1917x@gmail.com> <20180312194406.GX3417@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH 16/30] q35/xen: Add Xen platform device support for Q35 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: xen-devel@lists.xenproject.org, qemu-devel@nongnu.org, Marcel Apfelbaum , Paolo Bonzini , Richard Henderson , "Michael S. Tsirkin" On Mon, 12 Mar 2018 16:44:06 -0300 Eduardo Habkost wrote: >On Tue, Mar 13, 2018 at 04:34:01AM +1000, Alexey Gerasimenko wrote: >> Current Xen/QEMU method to control Xen Platform device on i440 is a >> bit odd -- enabling/disabling Xen platform device actually modifies >> the QEMU emulated machine type, namely xenfv <--> pc. >> >> In order to avoid multiplying machine types, use a new way to >> control Xen Platform device for QEMU -- "xen-platform-dev" machine >> property (bool). To maintain backward compatibility with existing >> Xen/QEMU setups, this is only applicable to q35 machine currently. >> i440 emulation still uses the old method (i.e. xenfv/pc machine >> selection) to control Xen Platform device, this may be changed later >> to xen-platform-dev property as well. >> >> This way we can use a single machine type (q35) and change just >> xen-platform-dev value to on/off to control Xen platform device. >> >> Signed-off-by: Alexey Gerasimenko >> --- >[...] >> diff --git a/qemu-options.hx b/qemu-options.hx >> index 6585058c6c..cee0b92028 100644 >> --- a/qemu-options.hx >> +++ b/qemu-options.hx >> @@ -38,6 +38,7 @@ DEF("machine", HAS_ARG, QEMU_OPTION_machine, \ >> " dump-guest-core=on|off include guest memory in >> a core dump (default=on)\n" " mem-merge=on|off >> controls memory merge support (default: on)\n" " >> igd-passthru=on|off controls IGD GFX passthrough support >> (default=off)\n" >> + " xen-platform-dev=on|off controls Xen Platform >> device (default=off)\n" " aes-key-wrap=on|off >> controls support for AES key wrapping (default=on)\n" >> " dea-key-wrap=on|off controls support for DEA key >> wrapping (default=on)\n" " suppress-vmdesc=on|off >> disables self-describing migration (default=off)\n" > >What are the obstacles preventing "-device xen-platform" from >working? It would be better than adding a new boolean option to >-machine. I guess the initial assumption was that changing the xen_platform_device value in Xen's options may cause some additional changes in platform configuration besides adding (or not) the Xen Platform device, hence a completely different machine type was chosen (xenfv). At the moment pc,accel=xen/xenfv selection mostly governs only the Xen Platform device presence. Also setting max_cpus to HVM_MAX_VCPUS depends on it, but this doesn't applicable to a 'pc,accel=xen' machine for some reason. If applying HVM_MAX_VCPUS to max_cpus is really necessary I think it's better to set it unconditionally for all 'accel=xen' HVM machine types inside xen_enabled() block. Right now it's missing for pc,accel=xen and q35,accel=xen. I'll check if supplying the Xen platform device via the '-device' option will be ok for all usage cases. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexey G Subject: Re: [RFC PATCH 16/30] q35/xen: Add Xen platform device support for Q35 Date: Tue, 13 Mar 2018 06:56:37 +1000 Message-ID: <20180313065637.00005cee@gmail.com> References: <4a65e8b30fe9d2a6c1c53b85ef2697f02e01d13f.1520867956.git.x1917x@gmail.com> <20180312194406.GX3417@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1evUUy-0005Zw-8C for xen-devel@lists.xenproject.org; Mon, 12 Mar 2018 20:56:48 +0000 Received: by mail-lf0-x242.google.com with SMTP id w16-v6so4327710lfc.13 for ; Mon, 12 Mar 2018 13:56:46 -0700 (PDT) In-Reply-To: <20180312194406.GX3417@localhost.localdomain> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Eduardo Habkost Cc: "Michael S. Tsirkin" , qemu-devel@nongnu.org, Paolo Bonzini , Marcel Apfelbaum , xen-devel@lists.xenproject.org, Richard Henderson List-Id: xen-devel@lists.xenproject.org T24gTW9uLCAxMiBNYXIgMjAxOCAxNjo0NDowNiAtMDMwMApFZHVhcmRvIEhhYmtvc3QgPGVoYWJr b3N0QHJlZGhhdC5jb20+IHdyb3RlOgoKPk9uIFR1ZSwgTWFyIDEzLCAyMDE4IGF0IDA0OjM0OjAx QU0gKzEwMDAsIEFsZXhleSBHZXJhc2ltZW5rbyB3cm90ZToKPj4gQ3VycmVudCBYZW4vUUVNVSBt ZXRob2QgdG8gY29udHJvbCBYZW4gUGxhdGZvcm0gZGV2aWNlIG9uIGk0NDAgaXMgYQo+PiBiaXQg b2RkIC0tIGVuYWJsaW5nL2Rpc2FibGluZyBYZW4gcGxhdGZvcm0gZGV2aWNlIGFjdHVhbGx5IG1v ZGlmaWVzCj4+IHRoZSBRRU1VIGVtdWxhdGVkIG1hY2hpbmUgdHlwZSwgbmFtZWx5IHhlbmZ2IDwt LT4gcGMuCj4+IAo+PiBJbiBvcmRlciB0byBhdm9pZCBtdWx0aXBseWluZyBtYWNoaW5lIHR5cGVz LCB1c2UgYSBuZXcgd2F5IHRvCj4+IGNvbnRyb2wgWGVuIFBsYXRmb3JtIGRldmljZSBmb3IgUUVN VSAtLSAieGVuLXBsYXRmb3JtLWRldiIgbWFjaGluZQo+PiBwcm9wZXJ0eSAoYm9vbCkuIFRvIG1h aW50YWluIGJhY2t3YXJkIGNvbXBhdGliaWxpdHkgd2l0aCBleGlzdGluZwo+PiBYZW4vUUVNVSBz ZXR1cHMsIHRoaXMgaXMgb25seSBhcHBsaWNhYmxlIHRvIHEzNSBtYWNoaW5lIGN1cnJlbnRseS4K Pj4gaTQ0MCBlbXVsYXRpb24gc3RpbGwgdXNlcyB0aGUgb2xkIG1ldGhvZCAoaS5lLiB4ZW5mdi9w YyBtYWNoaW5lCj4+IHNlbGVjdGlvbikgdG8gY29udHJvbCBYZW4gUGxhdGZvcm0gZGV2aWNlLCB0 aGlzIG1heSBiZSBjaGFuZ2VkIGxhdGVyCj4+IHRvIHhlbi1wbGF0Zm9ybS1kZXYgcHJvcGVydHkg YXMgd2VsbC4KPj4gCj4+IFRoaXMgd2F5IHdlIGNhbiB1c2UgYSBzaW5nbGUgbWFjaGluZSB0eXBl IChxMzUpIGFuZCBjaGFuZ2UganVzdAo+PiB4ZW4tcGxhdGZvcm0tZGV2IHZhbHVlIHRvIG9uL29m ZiB0byBjb250cm9sIFhlbiBwbGF0Zm9ybSBkZXZpY2UuCj4+IAo+PiBTaWduZWQtb2ZmLWJ5OiBB bGV4ZXkgR2VyYXNpbWVua28gPHgxOTE3eEBnbWFpbC5jb20+Cj4+IC0tLSAgCj5bLi4uXQo+PiBk aWZmIC0tZ2l0IGEvcWVtdS1vcHRpb25zLmh4IGIvcWVtdS1vcHRpb25zLmh4Cj4+IGluZGV4IDY1 ODUwNThjNmMuLmNlZTBiOTIwMjggMTAwNjQ0Cj4+IC0tLSBhL3FlbXUtb3B0aW9ucy5oeAo+PiAr KysgYi9xZW11LW9wdGlvbnMuaHgKPj4gQEAgLTM4LDYgKzM4LDcgQEAgREVGKCJtYWNoaW5lIiwg SEFTX0FSRywgUUVNVV9PUFRJT05fbWFjaGluZSwgXAo+PiAgICAgICIgICAgICAgICAgICAgICAg ZHVtcC1ndWVzdC1jb3JlPW9ufG9mZiBpbmNsdWRlIGd1ZXN0IG1lbW9yeSBpbgo+PiBhIGNvcmUg ZHVtcCAoZGVmYXVsdD1vbilcbiIgIiAgICAgICAgICAgICAgICBtZW0tbWVyZ2U9b258b2ZmCj4+ IGNvbnRyb2xzIG1lbW9yeSBtZXJnZSBzdXBwb3J0IChkZWZhdWx0OiBvbilcbiIgIgo+PiBpZ2Qt cGFzc3RocnU9b258b2ZmIGNvbnRyb2xzIElHRCBHRlggcGFzc3Rocm91Z2ggc3VwcG9ydAo+PiAo ZGVmYXVsdD1vZmYpXG4iCj4+ICsgICAgIiAgICAgICAgICAgICAgICB4ZW4tcGxhdGZvcm0tZGV2 PW9ufG9mZiBjb250cm9scyBYZW4gUGxhdGZvcm0KPj4gZGV2aWNlIChkZWZhdWx0PW9mZilcbiIg IiAgICAgICAgICAgICAgICBhZXMta2V5LXdyYXA9b258b2ZmCj4+IGNvbnRyb2xzIHN1cHBvcnQg Zm9yIEFFUyBrZXkgd3JhcHBpbmcgKGRlZmF1bHQ9b24pXG4iCj4+ICIgICAgICAgICAgICAgICAg ZGVhLWtleS13cmFwPW9ufG9mZiBjb250cm9scyBzdXBwb3J0IGZvciBERUEga2V5Cj4+IHdyYXBw aW5nIChkZWZhdWx0PW9uKVxuIiAiICAgICAgICAgICAgICAgIHN1cHByZXNzLXZtZGVzYz1vbnxv ZmYKPj4gZGlzYWJsZXMgc2VsZi1kZXNjcmliaW5nIG1pZ3JhdGlvbiAoZGVmYXVsdD1vZmYpXG4i ICAKPgo+V2hhdCBhcmUgdGhlIG9ic3RhY2xlcyBwcmV2ZW50aW5nICItZGV2aWNlIHhlbi1wbGF0 Zm9ybSIgZnJvbQo+d29ya2luZz8gIEl0IHdvdWxkIGJlIGJldHRlciB0aGFuIGFkZGluZyBhIG5l dyBib29sZWFuIG9wdGlvbiB0bwo+LW1hY2hpbmUuCgpJIGd1ZXNzIHRoZSBpbml0aWFsIGFzc3Vt cHRpb24gd2FzIHRoYXQgY2hhbmdpbmcgdGhlCnhlbl9wbGF0Zm9ybV9kZXZpY2UgdmFsdWUgaW4g WGVuJ3Mgb3B0aW9ucyBtYXkgY2F1c2Ugc29tZSBhZGRpdGlvbmFsCmNoYW5nZXMgaW4gcGxhdGZv cm0gY29uZmlndXJhdGlvbiBiZXNpZGVzIGFkZGluZyAob3Igbm90KSB0aGUgWGVuClBsYXRmb3Jt IGRldmljZSwgaGVuY2UgYSBjb21wbGV0ZWx5IGRpZmZlcmVudCBtYWNoaW5lIHR5cGUgd2FzIGNo b3NlbgooeGVuZnYpLgoKQXQgdGhlIG1vbWVudCBwYyxhY2NlbD14ZW4veGVuZnYgc2VsZWN0aW9u IG1vc3RseSBnb3Zlcm5zCm9ubHkgdGhlIFhlbiBQbGF0Zm9ybSBkZXZpY2UgcHJlc2VuY2UuIEFs c28gc2V0dGluZyBtYXhfY3B1cyB0bwpIVk1fTUFYX1ZDUFVTIGRlcGVuZHMgb24gaXQsIGJ1dCB0 aGlzIGRvZXNuJ3QgYXBwbGljYWJsZSB0byBhCidwYyxhY2NlbD14ZW4nIG1hY2hpbmUgZm9yIHNv bWUgcmVhc29uLgoKSWYgYXBwbHlpbmcgSFZNX01BWF9WQ1BVUyB0byBtYXhfY3B1cyBpcyByZWFs bHkgbmVjZXNzYXJ5IEkgdGhpbmsgaXQncwpiZXR0ZXIgdG8gc2V0IGl0IHVuY29uZGl0aW9uYWxs eSBmb3IgYWxsICdhY2NlbD14ZW4nIEhWTSBtYWNoaW5lCnR5cGVzIGluc2lkZSB4ZW5fZW5hYmxl ZCgpIGJsb2NrLiBSaWdodCBub3cgaXQncyBtaXNzaW5nIGZvcgpwYyxhY2NlbD14ZW4gYW5kIHEz NSxhY2NlbD14ZW4uCgpJJ2xsIGNoZWNrIGlmIHN1cHBseWluZyB0aGUgWGVuIHBsYXRmb3JtIGRl dmljZSB2aWEgdGhlICctZGV2aWNlJyBvcHRpb24Kd2lsbCBiZSBvayBmb3IgYWxsIHVzYWdlIGNh c2VzLgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVu LWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6 Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA==