All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org,
	pbonzini@redhat.com, armbru@redhat.com, eblake@redhat.com,
	famz@redhat.com, stefanha@redhat.com, quintela@redhat.com,
	mreitz@redhat.com, kwolf@redhat.com, peter.maydell@linaro.org,
	den@openvz.org, jsnow@redhat.com, lirans@il.ibm.com
Subject: Re: [Qemu-devel] [PATCH v11 10/13] migration: allow qmp command migrate-start-postcopy for any postcopy
Date: Tue, 13 Mar 2018 18:11:45 +0000	[thread overview]
Message-ID: <20180313181144.GL3545@work-vm> (raw)
In-Reply-To: <20180313180320.339796-11-vsementsov@virtuozzo.com>

* Vladimir Sementsov-Ogievskiy (vsementsov@virtuozzo.com) wrote:
> Allow migrate-start-postcopy for any postcopy type
> 
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>

Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

> ---
>  migration/migration.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/migration/migration.c b/migration/migration.c
> index 094196c236..59b4fe6090 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -1022,7 +1022,7 @@ void qmp_migrate_start_postcopy(Error **errp)
>  {
>      MigrationState *s = migrate_get_current();
>  
> -    if (!migrate_postcopy_ram()) {
> +    if (!migrate_postcopy()) {
>          error_setg(errp, "Enable postcopy with migrate_set_capability before"
>                           " the start of migration");
>          return;
> -- 
> 2.11.1
> 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK

  reply	other threads:[~2018-03-13 18:12 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-13 18:03 [Qemu-devel] [PATCH v11 00/13] Dirty bitmaps postcopy migration Vladimir Sementsov-Ogievskiy
2018-03-13 18:03 ` [Qemu-devel] [PATCH v11 01/13] block/dirty-bitmap: add bdrv_dirty_bitmap_enable_successor() Vladimir Sementsov-Ogievskiy
2018-03-13 18:03 ` [Qemu-devel] [PATCH v11 02/13] block/dirty-bitmap: fix locking in bdrv_reclaim_dirty_bitmap Vladimir Sementsov-Ogievskiy
2018-03-13 18:03 ` [Qemu-devel] [PATCH v11 03/13] block/dirty-bitmap: add _locked version of bdrv_reclaim_dirty_bitmap Vladimir Sementsov-Ogievskiy
2018-03-13 18:03 ` [Qemu-devel] [PATCH v11 04/13] dirty-bitmap: add locked state Vladimir Sementsov-Ogievskiy
2018-03-13 18:03 ` [Qemu-devel] [PATCH v11 05/13] migration: introduce postcopy-only pending Vladimir Sementsov-Ogievskiy
2018-03-13 18:09   ` Dr. David Alan Gilbert
2018-03-13 18:03 ` [Qemu-devel] [PATCH v11 06/13] qapi: add dirty-bitmaps migration capability Vladimir Sementsov-Ogievskiy
2018-03-13 18:03 ` [Qemu-devel] [PATCH v11 07/13] migration: include migrate_dirty_bitmaps in migrate_postcopy Vladimir Sementsov-Ogievskiy
2018-03-13 18:03 ` [Qemu-devel] [PATCH v11 08/13] migration/qemu-file: add qemu_put_counted_string() Vladimir Sementsov-Ogievskiy
2018-03-13 18:03 ` [Qemu-devel] [PATCH v11 09/13] migration: add is_active_iterate handler Vladimir Sementsov-Ogievskiy
2018-03-13 18:03 ` [Qemu-devel] [PATCH v11 10/13] migration: allow qmp command migrate-start-postcopy for any postcopy Vladimir Sementsov-Ogievskiy
2018-03-13 18:11   ` Dr. David Alan Gilbert [this message]
2018-03-13 18:03 ` [Qemu-devel] [PATCH v11 11/13] migration: add postcopy migration of dirty bitmaps Vladimir Sementsov-Ogievskiy
2018-03-13 18:22   ` Dr. David Alan Gilbert
2018-03-13 18:29     ` Vladimir Sementsov-Ogievskiy
2018-03-13 19:42       ` John Snow
2018-03-13 18:03 ` [Qemu-devel] [PATCH v11 12/13] iotests: add dirty bitmap migration test Vladimir Sementsov-Ogievskiy
2018-03-13 18:03 ` [Qemu-devel] [PATCH v11 13/13] iotests: add dirty bitmap postcopy test Vladimir Sementsov-Ogievskiy
2018-03-13 19:03 ` [Qemu-devel] [PATCH v11 00/13] Dirty bitmaps postcopy migration no-reply
2018-03-13 20:01   ` Vladimir Sementsov-Ogievskiy
2018-03-13 20:09     ` Eric Blake
2018-03-13 20:10     ` Dr. David Alan Gilbert
2018-03-14  5:16       ` Su Hang
2018-03-14  9:20         ` Dr. David Alan Gilbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180313181144.GL3545@work-vm \
    --to=dgilbert@redhat.com \
    --cc=armbru@redhat.com \
    --cc=den@openvz.org \
    --cc=eblake@redhat.com \
    --cc=famz@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=lirans@il.ibm.com \
    --cc=mreitz@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=stefanha@redhat.com \
    --cc=vsementsov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.