From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00010702.pphosted.com ([148.163.156.75]:58670 "EHLO mx0b-00010702.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932528AbeCMVci (ORCPT ); Tue, 13 Mar 2018 17:32:38 -0400 From: Brad Mouring To: Nicolas Ferre , Rob Herring , "David S . Miller" , "Michael Grzeschik" , Andrew Lunn CC: Mark Rutland , , "Julia Cartwright" , , Brad Mouring Subject: [PATCH v5 net-next 2/4] net: macb: Remove redundant poll irq assignment Date: Tue, 13 Mar 2018 16:32:14 -0500 Message-ID: <20180313213216.109153-3-brad.mouring@ni.com> In-Reply-To: <20180313213216.109153-1-brad.mouring@ni.com> References: <88aa8148-bf57-86a0-8f0d-fae7191865a6@gmail.com> <20180313213216.109153-1-brad.mouring@ni.com> MIME-Version: 1.0 Content-Type: text/plain Sender: netdev-owner@vger.kernel.org List-ID: In phy_device's general probe, this device will already be set for phy register polling, rendering this code redundant. Signed-off-by: Brad Mouring Suggested-by: Andrew Lunn Reviewed-by: Florian Fainelli --- drivers/net/ethernet/cadence/macb_main.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c index 4b514c705e57..db1dc301bed3 100644 --- a/drivers/net/ethernet/cadence/macb_main.c +++ b/drivers/net/ethernet/cadence/macb_main.c @@ -566,7 +566,7 @@ static int macb_mii_init(struct macb *bp) { struct macb_platform_data *pdata; struct device_node *np; - int err, i; + int err; /* Enable management port */ macb_writel(bp, NCR, MACB_BIT(MPE)); @@ -593,9 +593,6 @@ static int macb_mii_init(struct macb *bp) if (np) { err = of_mdiobus_register(bp->mii_bus, np); } else { - for (i = 0; i < PHY_MAX_ADDR; i++) - bp->mii_bus->irq[i] = PHY_POLL; - if (pdata) bp->mii_bus->phy_mask = pdata->phy_mask; -- 2.16.2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Brad Mouring Subject: [PATCH v5 net-next 2/4] net: macb: Remove redundant poll irq assignment Date: Tue, 13 Mar 2018 16:32:14 -0500 Message-ID: <20180313213216.109153-3-brad.mouring@ni.com> In-Reply-To: <20180313213216.109153-1-brad.mouring@ni.com> References: <88aa8148-bf57-86a0-8f0d-fae7191865a6@gmail.com> <20180313213216.109153-1-brad.mouring@ni.com> MIME-Version: 1.0 Content-Type: text/plain To: Nicolas Ferre , Rob Herring , "David S . Miller" , "Michael Grzeschik , Andrew Lunn" Cc: Mark Rutland , netdev@vger.kernel.org, "Julia Cartwright , , Brad Mouring" List-ID: In phy_device's general probe, this device will already be set for phy register polling, rendering this code redundant. Signed-off-by: Brad Mouring Suggested-by: Andrew Lunn Reviewed-by: Florian Fainelli --- drivers/net/ethernet/cadence/macb_main.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c index 4b514c705e57..db1dc301bed3 100644 --- a/drivers/net/ethernet/cadence/macb_main.c +++ b/drivers/net/ethernet/cadence/macb_main.c @@ -566,7 +566,7 @@ static int macb_mii_init(struct macb *bp) { struct macb_platform_data *pdata; struct device_node *np; - int err, i; + int err; /* Enable management port */ macb_writel(bp, NCR, MACB_BIT(MPE)); @@ -593,9 +593,6 @@ static int macb_mii_init(struct macb *bp) if (np) { err = of_mdiobus_register(bp->mii_bus, np); } else { - for (i = 0; i < PHY_MAX_ADDR; i++) - bp->mii_bus->irq[i] = PHY_POLL; - if (pdata) bp->mii_bus->phy_mask = pdata->phy_mask; -- 2.16.2