From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42445) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eviFt-0006gJ-EF for qemu-devel@nongnu.org; Tue, 13 Mar 2018 07:38:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eviFo-0003o8-I2 for qemu-devel@nongnu.org; Tue, 13 Mar 2018 07:38:09 -0400 Received: from mail-lf0-x22b.google.com ([2a00:1450:4010:c07::22b]:42120) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eviFo-0003na-At for qemu-devel@nongnu.org; Tue, 13 Mar 2018 07:38:04 -0400 Received: by mail-lf0-x22b.google.com with SMTP id a22-v6so6326759lfg.9 for ; Tue, 13 Mar 2018 04:38:04 -0700 (PDT) Date: Tue, 13 Mar 2018 21:37:55 +1000 From: Alexey G Message-ID: <20180313213755.00006cd9@gmail.com> In-Reply-To: <20180313092154.GA3048@redhat.com> References: <20180313092154.GA3048@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [RFC PATCH 00/30] Xen Q35 Bringup patches + support for PCIe Extended Capabilities for passed through devices List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. =?utf-8?Q?Berrang=C3=A9?=" Cc: xen-devel@lists.xenproject.org, qemu-devel@nongnu.org On Tue, 13 Mar 2018 09:21:54 +0000 Daniel P. Berrang=C3=A9 wrote: >The subject line says to expect 30 patches, but you've only sent 18 to >the list here. I eventually figured out that the first 12 patches were >in Xen code and so not sent to qemu-devel. > >For future if you have changes that affect multiple completely separate >projects, send them as separate series. ie just send PATCH 00/18 to >QEMU devel so it doesn't look like a bunch of patches have gone >missing. OK, we'll do for next versions. >> A new domain config option was implemented: device_model_machine. >> It's a string which has following possible values: >> - "i440" -- i440 emulation (default) >> - "q35" -- emulate a Q35 machine. By default, the storage interface >> is AHCI. =20 > >Presumably this is mapping to the QEMU -machine arg, so it feels >desirable to keep the same naming scheme. ie allow any of the >versioned machine names that QEMU uses. eg any of "pc-q35-2.x" >versioned types, or 'q35' as an alias for latest, and use >"pc-i440fx-2.x" versioned types of 'pc' as an alias for latest, rather >than 'i440' which is needlessly divering from the QEMU machine type. Yes, it is translated into the '-machine' argument. A direct mapping between the Xen device_model_machine option and QEMU '-machine' argument won't be accepted by Xen maintainers I guess. The main problem with this approach is a requirement to have a match between Xen/libxl and QEMU versions. If, for example, device_model_machine tells something like "pc-q35-2.11" and later we downgrade QEMU to some older version we'll likely have a problem without changing anything in the domain config. So I guess the "use the latest available" approach for machine selection (pc, q35, etc) is the only possible option. Perhaps having the way to specify the exact QEMU machine name and version in a separate domain config parameter (for advanced use) might be feasible. Also, parameter names do not speak for themselves I'm afraid. This way we'll have, for example, device_model_machine=3D"pc" vs device_model_machine=3D"q35"... a bit unclear I think. This may be obvious for a QEMU user, but many Xen users didn't get used to QEMU machines and there might be some wondering why "q35" is not "pc" and why "pc" is an i440 system precisely. Another obstacle here is xen_platform_device option which indirectly selects QEMU machine type for i440 at the moment (pc/xenfv), but this may be addressed by controlling the Xen platform device independently via a separate machine property or '-device xen-platform' like Eduardo Habkost suggested. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexey G Subject: Re: [Qemu-devel] [RFC PATCH 00/30] Xen Q35 Bringup patches + support for PCIe Extended Capabilities for passed through devices Date: Tue, 13 Mar 2018 21:37:55 +1000 Message-ID: <20180313213755.00006cd9@gmail.com> References: <20180313092154.GA3048@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eviFq-0005Os-DC for xen-devel@lists.xenproject.org; Tue, 13 Mar 2018 11:38:06 +0000 Received: by mail-lf0-x233.google.com with SMTP id t132-v6so11800636lfe.2 for ; Tue, 13 Mar 2018 04:38:04 -0700 (PDT) In-Reply-To: <20180313092154.GA3048@redhat.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: "Daniel P. =?utf-8?Q?Berrang=C3=A9?=" Cc: xen-devel@lists.xenproject.org, qemu-devel@nongnu.org List-Id: xen-devel@lists.xenproject.org T24gVHVlLCAxMyBNYXIgMjAxOCAwOToyMTo1NCArMDAwMApEYW5pZWwgUC4gQmVycmFuZ8OpIDxi ZXJyYW5nZUByZWRoYXQuY29tPiB3cm90ZToKCj5UaGUgc3ViamVjdCBsaW5lIHNheXMgdG8gZXhw ZWN0IDMwIHBhdGNoZXMsIGJ1dCB5b3UndmUgb25seSBzZW50IDE4IHRvCj50aGUgbGlzdCBoZXJl LiBJIGV2ZW50dWFsbHkgZmlndXJlZCBvdXQgdGhhdCB0aGUgZmlyc3QgMTIgcGF0Y2hlcyB3ZXJl Cj5pbiBYZW4gY29kZSBhbmQgc28gbm90IHNlbnQgdG8gcWVtdS1kZXZlbC4KPgo+Rm9yIGZ1dHVy ZSBpZiB5b3UgaGF2ZSBjaGFuZ2VzIHRoYXQgYWZmZWN0IG11bHRpcGxlIGNvbXBsZXRlbHkgc2Vw YXJhdGUKPnByb2plY3RzLCBzZW5kIHRoZW0gYXMgc2VwYXJhdGUgc2VyaWVzLiBpZSBqdXN0IHNl bmQgUEFUQ0ggMDAvMTggdG8KPlFFTVUgZGV2ZWwgc28gaXQgZG9lc24ndCBsb29rIGxpa2UgYSBi dW5jaCBvZiBwYXRjaGVzIGhhdmUgZ29uZQo+bWlzc2luZy4KCk9LLCB3ZSdsbCBkbyBmb3IgbmV4 dCB2ZXJzaW9ucy4KCj4+IEEgbmV3IGRvbWFpbiBjb25maWcgb3B0aW9uIHdhcyBpbXBsZW1lbnRl ZDogZGV2aWNlX21vZGVsX21hY2hpbmUuCj4+IEl0J3MgYSBzdHJpbmcgd2hpY2ggaGFzIGZvbGxv d2luZyBwb3NzaWJsZSB2YWx1ZXM6Cj4+IC0gImk0NDAiIC0tIGk0NDAgZW11bGF0aW9uIChkZWZh dWx0KQo+PiAtICJxMzUiICAtLSBlbXVsYXRlIGEgUTM1IG1hY2hpbmUuIEJ5IGRlZmF1bHQsIHRo ZSBzdG9yYWdlIGludGVyZmFjZQo+PiBpcyBBSENJLiAgCj4KPlByZXN1bWFibHkgdGhpcyBpcyBt YXBwaW5nIHRvIHRoZSBRRU1VIC1tYWNoaW5lIGFyZywgc28gaXQgZmVlbHMKPmRlc2lyYWJsZSB0 byBrZWVwIHRoZSBzYW1lIG5hbWluZyBzY2hlbWUuIGllIGFsbG93IGFueSBvZiB0aGUKPnZlcnNp b25lZCBtYWNoaW5lIG5hbWVzIHRoYXQgUUVNVSB1c2VzLiBlZyBhbnkgb2YgInBjLXEzNS0yLngi Cj52ZXJzaW9uZWQgdHlwZXMsIG9yICdxMzUnIGFzIGFuIGFsaWFzIGZvciBsYXRlc3QsIGFuZCB1 c2UKPiJwYy1pNDQwZngtMi54IiB2ZXJzaW9uZWQgdHlwZXMgb2YgJ3BjJyBhcyBhbiBhbGlhcyBm b3IgbGF0ZXN0LCByYXRoZXIKPnRoYW4gJ2k0NDAnIHdoaWNoIGlzIG5lZWRsZXNzbHkgZGl2ZXJp bmcgZnJvbSB0aGUgUUVNVSBtYWNoaW5lIHR5cGUuCgpZZXMsIGl0IGlzIHRyYW5zbGF0ZWQgaW50 byB0aGUgJy1tYWNoaW5lJyBhcmd1bWVudC4KCkEgZGlyZWN0IG1hcHBpbmcgYmV0d2VlbiB0aGUg WGVuIGRldmljZV9tb2RlbF9tYWNoaW5lIG9wdGlvbiBhbmQgUUVNVQonLW1hY2hpbmUnIGFyZ3Vt ZW50IHdvbid0IGJlIGFjY2VwdGVkIGJ5IFhlbiBtYWludGFpbmVycyBJIGd1ZXNzLgoKVGhlIG1h aW4gcHJvYmxlbSB3aXRoIHRoaXMgYXBwcm9hY2ggaXMgYSByZXF1aXJlbWVudCB0byBoYXZlIGEg bWF0Y2gKYmV0d2VlbiBYZW4vbGlieGwgYW5kIFFFTVUgdmVyc2lvbnMuIElmLCBmb3IgZXhhbXBs ZSwKZGV2aWNlX21vZGVsX21hY2hpbmUgdGVsbHMgc29tZXRoaW5nIGxpa2UgInBjLXEzNS0yLjEx IiBhbmQgbGF0ZXIgd2UKZG93bmdyYWRlIFFFTVUgdG8gc29tZSBvbGRlciB2ZXJzaW9uIHdlJ2xs IGxpa2VseSBoYXZlIGEgcHJvYmxlbQp3aXRob3V0IGNoYW5naW5nIGFueXRoaW5nIGluIHRoZSBk b21haW4gY29uZmlnLiBTbyBJIGd1ZXNzIHRoZSAidXNlIHRoZQpsYXRlc3QgYXZhaWxhYmxlIiBh cHByb2FjaCBmb3IgbWFjaGluZSBzZWxlY3Rpb24gKHBjLCBxMzUsIGV0YykgaXMgdGhlCm9ubHkg cG9zc2libGUgb3B0aW9uLiBQZXJoYXBzIGhhdmluZyB0aGUgd2F5IHRvIHNwZWNpZnkgdGhlIGV4 YWN0IFFFTVUKbWFjaGluZSBuYW1lIGFuZCB2ZXJzaW9uIGluIGEgc2VwYXJhdGUgZG9tYWluIGNv bmZpZyBwYXJhbWV0ZXIgKGZvcgphZHZhbmNlZCB1c2UpIG1pZ2h0IGJlIGZlYXNpYmxlLgoKQWxz bywgcGFyYW1ldGVyIG5hbWVzIGRvIG5vdCBzcGVhayBmb3IgdGhlbXNlbHZlcyBJJ20gYWZyYWlk LiBUaGlzIHdheQp3ZSdsbCBoYXZlLCBmb3IgZXhhbXBsZSwgZGV2aWNlX21vZGVsX21hY2hpbmU9 InBjIiB2cwpkZXZpY2VfbW9kZWxfbWFjaGluZT0icTM1Ii4uLiBhIGJpdCB1bmNsZWFyIEkgdGhp bmsuIFRoaXMgbWF5IGJlCm9idmlvdXMgZm9yIGEgUUVNVSB1c2VyLCBidXQgbWFueSBYZW4gdXNl cnMgZGlkbid0IGdldCB1c2VkIHRvIFFFTVUKbWFjaGluZXMgYW5kIHRoZXJlIG1pZ2h0IGJlIHNv bWUgd29uZGVyaW5nIHdoeSAicTM1IiBpcyBub3QgInBjIiBhbmQKd2h5ICJwYyIgaXMgYW4gaTQ0 MCBzeXN0ZW0gcHJlY2lzZWx5LgoKQW5vdGhlciBvYnN0YWNsZSBoZXJlIGlzIHhlbl9wbGF0Zm9y bV9kZXZpY2Ugb3B0aW9uIHdoaWNoIGluZGlyZWN0bHkKc2VsZWN0cyBRRU1VIG1hY2hpbmUgdHlw ZSBmb3IgaTQ0MCBhdCB0aGUgbW9tZW50IChwYy94ZW5mdiksIGJ1dCB0aGlzCm1heSBiZSBhZGRy ZXNzZWQgYnkgY29udHJvbGxpbmcgdGhlIFhlbiBwbGF0Zm9ybSBkZXZpY2UgaW5kZXBlbmRlbnRs eQp2aWEgYSBzZXBhcmF0ZSBtYWNoaW5lIHByb3BlcnR5IG9yICctZGV2aWNlIHhlbi1wbGF0Zm9y bScgbGlrZQpFZHVhcmRvIEhhYmtvc3Qgc3VnZ2VzdGVkLgoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2 ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWls bWFuL2xpc3RpbmZvL3hlbi1kZXZlbA==