All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Michal Hocko <mhocko@kernel.org>
Cc: linux-kernel@vger.kernel.org, rdunlap@infradead.org,
	sfr@canb.auug.org.au
Subject: Re: + headers-untangle-kmemleakh-from-mmh-fix.patch added to -mm tree
Date: Wed, 14 Mar 2018 08:03:28 -0700	[thread overview]
Message-ID: <20180314080328.500c93123727a9528b5bfb8a@linux-foundation.org> (raw)
In-Reply-To: <20180314145724.GJ23100@dhcp22.suse.cz>

On Wed, 14 Mar 2018 15:57:24 +0100 Michal Hocko <mhocko@kernel.org> wrote:

> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/security/integrity/digsig.c b/security/integrity/digsig.c
> > > index 6f9e4ce568cd..9bb0a7f2863e 100644
> > > --- a/security/integrity/digsig.c
> > > +++ b/security/integrity/digsig.c
> > > @@ -18,6 +18,7 @@
> > >  #include <linux/cred.h>
> > >  #include <linux/key-type.h>
> > >  #include <linux/digsig.h>
> > > +#include <linux/vmalloc.h>
> > >  #include <crypto/public_key.h>
> > >  #include <keys/system_keyring.h>
> > 
> > hm, current linux-next.patch already has this change.  What happened here?
> 
> OK, I see. This is usuall inter tree mess. It didn't fly through your
> tree:
> commit 120f3b11ef88fc38ce1d0ff9c9a4b37860ad3140
> Author: Randy Dunlap <rdunlap@infradead.org>
> Date:   Mon Feb 12 17:26:20 2018 -0800
> 
>     integrity/security: fix digsig.c build error with header file
>     
>     security/integrity/digsig.c has build errors on some $ARCH due to a
>     missing header file, so add it.
>     
>       security/integrity/digsig.c:146:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
>     
>     Reported-by: Michael Ellerman <mpe@ellerman.id.au>
>     Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>     Cc: Mimi Zohar <zohar@linux.vnet.ibm.com>
>     Cc: linux-integrity@vger.kernel.org
>     Link: http://kisskb.ellerman.id.au/kisskb/head/13396/
>     Signed-off-by: James Morris <james.morris@microsoft.com>
> 
> And that is why I haven't noticed that.

I can jiggle things to prevent this, but the
security/integrity/digsig.c fix is actually in mainline now so things
should sort themselves out OK.

  reply	other threads:[~2018-03-14 15:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20180306234907.8-AwjmNNh%akpm@linux-foundation.org>
2018-03-14 12:17 ` + headers-untangle-kmemleakh-from-mmh-fix.patch added to -mm tree Michal Hocko
2018-03-14 14:50   ` Andrew Morton
2018-03-14 14:57     ` Michal Hocko
2018-03-14 15:03       ` Andrew Morton [this message]
2018-03-14 15:06         ` Michal Hocko
2018-03-14 21:00   ` Stephen Rothwell
2018-03-15  7:43     ` Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180314080328.500c93123727a9528b5bfb8a@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhocko@kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.