From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Wed, 14 Mar 2018 11:48:49 +0100 From: Greg KH To: Richard Leitner Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, mathias.nyman@intel.com, bhelgaas@google.com, richard.leitner@skidata.com Subject: Re: [PATCH 2/3] usb: host: pci: introduce PCI vendor ID for Netlogic Message-ID: <20180314104849.GB32615@kroah.com> References: <20180314102933.21367-1-dev@g0hl1n.net> <20180314102933.21367-3-dev@g0hl1n.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180314102933.21367-3-dev@g0hl1n.net> User-Agent: Mutt/1.9.4 (2018-02-28) X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Wed, Mar 14, 2018 at 11:29:32AM +0100, Richard Leitner wrote: > From: Richard Leitner > > Replace the hardcoded PCI vendor ID of Netlogic with a definition in > pci_ids.h Why? It's only being used in one file, so it should not be in pci_ids.h, right? thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [2/3] usb: host: pci: introduce PCI vendor ID for Netlogic From: Greg Kroah-Hartman Message-Id: <20180314104849.GB32615@kroah.com> Date: Wed, 14 Mar 2018 11:48:49 +0100 To: Richard Leitner Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, mathias.nyman@intel.com, bhelgaas@google.com, richard.leitner@skidata.com List-ID: T24gV2VkLCBNYXIgMTQsIDIwMTggYXQgMTE6Mjk6MzJBTSArMDEwMCwgUmljaGFyZCBMZWl0bmVy IHdyb3RlOgo+IEZyb206IFJpY2hhcmQgTGVpdG5lciA8cmljaGFyZC5sZWl0bmVyQHNraWRhdGEu Y29tPgo+IAo+IFJlcGxhY2UgdGhlIGhhcmRjb2RlZCBQQ0kgdmVuZG9yIElEIG9mIE5ldGxvZ2lj IHdpdGggYSBkZWZpbml0aW9uIGluCj4gcGNpX2lkcy5oCgpXaHk/ICBJdCdzIG9ubHkgYmVpbmcg dXNlZCBpbiBvbmUgZmlsZSwgc28gaXQgc2hvdWxkIG5vdCBiZSBpbgpwY2lfaWRzLmgsIHJpZ2h0 PwoKdGhhbmtzLAoKZ3JlZyBrLWgKLS0tClRvIHVuc3Vic2NyaWJlIGZyb20gdGhpcyBsaXN0OiBz ZW5kIHRoZSBsaW5lICJ1bnN1YnNjcmliZSBsaW51eC11c2IiIGluCnRoZSBib2R5IG9mIGEgbWVz c2FnZSB0byBtYWpvcmRvbW9Admdlci5rZXJuZWwub3JnCk1vcmUgbWFqb3Jkb21vIGluZm8gYXQg IGh0dHA6Ly92Z2VyLmtlcm5lbC5vcmcvbWFqb3Jkb21vLWluZm8uaHRtbAo=