All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
To: qemu-devel@nongnu.org, mst@redhat.com,
	maxime.coquelin@redhat.com, marcandre.lureau@redhat.com,
	peterx@redhat.com, quintela@redhat.com
Cc: aarcange@redhat.com
Subject: [Qemu-devel] [PATCH v6 07/29] libvhost-user: Support sending fds back to qemu
Date: Wed, 14 Mar 2018 11:55:56 +0000	[thread overview]
Message-ID: <20180314115618.28831-8-dgilbert@redhat.com> (raw)
In-Reply-To: <20180314115618.28831-1-dgilbert@redhat.com>

From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>

Allow replies with fds (for postcopy)

Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 contrib/libvhost-user/libvhost-user.c | 30 +++++++++++++++++++++++++++++-
 1 file changed, 29 insertions(+), 1 deletion(-)

diff --git a/contrib/libvhost-user/libvhost-user.c b/contrib/libvhost-user/libvhost-user.c
index 37d4228193..ed9f3148d3 100644
--- a/contrib/libvhost-user/libvhost-user.c
+++ b/contrib/libvhost-user/libvhost-user.c
@@ -246,6 +246,31 @@ vu_message_write(VuDev *dev, int conn_fd, VhostUserMsg *vmsg)
 {
     int rc;
     uint8_t *p = (uint8_t *)vmsg;
+    char control[CMSG_SPACE(VHOST_MEMORY_MAX_NREGIONS * sizeof(int))] = { };
+    struct iovec iov = {
+        .iov_base = (char *)vmsg,
+        .iov_len = VHOST_USER_HDR_SIZE,
+    };
+    struct msghdr msg = {
+        .msg_iov = &iov,
+        .msg_iovlen = 1,
+        .msg_control = control,
+    };
+    struct cmsghdr *cmsg;
+
+    memset(control, 0, sizeof(control));
+    assert(vmsg->fd_num <= VHOST_MEMORY_MAX_NREGIONS);
+    if (vmsg->fd_num > 0) {
+        size_t fdsize = vmsg->fd_num * sizeof(int);
+        msg.msg_controllen = CMSG_SPACE(fdsize);
+        cmsg = CMSG_FIRSTHDR(&msg);
+        cmsg->cmsg_len = CMSG_LEN(fdsize);
+        cmsg->cmsg_level = SOL_SOCKET;
+        cmsg->cmsg_type = SCM_RIGHTS;
+        memcpy(CMSG_DATA(cmsg), vmsg->fds, fdsize);
+    } else {
+        msg.msg_controllen = 0;
+    }
 
     /* Set the version in the flags when sending the reply */
     vmsg->flags &= ~VHOST_USER_VERSION_MASK;
@@ -253,7 +278,7 @@ vu_message_write(VuDev *dev, int conn_fd, VhostUserMsg *vmsg)
     vmsg->flags |= VHOST_USER_REPLY_MASK;
 
     do {
-        rc = write(conn_fd, p, VHOST_USER_HDR_SIZE);
+        rc = sendmsg(conn_fd, &msg, 0);
     } while (rc < 0 && (errno == EINTR || errno == EAGAIN));
 
     do {
@@ -346,6 +371,7 @@ vu_get_features_exec(VuDev *dev, VhostUserMsg *vmsg)
     }
 
     vmsg->size = sizeof(vmsg->payload.u64);
+    vmsg->fd_num = 0;
 
     DPRINT("Sending back to guest u64: 0x%016"PRIx64"\n", vmsg->payload.u64);
 
@@ -501,6 +527,7 @@ vu_set_log_base_exec(VuDev *dev, VhostUserMsg *vmsg)
     dev->log_size = log_mmap_size;
 
     vmsg->size = sizeof(vmsg->payload.u64);
+    vmsg->fd_num = 0;
 
     return true;
 }
@@ -759,6 +786,7 @@ vu_get_protocol_features_exec(VuDev *dev, VhostUserMsg *vmsg)
 
     vmsg->payload.u64 = features;
     vmsg->size = sizeof(vmsg->payload.u64);
+    vmsg->fd_num = 0;
 
     return true;
 }
-- 
2.14.3

  parent reply	other threads:[~2018-03-14 11:56 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-14 11:55 [Qemu-devel] [PATCH v6 00/29] postcopy+vhost-user/shared ram Dr. David Alan Gilbert (git)
2018-03-14 11:55 ` [Qemu-devel] [PATCH v6 01/29] migrate: Update ram_block_discard_range for shared Dr. David Alan Gilbert (git)
2018-03-14 11:55 ` [Qemu-devel] [PATCH v6 02/29] qemu_ram_block_host_offset Dr. David Alan Gilbert (git)
2018-03-14 11:55 ` [Qemu-devel] [PATCH v6 03/29] postcopy: use UFFDIO_ZEROPAGE only when available Dr. David Alan Gilbert (git)
2018-03-14 11:55 ` [Qemu-devel] [PATCH v6 04/29] postcopy: Add notifier chain Dr. David Alan Gilbert (git)
2018-03-14 11:55 ` [Qemu-devel] [PATCH v6 05/29] postcopy: Add vhost-user flag for postcopy and check it Dr. David Alan Gilbert (git)
2018-03-14 11:55 ` [Qemu-devel] [PATCH v6 06/29] vhost-user: Add 'VHOST_USER_POSTCOPY_ADVISE' message Dr. David Alan Gilbert (git)
2018-03-14 11:55 ` Dr. David Alan Gilbert (git) [this message]
2018-03-14 11:55 ` [Qemu-devel] [PATCH v6 08/29] libvhost-user: Open userfaultfd Dr. David Alan Gilbert (git)
2018-03-14 11:55 ` [Qemu-devel] [PATCH v6 09/29] postcopy: Allow registering of fd handler Dr. David Alan Gilbert (git)
2018-03-14 11:55 ` [Qemu-devel] [PATCH v6 10/29] vhost+postcopy: Register shared ufd with postcopy Dr. David Alan Gilbert (git)
2018-03-14 11:56 ` [Qemu-devel] [PATCH v6 11/29] vhost+postcopy: Transmit 'listen' to slave Dr. David Alan Gilbert (git)
2018-03-14 11:56 ` [Qemu-devel] [PATCH v6 12/29] postcopy+vhost-user: Split set_mem_table for postcopy Dr. David Alan Gilbert (git)
2018-03-14 11:56 ` [Qemu-devel] [PATCH v6 13/29] migration/ram: ramblock_recv_bitmap_test_byte_offset Dr. David Alan Gilbert (git)
2018-03-14 11:56 ` [Qemu-devel] [PATCH v6 14/29] libvhost-user+postcopy: Register new regions with the ufd Dr. David Alan Gilbert (git)
2018-03-14 11:56 ` [Qemu-devel] [PATCH v6 15/29] vhost+postcopy: Send address back to qemu Dr. David Alan Gilbert (git)
2018-03-14 11:56 ` [Qemu-devel] [PATCH v6 16/29] vhost+postcopy: Stash RAMBlock and offset Dr. David Alan Gilbert (git)
2018-03-14 11:56 ` [Qemu-devel] [PATCH v6 17/29] vhost+postcopy: Helper to send requests to source for shared pages Dr. David Alan Gilbert (git)
2018-03-14 11:56 ` [Qemu-devel] [PATCH v6 18/29] vhost+postcopy: Resolve client address Dr. David Alan Gilbert (git)
2018-03-14 11:56 ` [Qemu-devel] [PATCH v6 19/29] postcopy: helper for waking shared Dr. David Alan Gilbert (git)
2018-03-14 11:56 ` [Qemu-devel] [PATCH v6 20/29] postcopy: postcopy_notify_shared_wake Dr. David Alan Gilbert (git)
2018-03-14 11:56 ` [Qemu-devel] [PATCH v6 21/29] vhost+postcopy: Add vhost waker Dr. David Alan Gilbert (git)
2018-03-14 11:56 ` [Qemu-devel] [PATCH v6 22/29] vhost+postcopy: Call wakeups Dr. David Alan Gilbert (git)
2018-03-14 11:56 ` [Qemu-devel] [PATCH v6 23/29] libvhost-user: mprotect & madvises for postcopy Dr. David Alan Gilbert (git)
2018-03-14 11:56 ` [Qemu-devel] [PATCH v6 24/29] vhost-user: Add VHOST_USER_POSTCOPY_END message Dr. David Alan Gilbert (git)
2018-03-14 11:56 ` [Qemu-devel] [PATCH v6 25/29] vhost+postcopy: Wire up POSTCOPY_END notify Dr. David Alan Gilbert (git)
2018-03-14 11:56 ` [Qemu-devel] [PATCH v6 26/29] vhost: Huge page align and merge Dr. David Alan Gilbert (git)
2018-03-14 11:56 ` [Qemu-devel] [PATCH v6 27/29] postcopy: Allow shared memory Dr. David Alan Gilbert (git)
2018-03-14 11:56 ` [Qemu-devel] [PATCH v6 28/29] libvhost-user: Claim support for postcopy Dr. David Alan Gilbert (git)
2018-03-14 11:56 ` [Qemu-devel] [PATCH v6 29/29] postcopy shared docs Dr. David Alan Gilbert (git)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180314115618.28831-8-dgilbert@redhat.com \
    --to=dgilbert@redhat.com \
    --cc=aarcange@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=mst@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.