From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>, Keith Busch <keith.busch@intel.com>,
Linux PCI <linux-pci@vger.kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH 2/2] PCI/DPC: Do not enable DPC if AER control is not allowed by the BIOS
Date: Wed, 14 Mar 2018 14:07:15 +0200 [thread overview]
Message-ID: <20180314120715.GC2703@lahna.fi.intel.com> (raw)
In-Reply-To: <CAJZ5v0gNLi==C+_ZYiHSvbFUfTmp1nxX_bEVggrRXpUpPhptzA@mail.gmail.com>
On Wed, Mar 14, 2018 at 12:50:28PM +0100, Rafael J. Wysocki wrote:
> On Wed, Mar 14, 2018 at 12:41 PM, Mika Westerberg
> <mika.westerberg@linux.intel.com> wrote:
> > Commit eed85ff4c0da ("PCI/DPC: Enable DPC only if AER is available")
> > made DPC control dependent whether AER is enabled in the OS. However, it
> > does not take into account situations where BIOS has not given OS
> > control of AER:
> >
> > acpi PNP0A08:00: _OSC: OS supports [ExtendedConfig ASPM ClockPM Segments MSI]
> > acpi PNP0A08:00: _OSC: platform does not support [AER]
> > acpi PNP0A08:00: _OSC: OS now controls [PCIeHotplug PME PCIeCapability]
> >
> > I think here it is better not to enable DPC even if the capability is
> > available because then it would be against what "Determination of DPC
> > Control" note in PCIe 4.0 sec 6.1.10 recommends.
> >
> > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
>
> This may clash with the recent PCIe ports initialization rework from
> Bjorn, please double check.
You are right. I did not notice those changes. I'll rebase this on top
of Bjorn's pci/portdrv branch.
next prev parent reply other threads:[~2018-03-14 12:07 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-14 11:41 [PATCH 1/2] PCI/DPC: Disable interrupt generation during suspend Mika Westerberg
2018-03-14 11:41 ` [PATCH 2/2] PCI/DPC: Do not enable DPC if AER control is not allowed by the BIOS Mika Westerberg
2018-03-14 11:50 ` Rafael J. Wysocki
2018-03-14 12:07 ` Mika Westerberg [this message]
2018-03-14 11:48 ` [PATCH 1/2] PCI/DPC: Disable interrupt generation during suspend Rafael J. Wysocki
2018-03-14 12:05 ` Mika Westerberg
2018-03-14 12:33 ` Lukas Wunner
2018-03-20 10:45 ` Mika Westerberg
2018-03-20 11:35 ` Lukas Wunner
2018-03-22 10:45 ` Lukas Wunner
2018-03-22 16:53 ` Mika Westerberg
2018-03-22 17:39 ` Lukas Wunner
2018-03-22 19:36 ` Bjorn Helgaas
2018-03-23 11:18 ` Mika Westerberg
2018-03-23 21:08 ` Bjorn Helgaas
2018-03-23 21:11 ` Rafael J. Wysocki
2018-03-23 22:01 ` Bjorn Helgaas
2018-03-24 10:48 ` Rafael J. Wysocki
2018-03-24 12:15 ` Lukas Wunner
2018-03-24 13:48 ` Lukas Wunner
2018-03-24 14:09 ` Bjorn Helgaas
2018-03-26 9:55 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180314120715.GC2703@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=keith.busch@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.