From: Wei Liu <wei.liu2@citrix.com>
To: George Dunlap <george.dunlap@citrix.com>
Cc: Juergen Gross <jgross@suse.com>, Wei Liu <wei.liu2@citrix.com>,
George Dunlap <george.dunlap@eu.citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
Anthony PERARD <anthony.perard@citrix.com>,
xen-devel@lists.xenproject.org
Subject: Re: xl.cfg error in usbdev, doc and code are different
Date: Wed, 14 Mar 2018 12:46:35 +0000 [thread overview]
Message-ID: <20180314124635.krw35gqllrwt3bdk@citrix.com> (raw)
In-Reply-To: <b3d41bb3-6547-f227-b715-e609db2666b1@citrix.com>
On Wed, Mar 14, 2018 at 12:36:18PM +0000, George Dunlap wrote:
> On 03/14/2018 11:45 AM, Wei Liu wrote:
> > Cc George and Juergen
> >
> > On Wed, Mar 14, 2018 at 11:43:46AM +0000, Anthony PERARD wrote:
> >> Hi,
> >>
> >> I followed `man xl.cfg` to add an usbdev property to my guest config,
> >> and xl rejected it.
> >>
> >> # xl create "usbdev=['devtype=hostdev,hostbus=1,hostaddr=2',]" ~/arch.hvm
> >> Unknown string `devtype=hostdev' in usbdev spec
> >>
> >>
> >> In xl_parse.c, the expected string seems to be "type=hostdev", not
> >> "devtype".
> >>
> >> What's the right property name?
>
> I did some archaeology, and it appears:
>
> * In response to v7 of Chunyan's pvusb series, I suggested adding the
> 'type=hostdev' option (in response to patch 7/7, xl.cfg)
>
> * In v8 of the series, Chunyan added the "devtype=hostdev" option (in
> 5/7, the command-line parsing functions, which are re-used for config
> parsing). It was also called "devtype" in the xl.cfg man page.
>
> * In v9 first send, Chunyan still had "devtype=hostdev" in the parser
> and the man page
>
> * In v9's RESEND (to which I gave my R-b), it had silently changed to
> "type=hostdev" in the parser, but was still "devtype=hostdev" in the man
> page.
>
> Personally I'd probably change the docs to fit the actual behavior. Any
> other thoughts?
I don't have an opinion on which entity to chang if there is no
compatibility issue.
Juergen, does suse uses this parameter?
Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-03-14 12:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-14 11:43 xl.cfg error in usbdev, doc and code are different Anthony PERARD
2018-03-14 11:45 ` Wei Liu
2018-03-14 12:36 ` George Dunlap
2018-03-14 12:46 ` Wei Liu [this message]
2018-03-14 13:12 ` Juergen Gross
2018-03-14 14:51 ` Anthony PERARD
2018-03-14 15:00 ` [PATCH] docs: Fix entry for the "usbdev" option Anthony PERARD
2018-03-14 17:05 ` George Dunlap
2018-03-14 17:07 ` Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180314124635.krw35gqllrwt3bdk@citrix.com \
--to=wei.liu2@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=anthony.perard@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=jgross@suse.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.